mirror
/
go
mirror of https://github.com/golang/go.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
go/gopls/internal/lsp/source
History
Alan Donovan 60ddccae85 internal/diff: Apply: validate inputs 
Apply now checks that its edits are valid
(not out of bounds or overlapping),
and reports an error if not.

It also sorts them, if necessary, using (start, end)
as the key, to ensure that insertions (end=start)
are ordered before deletions at the same point
(but without changing the relative order of insertions).

Two other implementations of the diff.Apply algorithm
have been eliminated. (One of them failed to sort edits,
requiring the protocol sender to do so; that burden
is now gone.)

Change-Id: Ia76e485e6869db4a165835c3312fd14bc7d43db2
Reviewed-on: https://go-review.googlesource.com/c/tools/+/439278
Auto-Submit: Alan Donovan <adonovan@google.com>
gopls-CI: kokoro <noreply+kokoro@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Robert Findley <rfindley@google.com>
Run-TryBot: Alan Donovan <adonovan@google.com>
 		2022-10-07 14:24:20 +00:00
..
completion internal/diff: simplify API, break span dependency 2022-10-05 20:32:15 +00:00
add_import.go gopls: migrate internal/lsp to gopls/internal/lsp 2022-09-07 16:44:44 +00:00
api_json.go gopls: deprecate three experimental features 2022-09-28 16:54:30 +00:00
call_hierarchy.go gopls: migrate internal/lsp to gopls/internal/lsp 2022-09-07 16:44:44 +00:00
code_lens.go gopls: migrate internal/lsp to gopls/internal/lsp 2022-09-07 16:44:44 +00:00
comment.go gopls: migrate internal/lsp to gopls/internal/lsp 2022-09-07 16:44:44 +00:00
comment_go118.go gopls: migrate internal/lsp to gopls/internal/lsp 2022-09-07 16:44:44 +00:00
comment_go118_test.go gopls: migrate internal/lsp to gopls/internal/lsp 2022-09-07 16:44:44 +00:00
diagnostics.go gopls: migrate internal/lsp to gopls/internal/lsp 2022-09-07 16:44:44 +00:00
extract.go gopls: fix out of bounds bug in extract 2022-09-21 16:48:39 +00:00
fix.go gopls: migrate internal/lsp to gopls/internal/lsp 2022-09-07 16:44:44 +00:00
folding_range.go gopls: migrate internal/lsp to gopls/internal/lsp 2022-09-07 16:44:44 +00:00
format.go internal/diff: Apply: validate inputs 2022-10-07 14:24:20 +00:00
format_test.go gopls: migrate internal/lsp to gopls/internal/lsp 2022-09-07 16:44:44 +00:00
gc_annotations.go gopls: migrate internal/lsp to gopls/internal/lsp 2022-09-07 16:44:44 +00:00
highlight.go gopls/internal/lsp/source: don't type-check in FindPackageFromPos 2022-10-05 17:57:07 +00:00
hover.go gopls/internal/lsp/source: don't type-check in FindPackageFromPos 2022-10-05 17:57:07 +00:00
identifier.go gopls/internal/lsp/source: use PackageFromFile in Identifier 2022-10-05 17:59:47 +00:00
identifier_test.go gopls: migrate internal/lsp to gopls/internal/lsp 2022-09-07 16:44:44 +00:00
implementation.go gopls/internal/lsp/source: don't type-check in FindPackageFromPos 2022-10-05 17:57:07 +00:00
inlay_hint.go gopls: migrate internal/lsp to gopls/internal/lsp 2022-09-07 16:44:44 +00:00
known_packages.go gopls: migrate internal/lsp to gopls/internal/lsp 2022-09-07 16:44:44 +00:00
options.go internal/diff: simplify API, break span dependency 2022-10-05 20:32:15 +00:00
options_test.go gopls: migrate internal/lsp to gopls/internal/lsp 2022-09-07 16:44:44 +00:00
references.go gopls/internal/lsp/source: don't type-check in FindPackageFromPos 2022-10-05 17:57:07 +00:00
rename.go internal/diff: Apply: validate inputs 2022-10-07 14:24:20 +00:00
rename_check.go gopls: migrate internal/lsp to gopls/internal/lsp 2022-09-07 16:44:44 +00:00
signature_help.go gopls/internal/lsp/source: don't type-check in FindPackageFromPos 2022-10-05 17:57:07 +00:00
source_test.go internal/diff: Apply: validate inputs 2022-10-07 14:24:20 +00:00
stub.go internal/diff: simplify API, break span dependency 2022-10-05 20:32:15 +00:00
symbols.go internal/lsp/source: derive document symbols from syntax alone 2022-09-23 13:51:08 +00:00
types_format.go gopls/internal/lsp/source: don't type-check in FindPackageFromPos 2022-10-05 17:57:07 +00:00
util.go gopls/internal/lsp/source: don't type-check in FindPackageFromPos 2022-10-05 17:57:07 +00:00
util_test.go gopls: migrate internal/lsp to gopls/internal/lsp 2022-09-07 16:44:44 +00:00
view.go gopls/internal/lsp/source: don't type-check in FindPackageFromPos 2022-10-05 17:57:07 +00:00
workspace_symbol.go gopls: migrate internal/lsp to gopls/internal/lsp 2022-09-07 16:44:44 +00:00
workspace_symbol_test.go gopls: migrate internal/lsp to gopls/internal/lsp 2022-09-07 16:44:44 +00:00