mirror of https://github.com/golang/go.git
805b4d5636
Currently, when a command scheduled by bgrun fails, bgwait returns to the caller even in case the fatal error was detected. In case of a syntax error in one of the standard packages, as an example, the runInstall function will try to read the generated archive file, only to fail since the file does not exist. Since the runInstall function is called in a goroutine, cmd/dist will continue to report errors until all background goroutines are done. Update the bgwait function to wait until program termination in case of a fatal error, since returning to the caller (with an error, as an example) will cause cmd/dist to report an additional error during the next build phase. Fixes #45410 Change-Id: If89976abad70f8d6ec79b2a5a1f2306e9c034c5a Reviewed-on: https://go-review.googlesource.com/c/go/+/320311 Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Ian Lance Taylor <iant@golang.org> Trust: Dmitri Shuralyov <dmitshur@golang.org> |
||
|---|---|---|
| .. | ||
| README | ||
| build.go | ||
| buildgo.go | ||
| buildruntime.go | ||
| buildtag.go | ||
| buildtool.go | ||
| doc.go | ||
| exec.go | ||
| imports.go | ||
| main.go | ||
| sys_default.go | ||
| sys_windows.go | ||
| test.go | ||
| test_linux.go | ||
| util.go | ||
| util_gc.go | ||
| util_gccgo.go | ||
| vfp_arm.s | ||
| vfp_default.s | ||
README
This program, dist, is the bootstrapping tool for the Go distribution. As of Go 1.5, dist and other parts of the compiler toolchain are written in Go, making bootstrapping a little more involved than in the past. The approach is to build the current release of Go with an earlier one. The process to install Go 1.x, for x ≥ 5, is: 1. Build cmd/dist with Go 1.4. 2. Using dist, build Go 1.x compiler toolchain with Go 1.4. 3. Using dist, rebuild Go 1.x compiler toolchain with itself. 4. Using dist, build Go 1.x cmd/go (as go_bootstrap) with Go 1.x compiler toolchain. 5. Using go_bootstrap, build the remaining Go 1.x standard library and commands. NOTE: During the transition from the old C-based toolchain to the Go-based one, step 2 also builds the parts of the toolchain written in C, and step 3 does not recompile those. Because of backward compatibility, although the steps above say Go 1.4, in practice any release ≥ Go 1.4 but < Go 1.x will work as the bootstrap base. See golang.org/s/go15bootstrap for more details. Compared to Go 1.4 and earlier, dist will also take over much of what used to be done by make.bash/make.bat/make.rc and all of what used to be done by run.bash/run.bat/run.rc, because it is nicer to implement that logic in Go than in three different scripting languages simultaneously.