58e42b946b
Before CL 471595, modload.readModGraph in module with graph pruning enabled only ever chased down transitive dependencies of unpruned roots, so pruned dependencies couldn't cause cycles and we didn't need to dedup them in the loading queue. However, in 'go get' we are now passing in a set of upgraded modules to unprune, and those upgraded modules can potentially contain cycles, leading to an infinite loop during loading. We have two options for a fix: we could either drop the 'unprune' check in the enqueue operation (and instead expand the 'unprune' requirements in a separate pass, as we do in workspace mode), or we could check for cycles for all modules (not just the ones that are naturally unpruned). The latter option makes it clearer that this process must terminate, so we choose that. (It may be possible to clean up and simplify the workspace-mode case now that we are passing in the 'unprune' map, but for now we're looking for a minimal fix for the Go 1.21 release.) Fixes #60490. Change-Id: I701f5d43a35e357f6c0c0c9d10b7aa088f917311 Reviewed-on: https://go-review.googlesource.com/c/go/+/499195 TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Michael Matloob <matloob@golang.org> Run-TryBot: Bryan Mills <bcmills@google.com> Auto-Submit: Bryan Mills <bcmills@google.com> |
||
|---|---|---|
| .github | ||
| api | ||
| doc | ||
| lib/time | ||
| misc | ||
| src | ||
| test | ||
| .gitattributes | ||
| .gitignore | ||
| CONTRIBUTING.md | ||
| LICENSE | ||
| PATENTS | ||
| README.md | ||
| SECURITY.md | ||
| codereview.cfg | ||
| go.env | ||
README.md
The Go Programming Language
Go is an open source programming language that makes it easy to build simple, reliable, and efficient software.
Gopher image by Renee French, licensed under Creative Commons 4.0 Attributions license.
Our canonical Git repository is located at https://go.googlesource.com/go. There is a mirror of the repository at https://github.com/golang/go.
Unless otherwise noted, the Go source files are distributed under the BSD-style license found in the LICENSE file.
Download and Install
Binary Distributions
Official binary distributions are available at https://go.dev/dl/.
After downloading a binary release, visit https://go.dev/doc/install for installation instructions.
Install From Source
If a binary distribution is not available for your combination of operating system and architecture, visit https://go.dev/doc/install/source for source installation instructions.
Contributing
Go is the work of thousands of contributors. We appreciate your help!
To contribute, please read the contribution guidelines at https://go.dev/doc/contribute.
Note that the Go project uses the issue tracker for bug reports and proposals only. See https://go.dev/wiki/Questions for a list of places to ask questions about the Go language.