57f7bc3a05
Previously, the read method checked whether the current block was fully consumed or not based on whether the buffer could be filled with a non-zero number of bytes. This check is problematic because zero bytes could be read if the provided buffer is empty. We fix this case by simply checking for whether the input buffer provided by the user was empty or not. If empty, we assume that we could not read any bytes because the buffer was too small, rather than indicating that the current block was fully exhausted. This check causes bzip2.Reader to be unable to make progress on the next block unless a non-empty buffer is provided. However, that is an entirely reasonable expectation since a non-empty buffer needs to be provided eventually anyways to read the actual contents of subsequent blocks. Fixes #22028 Change-Id: I2bb1b2d54e78567baf2bf7b490a272c0853d7bfe Reviewed-on: https://go-review.googlesource.com/66110 Reviewed-by: Ian Lance Taylor <iant@golang.org> |
||
|---|---|---|
| .github | ||
| api | ||
| doc | ||
| lib/time | ||
| misc | ||
| src | ||
| test | ||
| .gitattributes | ||
| .gitignore | ||
| AUTHORS | ||
| CONTRIBUTING.md | ||
| CONTRIBUTORS | ||
| LICENSE | ||
| PATENTS | ||
| README.md | ||
| favicon.ico | ||
| robots.txt | ||
README.md
The Go Programming Language
Go is an open source programming language that makes it easy to build simple, reliable, and efficient software.
Gopher image by Renee French, licensed under Creative Commons 3.0 Attributions license.
Our canonical Git repository is located at https://go.googlesource.com/go. There is a mirror of the repository at https://github.com/golang/go.
Unless otherwise noted, the Go source files are distributed under the BSD-style license found in the LICENSE file.
Download and Install
Binary Distributions
Official binary distributions are available at https://golang.org/dl/.
After downloading a binary release, visit https://golang.org/doc/install or load doc/install.html in your web browser for installation instructions.
Install From Source
If a binary distribution is not available for your combination of operating system and architecture, visit https://golang.org/doc/install/source or load doc/install-source.html in your web browser for source installation instructions.
Contributing
Go is the work of hundreds of contributors. We appreciate your help!
To contribute, please read the contribution guidelines: https://golang.org/doc/contribute.html
Note that the Go project does not use GitHub pull requests, and that we use the issue tracker for bug reports and proposals only. See https://golang.org/wiki/Questions for a list of places to ask questions about the Go language.