go/cmd/godoc
Bryan C. Mills b978661c6c cmd/godoc: streamline test subprocesses
- Use testenv.Command to obtain Cmd instances that terminate (with
  useful goroutine dumps!) before the test's timeout, and remove
  arbitrary hard-coded timeouts.

- Execute the test binary itself as cmd/godoc instead of invoking (and
  cleaning up after) 'go build'.

- Use context cancellation to reduce the number of ad-hoc goroutines
  and channels needed by the tests and to provide stronger invariants
  on process cleanup.

For golang/go#50014

Change-Id: I19ae4d10da691db233c79734799ae074ffdf6a03
Reviewed-on: https://go-review.googlesource.com/c/tools/+/377836
Run-TryBot: Bryan Mills <bcmills@google.com>
Reviewed-by: Joedian Reid <joedian@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
gopls-CI: kokoro <noreply+kokoro@google.com>
Auto-Submit: Bryan Mills <bcmills@google.com>
2022-11-21 16:55:09 +00:00
..
doc.go cmd: gofmt 2022-04-12 17:38:38 +00:00
godoc_test.go cmd/godoc: streamline test subprocesses 2022-11-21 16:55:09 +00:00
goroot.go all: replace all usages of os/exec with golang.org/x/sys/execabs 2021-01-19 22:25:03 +00:00
handlers.go playground: remove /share registration, add Proxy 2021-02-25 15:03:53 +00:00
main.go cmd/godoc: remove usage of golang.org/x/xerrors 2022-04-20 16:11:05 +00:00