go/src
Michael Pratt 532c6f1c8d cmd/compile: fail noder.LookupFunc gracefully if function generic
PGO uses noder.LookupFunc to look for devirtualization targets in
export data.  LookupFunc does not support type-parameterized
functions, and will currently fail the build when attempting to lookup
a type-parameterized function because objIdx is passed the wrong
number of type arguments.

This doesn't usually come up, as a PGO profile will report a generic
function with a symbol name like Func[.go.shape.foo]. In export data,
this is just Func, so when we do LookupFunc("Func[.go.shape.foo]")
lookup simply fails because the name doesn't exist.

However, if Func is not generic when the profile is collected, but the
source has since changed to make Func generic, then LookupFunc("Func")
will find the object successfully, only to fail the build because we
failed to provide type arguments.

Handle this with a objIdxMayFail, which allows graceful failure if the
object requires type arguments.

Bumping the language version to 1.21 in pgo_devirtualize_test.go is
required for type inference of the uses of mult.MultFn in
cmd/compile/internal/test/testdata/pgo/devirtualize/devirt_test.go.

Fixes #65615.

Change-Id: I84d9344840b851182f5321b8f7a29a591221b29f
Reviewed-on: https://go-review.googlesource.com/c/go/+/562737
Reviewed-by: Cherry Mui <cherryyz@google.com>
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
2024-02-09 20:03:18 +00:00
..
archive archive/zip: reduce memory held by Writer.Copy 2024-02-06 12:43:52 +00:00
arena
bufio
builtin builtin: mention PanicNilError in comments of recover 2023-12-18 19:42:41 +00:00
bytes runtime: short path for equal pointers in arm64 memequal 2024-01-24 16:07:25 +00:00
cmd cmd/compile: fail noder.LookupFunc gracefully if function generic 2024-02-09 20:03:18 +00:00
cmp cmp: add test case for uinitptr 2024-01-17 17:58:34 +00:00
compress
container container/heap: remove confusing claim of memory leak 2024-01-31 20:27:36 +00:00
context context: improve valueCtx.String 2024-02-09 00:58:17 +00:00
crypto all: fix typos 2024-01-30 20:09:45 +00:00
database/sql all: remove newline characters after return statements 2023-12-14 17:22:18 +00:00
debug debug/gosym: add detailed doc for text argument in NewLineTable 2024-01-25 19:43:24 +00:00
embed
encoding encoding/xml: rewrite func procInst 2024-02-08 20:33:51 +00:00
errors
expvar
flag
fmt fmt: update docs for %03s 2024-01-31 14:16:48 +00:00
go go/types, types2: factor out hasDots to check for ... arguments in calls (cleanup) 2024-02-08 19:31:44 +00:00
hash hash/crc32: fix codegen to align with manual changes 2024-01-23 00:03:20 +00:00
html
image
index/suffixarray
internal cmd/trace/v2,internal/trace: use correct frame for identifying goroutines 2024-02-09 16:30:09 +00:00
io io/fs: godoc links to testing/fstest 2024-01-15 21:21:41 +00:00
iter iter: fix race instrumentation for Pull2 2023-12-13 16:20:09 +00:00
log log/slog: add missing test in value_test.go 2024-01-30 20:10:22 +00:00
maps maps: correct use of linkname 2024-01-26 04:31:27 +00:00
math math/big,crypto/internal/bigmod: unroll loop in addMulVVW for ppc64x 2024-01-25 19:32:43 +00:00
mime
net net: don't return errno from _C_res_nsearch 2024-02-07 23:50:56 +00:00
os runtime,internal/syscall/windows: remove long path support check 2024-02-07 20:54:38 +00:00
path io/fs,path/filepath: fix typo in SkipAll/SkipDir doc 2024-01-09 08:50:19 +00:00
plugin
reflect reflect: use MapMaxKeyBytes,MapMaxElemBytes,MapBucketCount of internal/abi 2024-01-26 17:17:07 +00:00
regexp
runtime runtime: traceback: include pc=0x%x for inline frames 2024-02-08 21:44:52 +00:00
slices slices: document that BinarySearch[Func] return earliest position 2024-02-07 23:54:41 +00:00
sort sort: use math/rand/v2 in tests and benchmarks 2024-02-08 22:59:40 +00:00
strconv
strings
sync sync: update doc for Map.Clear 2024-02-01 19:34:02 +00:00
syscall all: fix typos 2024-01-30 20:09:45 +00:00
testdata
testing
text all: remove newline characters after return statements 2023-12-14 17:22:18 +00:00
time time: fix FuzzFormatRFC3339 nano comparison 2024-02-08 23:28:17 +00:00
unicode
unsafe
vendor all: update golang.org/x/sys and vendor it 2024-02-08 20:35:26 +00:00
Make.dist
README.vendor
all.bash
all.bat
all.rc
bootstrap.bash
buildall.bash
clean.bash
clean.bat
clean.rc
cmp.bash
go.mod all: update golang.org/x/sys and vendor it 2024-02-08 20:35:26 +00:00
go.sum all: update golang.org/x/sys and vendor it 2024-02-08 20:35:26 +00:00
make.bash
make.bat
make.rc
race.bash
race.bat
run.bash
run.bat
run.rc

README.vendor

Vendoring in std and cmd
========================

The Go command maintains copies of external packages needed by the
standard library in the src/vendor and src/cmd/vendor directories.

There are two modules, std and cmd, defined in src/go.mod and
src/cmd/go.mod. When a package outside std or cmd is imported
by a package inside std or cmd, the import path is interpreted
as if it had a "vendor/" prefix. For example, within "crypto/tls",
an import of "golang.org/x/crypto/cryptobyte" resolves to
"vendor/golang.org/x/crypto/cryptobyte". When a package with the
same path is imported from a package outside std or cmd, it will
be resolved normally. Consequently, a binary may be built with two
copies of a package at different versions if the package is
imported normally and vendored by the standard library.

Vendored packages are internally renamed with a "vendor/" prefix
to preserve the invariant that all packages have distinct paths.
This is necessary to avoid compiler and linker conflicts. Adding
a "vendor/" prefix also maintains the invariant that standard
library packages begin with a dotless path element.

The module requirements of std and cmd do not influence version
selection in other modules. They are only considered when running
module commands like 'go get' and 'go mod vendor' from a directory
in GOROOT/src.

Maintaining vendor directories
==============================

Before updating vendor directories, ensure that module mode is enabled.
Make sure that GO111MODULE is not set in the environment, or that it is
set to 'on' or 'auto'.

Requirements may be added, updated, and removed with 'go get'.
The vendor directory may be updated with 'go mod vendor'.
A typical sequence might be:

    cd src
    go get golang.org/x/net@master
    go mod tidy
    go mod vendor

Use caution when passing '-u' to 'go get'. The '-u' flag updates
modules providing all transitively imported packages, not only
the module providing the target package.

Note that 'go mod vendor' only copies packages that are transitively
imported by packages in the current module. If a new package is needed,
it should be imported before running 'go mod vendor'.