go/src
go101 4e8d27068d reflect: factor out special channel assignability rule from haveIdenticalUnderlyingType
Go specification says: A value x is assignable to a variable of type T if x
is a bidirectional channel value, T is a channel type, x's type V and T have
identical element types, and at least one of V or T is not a defined type.
However, the current reflection implementation is incorrect which makes
"x is assignable to T" even if type V and T are both defined type.

The current reflection implementation also mistakes the base types of two
non-defined pointer types share the same underlying type when the two
base types satisfy the above mentioned special channel assignability rule.

Fixes #29469

Change-Id: Ia4b9c4ac47dc8e76a11faef422b2e5c5726b78b3
GitHub-Last-Rev: 487c20a564
GitHub-Pull-Request: golang/go#29739
Reviewed-on: https://go-review.googlesource.com/c/go/+/157822
Run-TryBot: Ian Lance Taylor <iant@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
2019-11-15 15:17:08 +00:00
..
archive
bufio bufio: return the underlying error in ReadFrom if not nil 2019-10-31 17:21:56 +00:00
builtin
bytes hash/maphash: move bytes/hash to hash/maphash 2019-11-02 18:30:37 +00:00
cmd cmd/internal/obj/x86: mark 2-instruction TLS access nonpreemptible 2019-11-15 02:31:58 +00:00
compress
container
context context: mark testDeadline as a testing helper method 2019-10-29 14:22:15 +00:00
crypto src/vendor,crypto/tls: update to latest x/crypto and use new X25519 API 2019-11-13 01:15:54 +00:00
database/sql database/sql: remove forced log import from test 2019-10-21 19:27:15 +00:00
debug [dev.link] all: reenable cgo internal linking tests 2019-11-02 19:21:24 +00:00
encoding encoding/json: error when encoding a pointer cycle 2019-11-11 16:24:21 +00:00
errors
expvar
flag flag: clarify that a flag cannot be re-defined 2019-11-11 20:07:54 +00:00
fmt fmt: fix handling of %% verb in Scanf 2019-10-25 04:15:59 +00:00
go go/doc: document unicode quoting conversion 2019-11-12 04:25:02 +00:00
hash hash/maphash: revise API to be more idiomatic 2019-11-04 21:30:29 +00:00
html
image
index/suffixarray
internal internal/cpu,internal/bytealg: add support for riscv64 2019-11-11 22:13:42 +00:00
io io/ioutil: Fix dropped test error 2019-11-05 03:27:26 +00:00
log syscall: reenable sysctl on iOS 2019-10-23 15:12:15 +00:00
math math/big: fix out-of-bounds panic in divRecursive 2019-11-13 19:15:27 +00:00
mime
net net: fix improper Context.Deadline usage in DialContext 2019-11-15 00:03:57 +00:00
os os/signal: don't ignore SIGINT in TestAtomicStop child process 2019-11-14 01:57:00 +00:00
path
plugin
reflect reflect: factor out special channel assignability rule from haveIdenticalUnderlyingType 2019-11-15 15:17:08 +00:00
regexp regexp: skip long-running benchmarks if -short is specified 2019-10-17 19:53:52 +00:00
runtime runtime: crash if a signal is received with bad G and no extra M 2019-11-15 02:31:52 +00:00
sort
strconv strconv: reformat and tidy comments in example 2019-11-11 19:56:33 +00:00
strings strings: remove a redundant and flaky part of a test 2019-10-31 20:45:40 +00:00
sync sync: yield to the waiter when unlocking a starving mutex 2019-11-09 19:31:32 +00:00
syscall syscall: fix EpollEvent padding on mips64{,le} 2019-11-15 15:12:42 +00:00
testdata
testing testing/iotest: add missing tests 2019-11-05 17:57:10 +00:00
text text/template: add error check for parenthesized first argument in pipeline 2019-11-12 05:06:42 +00:00
time time: change variable name to next 2019-11-10 12:12:46 +00:00
unicode unicode: upgrade to Unicode 12 2019-11-05 14:34:56 +00:00
unsafe
vendor src/vendor,crypto/tls: update to latest x/crypto and use new X25519 API 2019-11-13 01:15:54 +00:00
Make.dist
README.vendor
all.bash
all.bat
all.rc
bootstrap.bash
buildall.bash
clean.bash
clean.bat
clean.rc
cmp.bash
go.mod src/vendor,crypto/tls: update to latest x/crypto and use new X25519 API 2019-11-13 01:15:54 +00:00
go.sum src/vendor,crypto/tls: update to latest x/crypto and use new X25519 API 2019-11-13 01:15:54 +00:00
iostest.bash
make.bash make.bash: show bootstrap version 2019-11-01 20:45:04 +00:00
make.bat
make.rc
race.bash
race.bat
run.bash
run.bat
run.rc

README.vendor

Vendoring in std and cmd
========================

The Go command maintains copies of external packages needed by the
standard library in the src/vendor and src/cmd/vendor directories.

In GOPATH mode, imports of vendored packages are resolved to these
directories following normal vendor directory logic
(see golang.org/s/go15vendor).

In module mode, std and cmd are modules (defined in src/go.mod and
src/cmd/go.mod). When a package outside std or cmd is imported
by a package inside std or cmd, the import path is interpreted
as if it had a "vendor/" prefix. For example, within "crypto/tls",
an import of "golang.org/x/crypto/cryptobyte" resolves to
"vendor/golang.org/x/crypto/cryptobyte". When a package with the
same path is imported from a package outside std or cmd, it will
be resolved normally. Consequently, a binary may be built with two
copies of a package at different versions if the package is
imported normally and vendored by the standard library.

Vendored packages are internally renamed with a "vendor/" prefix
to preserve the invariant that all packages have distinct paths.
This is necessary to avoid compiler and linker conflicts. Adding
a "vendor/" prefix also maintains the invariant that standard
library packages begin with a dotless path element.

The module requirements of std and cmd do not influence version
selection in other modules. They are only considered when running
module commands like 'go get' and 'go mod vendor' from a directory
in GOROOT/src.

Maintaining vendor directories
==============================

Before updating vendor directories, ensure that module mode is enabled.
Make sure GO111MODULE=off is not set ('on' or 'auto' should work).

Requirements may be added, updated, and removed with 'go get'.
The vendor directory may be updated with 'go mod vendor'.
A typical sequence might be:

    cd src
    go get -d golang.org/x/net@latest
    go mod tidy
    go mod vendor

Use caution when passing '-u' to 'go get'. The '-u' flag updates
modules providing all transitively imported packages, not only
the module providing the target package.

Note that 'go mod vendor' only copies packages that are transitively
imported by packages in the current module. If a new package is needed,
it should be imported before running 'go mod vendor'.