go/internal/lsp/mod
Rebecca Stambler c537a342dd internal/lsp: pass options by reference instead of by value
We were previously behaving as though the slice/map values in the
options struct could be modified directly. The options should be cloned
before modification. Also, convert any usage of source.Options to
*source.Options.

Fixes golang/go#39592

Change-Id: Ib39f668bca0fa1038162206bd7793fd2049af576
Reviewed-on: https://go-review.googlesource.com/c/tools/+/254558
Trust: Rebecca Stambler <rstambler@golang.org>
Run-TryBot: Rebecca Stambler <rstambler@golang.org>
gopls-CI: kokoro <noreply+kokoro@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Robert Findley <rfindley@google.com>
2020-09-16 22:53:23 +00:00
..
testdata/unchanged internal/lsp/tests: fix reset of golden files 2020-02-19 14:42:13 +00:00
code_lens.go internal/lsp/mod: handle nil pointers in code lenses 2020-09-16 15:04:07 +00:00
diagnostics.go internal/lsp: enable multi-module workspace mode by default in tests 2020-09-15 20:16:39 +00:00
format.go internal/lsp: remove Mod handles 2020-07-29 19:44:36 +00:00
hover.go internal/lsp: pass options by reference instead of by value 2020-09-16 22:53:23 +00:00
mod_test.go internal/lsp: pass options by reference instead of by value 2020-09-16 22:53:23 +00:00