Robert Findley 76325da620 internal/lsp/progress: detach context for all progress notifications ... Use a detached Context for all progress notifications. In particular, using a detached Context for the window/workDoneProgress/create notification avoids races where the $/cancelRequest notification and create response cross paths, such that the client has created a progress dialog but the server thinks that starting progress failed. Also, as a matter of best practice don't store a context on the WorkDone type, despite the fact that this Context is detached. Instead, only close over a Context in the WorkDoneWriter, which requires a Context in order to function but which implements the io.Writer interface. The TestProgressBarErrors test should now pass reliably. Fixes golang/go#46930 Change-Id: I0d115ed3a62de97fe545c8dc0403e7bb55f6e481 Reviewed-on: https://go-review.googlesource.com/c/tools/+/409936 Run-TryBot: Robert Findley <rfindley@google.com> gopls-CI: kokoro <noreply+kokoro@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Bryan Mills <bcmills@google.com>		2022-06-02 20:26:04 +00:00
..
analysis.go	gopls: remove usage of golang.org/x/xerrors	2022-04-20 15:33:22 +00:00
cache.go	internal/template: identify template files by the templateExtensions option	2022-01-13 17:30:17 +00:00
check.go	internal/lsp/cache: invalidate metadata when parsing issues resolve	2022-05-23 18:14:40 +00:00
error_test.go	internal/lsp/cache: split up sourceDiagnostics	2021-03-02 02:05:13 +00:00
errors.go	internal/span: eliminate TokenConverter	2022-06-01 19:19:15 +00:00
imports.go	internal/lsp/cache: use -workfile on 1.18	2022-02-04 14:03:59 +00:00
keys.go	internal/lsp: decouple client and server debug	2020-06-11 13:49:48 +00:00
load.go	internal/lsp/progress: detach context for all progress notifications	2022-06-02 20:26:04 +00:00
metadata.go	gopls: wire in LangVersion and ModulePath for gofumpt formatting	2022-02-24 18:08:50 +00:00
mod.go	internal/lsp: factor out column mapper construction from content	2022-06-01 19:19:49 +00:00
mod_tidy.go	internal/span: eliminate TokenConverter	2022-06-01 19:19:15 +00:00
os_darwin.go	internal/lsp/cache: clarify an error message about mismatching casing	2021-08-03 17:18:10 +00:00
os_windows.go	internal/lsp/cache: clarify an error message about mismatching casing	2021-08-03 17:18:10 +00:00
parse.go	internal/span: eliminate TokenConverter	2022-06-01 19:19:15 +00:00
parse_test.go	internal/lsp/cache: trim more stuff in ParseExported mode	2021-05-11 17:48:41 +00:00
parsemode_go116.go	internal/lsp/cache: use cached parsed files for symbols, if available	2022-05-09 17:04:06 +00:00
parsemode_go117.go	internal/lsp/cache: use cached parsed files for symbols, if available	2022-05-09 17:04:06 +00:00
pkg.go	gopls: remove usage of golang.org/x/xerrors	2022-04-20 15:33:22 +00:00
session.go	gopls: remove usage of golang.org/x/xerrors	2022-04-20 15:33:22 +00:00
snapshot.go	internal/lsp/cache: invalidate metadata when parsing issues resolve	2022-05-23 18:14:40 +00:00
symbols.go	internal/lsp/cache: invalidate metadata when parsing issues resolve	2022-05-23 18:14:40 +00:00
view.go	gopls: remove usage of golang.org/x/xerrors	2022-04-20 15:33:22 +00:00
view_test.go	internal/lsp/cache: always consider go.work files for ws expansion	2022-03-07 16:11:49 +00:00
workspace.go	gopls: remove usage of golang.org/x/xerrors	2022-04-20 15:33:22 +00:00
workspace_test.go	internal/lsp/cache: construct workspace even when go.work has error	2022-03-03 21:30:30 +00:00