go/src
Robert Findley 43b09c096a go/types, types2: record all type instances, even duplicates
Due to instance de-duplication, we were failing to record some type
instances in types.Info.Instances. Fix this by moving the instance
recording out of the resolver.

Fixes #51494

Change-Id: Iddd8989307d95886eedb321efa4ab98cd2b3573a
Reviewed-on: https://go-review.googlesource.com/c/go/+/390041
Trust: Robert Findley <rfindley@google.com>
Run-TryBot: Robert Findley <rfindley@google.com>
Reviewed-by: Robert Griesemer <gri@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
2022-03-07 20:22:05 +00:00
..
archive
bufio
builtin builtin: clarify that interface types do not implement comparable 2022-02-08 21:59:36 +00:00
bytes bytes, strings: mention Cut in docs for Split and SplitN 2022-02-08 22:25:54 +00:00
cmd go/types, types2: record all type instances, even duplicates 2022-03-07 20:22:05 +00:00
compress all: fix some typos 2022-03-06 20:47:39 +00:00
container
context
crypto all: fix some typos 2022-03-06 20:47:39 +00:00
database/sql database/sql: make WAIT tests more robust, rely on waiter trigger 2022-02-16 18:05:27 +00:00
debug all: fix some typos 2022-03-06 20:47:39 +00:00
embed
encoding encoding/xml: improve the test coverage, fix minor bugs 2022-03-04 20:29:47 +00:00
errors
expvar
flag flag: make tests silent 2022-03-07 09:29:14 +00:00
fmt fmt: clarify right-padded strings use spaces 2022-03-05 21:20:16 +00:00
go go/types, types2: record all type instances, even duplicates 2022-03-07 20:22:05 +00:00
hash
html all: fix some typos 2022-03-06 20:47:39 +00:00
image
index/suffixarray all: fix some typos 2022-03-06 20:47:39 +00:00
internal internal/fuzz: fix TestUnmarshalMarshal on MIPS 2022-03-07 15:02:48 +00:00
io
log
math all: fix some typos 2022-03-06 20:47:39 +00:00
mime
net all: fix some typos 2022-03-06 20:47:39 +00:00
os os: eliminate arbitrary sleep in Kill tests 2022-02-16 21:34:51 +00:00
path
plugin
reflect reflect: allow Value.Bytes on addressable byte arrays 2022-03-02 18:06:42 +00:00
regexp regexp: fix typo in the overview 2022-03-02 11:49:04 +00:00
runtime runtime: print goid when throwing in gentraceback 2022-03-07 16:24:54 +00:00
sort sort: use a different codegen strategy 2022-03-03 13:42:02 +00:00
strconv
strings strings: fix typo in comment 2022-02-19 00:00:52 +00:00
sync
syscall syscall: use dup3 in forkAndExecInChild on OpenBSD 2022-03-05 08:36:13 +00:00
testdata
testing testing: include ERROR_SHARING_VIOLATION in Windows cleanup retries 2022-03-03 02:39:01 +00:00
text
time time: document that Parse truncates to nanosecond precision 2022-02-15 22:54:38 +00:00
unicode unicode/utf8: optimize Valid to parity with ValidString 2022-03-02 11:33:18 +00:00
unsafe
vendor
Make.dist
README.vendor
all.bash
all.bat
all.rc
bootstrap.bash
buildall.bash
clean.bash
clean.bat
clean.rc
cmp.bash
go.mod
go.sum
make.bash
make.bat
make.rc
race.bash
race.bat
run.bash
run.bat
run.rc

README.vendor

Vendoring in std and cmd
========================

The Go command maintains copies of external packages needed by the
standard library in the src/vendor and src/cmd/vendor directories.

In GOPATH mode, imports of vendored packages are resolved to these
directories following normal vendor directory logic
(see golang.org/s/go15vendor).

In module mode, std and cmd are modules (defined in src/go.mod and
src/cmd/go.mod). When a package outside std or cmd is imported
by a package inside std or cmd, the import path is interpreted
as if it had a "vendor/" prefix. For example, within "crypto/tls",
an import of "golang.org/x/crypto/cryptobyte" resolves to
"vendor/golang.org/x/crypto/cryptobyte". When a package with the
same path is imported from a package outside std or cmd, it will
be resolved normally. Consequently, a binary may be built with two
copies of a package at different versions if the package is
imported normally and vendored by the standard library.

Vendored packages are internally renamed with a "vendor/" prefix
to preserve the invariant that all packages have distinct paths.
This is necessary to avoid compiler and linker conflicts. Adding
a "vendor/" prefix also maintains the invariant that standard
library packages begin with a dotless path element.

The module requirements of std and cmd do not influence version
selection in other modules. They are only considered when running
module commands like 'go get' and 'go mod vendor' from a directory
in GOROOT/src.

Maintaining vendor directories
==============================

Before updating vendor directories, ensure that module mode is enabled.
Make sure GO111MODULE=off is not set ('on' or 'auto' should work).

Requirements may be added, updated, and removed with 'go get'.
The vendor directory may be updated with 'go mod vendor'.
A typical sequence might be:

    cd src
    go get -d golang.org/x/net@latest
    go mod tidy
    go mod vendor

Use caution when passing '-u' to 'go get'. The '-u' flag updates
modules providing all transitively imported packages, not only
the module providing the target package.

Note that 'go mod vendor' only copies packages that are transitively
imported by packages in the current module. If a new package is needed,
it should be imported before running 'go mod vendor'.