go/src
Lynn Boger 402f177efc cmd/compile: fix intrinsic setting for mul64, add64 on ppc64le
I found a performance regression between the runtime.Hash
benchmarks when comparing Go 1.16 to latest on ppc64le. This
was due to the addition of Mul64 to runtime/internal/math
with the comments that this should be treated as an intrinsic
on platforms where available. However this is was not being
intrinsified on ppc64le because the code in ssagen/ssa.go didn't
correctly specify ppc64le. It had the argument for ArchPPC64
but should have also included ArchPPC64LE.

Treating Mul64 as an intrinsic shows this improvement, and these
results are better than Go 1.16:

Hash5        27.0ns ± 0%     14.0ns ± 0%   -48.1
Hash16       26.6ns ± 0%     14.0ns ± 0%   -47.3
Hash64       50.7ns ± 0%     17.9ns ± 0%   -64.6
Hash1024      500ns ± 0%       99ns ± 0%   -80.1
Hash65536    30.6µs ± 0%      4.0µs ± 0%   -86

Many of the Map related benchmarks in the runtime package also showed
improvement once Mul64 is intrinsified.

Change-Id: I3b5ce637b1620348d81a30cfc359c97ab63aae0f
Reviewed-on: https://go-review.googlesource.com/c/go/+/317303
Run-TryBot: Lynn Boger <laboger@linux.vnet.ibm.com>
Reviewed-by: Paul Murphy <murp@ibm.com>
Reviewed-by: Keith Randall <khr@golang.org>
Reviewed-by: Cherry Mui <cherryyz@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
2021-05-06 18:08:01 +00:00
..
archive archive/zip: add File.OpenRaw, Writer.CreateRaw, Writer.Copy 2021-05-03 21:11:47 +00:00
bufio bufio: mention ErrFinalToken in SplitFunc documentation 2021-04-30 19:34:38 +00:00
builtin
bytes
cmd cmd/compile: fix intrinsic setting for mul64, add64 on ppc64le 2021-05-06 18:08:01 +00:00
compress
container
context
crypto crypto/x509: rewrite certificate parser 2021-05-06 17:09:23 +00:00
database/sql database/sql: add NullInt16 and NullByte 2021-05-04 17:31:29 +00:00
debug all: do not test internal linking on windows/arm64 2021-04-23 21:48:37 +00:00
embed embed/internal/embedtest: add test for embedded path starting with dash 2021-05-04 23:35:34 +00:00
encoding encoding/csv: add FieldPos method 2021-04-29 17:47:48 +00:00
errors
expvar
flag
fmt
go go/parser: don't parse a nil IndexExpr.Index 2021-05-05 20:58:39 +00:00
hash
html text/template: add lock for Template.tmpl to fix data race 2021-05-04 00:03:39 +00:00
image
index/suffixarray
internal internal/buildcfg: set Error instead of panicking 2021-05-04 18:27:33 +00:00
io
log
math math/big: check for excessive exponents in Rat.SetString 2021-05-06 16:00:55 +00:00
mime net/http: ignore directory path when parsing multipart forms 2021-05-05 18:14:49 +00:00
net net/http: ignore directory path when parsing multipart forms 2021-05-05 18:14:49 +00:00
os os: skip TestExecutableDeleted on plan9 2021-05-04 18:47:19 +00:00
path path/filepath: fix documentation typo (was "each each") 2021-05-02 18:13:38 +00:00
plugin
reflect cmd/compile: set unsayable "names" for regabi testing triggers 2021-05-06 11:58:39 +00:00
regexp
runtime runtime: gofmt proc_test.go 2021-05-06 12:33:02 +00:00
sort
strconv strconv: fix a typo 2021-05-04 03:22:47 +00:00
strings
sync sync/atomic: add (*Value).Swap and (*Value).CompareAndSwap 2021-05-04 00:15:27 +00:00
syscall syscall: add //go:build lines to assembly files 2021-05-04 12:47:05 +00:00
testdata
testing testing: add -shuffle=off|on|N to alter the execution order of tests and benchmarks 2021-04-28 16:06:21 +00:00
text text/template: fix type bug in eq 2021-05-06 13:39:39 +00:00
time time: make time.Time print a valid Go string with %#v 2021-05-02 20:59:26 +00:00
unicode
unsafe
vendor all: update vendored dependencies for Go 1.17 2021-05-05 15:53:03 +00:00
Make.dist
README.vendor
all.bash
all.bat
all.rc
bootstrap.bash
buildall.bash
clean.bash
clean.bat
clean.rc
cmp.bash
go.mod all: update vendored dependencies for Go 1.17 2021-05-05 15:53:03 +00:00
go.sum all: update vendored dependencies for Go 1.17 2021-05-05 15:53:03 +00:00
make.bash
make.bat
make.rc
race.bash
race.bat
run.bash
run.bat
run.rc

README.vendor

Vendoring in std and cmd
========================

The Go command maintains copies of external packages needed by the
standard library in the src/vendor and src/cmd/vendor directories.

In GOPATH mode, imports of vendored packages are resolved to these
directories following normal vendor directory logic
(see golang.org/s/go15vendor).

In module mode, std and cmd are modules (defined in src/go.mod and
src/cmd/go.mod). When a package outside std or cmd is imported
by a package inside std or cmd, the import path is interpreted
as if it had a "vendor/" prefix. For example, within "crypto/tls",
an import of "golang.org/x/crypto/cryptobyte" resolves to
"vendor/golang.org/x/crypto/cryptobyte". When a package with the
same path is imported from a package outside std or cmd, it will
be resolved normally. Consequently, a binary may be built with two
copies of a package at different versions if the package is
imported normally and vendored by the standard library.

Vendored packages are internally renamed with a "vendor/" prefix
to preserve the invariant that all packages have distinct paths.
This is necessary to avoid compiler and linker conflicts. Adding
a "vendor/" prefix also maintains the invariant that standard
library packages begin with a dotless path element.

The module requirements of std and cmd do not influence version
selection in other modules. They are only considered when running
module commands like 'go get' and 'go mod vendor' from a directory
in GOROOT/src.

Maintaining vendor directories
==============================

Before updating vendor directories, ensure that module mode is enabled.
Make sure GO111MODULE=off is not set ('on' or 'auto' should work).

Requirements may be added, updated, and removed with 'go get'.
The vendor directory may be updated with 'go mod vendor'.
A typical sequence might be:

    cd src
    go get -d golang.org/x/net@latest
    go mod tidy
    go mod vendor

Use caution when passing '-u' to 'go get'. The '-u' flag updates
modules providing all transitively imported packages, not only
the module providing the target package.

Note that 'go mod vendor' only copies packages that are transitively
imported by packages in the current module. If a new package is needed,
it should be imported before running 'go mod vendor'.