mirror of https://github.com/golang/go.git
As per the current specification, the correct token name that represents methods is `method`. The current implementation does not produce the correct set of result and results in methods being incorrectly highlighted. Furthermore, the parameter names of interface methods are treated as `method` which is not true, so a fix has been applied to handle `ast.FuncType` being `parameter`. Spec: https://microsoft.github.io/language-server-protocol/specifications/specification-3-16/#textDocument_semanticTokens Change-Id: Id5d2fafe9f948a4a175ae19b4c94cca8f48a4b79 GitHub-Last-Rev: 9a3b65ca4dd3bb0542969c043a2042001c7fcb63 GitHub-Pull-Request: golang/tools#340 Reviewed-on: https://go-review.googlesource.com/c/tools/+/349449 Run-TryBot: Peter Weinberger <pjw@google.com> gopls-CI: kokoro <noreply+kokoro@google.com> TryBot-Result: Go Bot <gobot@golang.org> Trust: Rebecca Stambler <rstambler@golang.org> Trust: Peter Weinberger <pjw@google.com> Reviewed-by: Peter Weinberger <pjw@google.com> |
||
|---|---|---|
| .. | ||
| README.md | ||
| a.go | ||
| a.go.golden | ||
| b.go | ||
| b.go.golden | ||
| semantic_test.go | ||
README.md
The golden files are the output of gopls semtok <src-file>, with -- semantic --
inserted as the first line (the spaces are mandatory) and an extra newline at the end.