go/src
Russ Cox 3afa5daabd cmd/distpack: sort files in standard walk order
The code was sorting files in the archives entirely by path string,
but that's not what fs.WalkDir would do. In a directory with
subdirectory foo/bar and file foo/bar.go, foo/bar gets visited
first, so foo/bar/baz appears before foo/bar.go, even though
"foo/bar/baz" > "foo/bar.go".

This CL replaces the string comparison with a path-aware
comparison that places foo/bar/baz before foo/bar.go,
so that if the tar file is extracted and then repacked using
fs.WalkDir, the files will remain in the same order.

This will make it easier to compare the pristine distpack-produced
tgz for darwin against the rebuilt tgz with signed binaries.

Before:
% tar tzvf /tmp/cmddist.tgz | grep -C1 runtime/cgo.go
-rw-r--r--  0 0      0       11122 Jul 13 15:00 go/src/runtime/callers_test.go
-rw-r--r--  0 0      0        2416 Jul 13 15:00 go/src/runtime/cgo.go
-rw-r--r--  0 0      0        2795 Jul 13 15:00 go/src/runtime/cgo/abi_amd64.h

After:
% tar tzvf pkg/distpack/go1.21rsc.src.tar.gz | grep -C1 runtime/cgo.go
-rw-r--r--  0 0      0        1848 Dec 31  1969 go/src/runtime/cgo/signal_ios_arm64.s
-rw-r--r--  0 0      0        2416 Dec 31  1969 go/src/runtime/cgo.go
-rw-r--r--  0 0      0        2479 Dec 31  1969 go/src/runtime/cgo_mmap.go

For #24904.
For #61513.

Change-Id: Ib7374bc0d6324377f81c561bef57fd87b2111b98
Reviewed-on: https://go-review.googlesource.com/c/go/+/511977
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Heschi Kreinick <heschi@google.com>
Run-TryBot: Russ Cox <rsc@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
2023-07-26 19:28:08 +00:00
..
archive
arena
bufio
builtin cmp, builtin: document NaN behavior 2023-06-11 00:41:42 +00:00
bytes bytes: remove builders check from compare test 2023-07-13 23:11:42 +00:00
cmd cmd/distpack: sort files in standard walk order 2023-07-26 19:28:08 +00:00
cmp cmp, builtin: document NaN behavior 2023-06-11 00:41:42 +00:00
compress compress/bzip2: fix typo 2023-06-16 18:24:46 +00:00
container
context context: fix doc tipo (s/timout/timeout) 2023-06-11 00:33:08 +00:00
crypto crypto/internal/boring,crypto/sha1: remove cmd_go_bootstrap build tag 2023-07-20 17:51:31 +00:00
database/sql src/database/sql: run gofmt 2023-07-07 20:48:55 +00:00
debug
embed
encoding encoding/base32: reduce overflow risk when calc encode/decode len 2023-07-26 11:18:30 +00:00
errors
expvar
flag
fmt
go sort: forward fixed-type slice sorting to slices package 2023-07-21 13:00:18 +00:00
hash all: fix spelling errors 2023-06-14 00:03:57 +00:00
html
image image/draw: replace deprecated image.ZP and image.ZR in xx_test.go 2023-07-20 18:07:05 +00:00
index/suffixarray
internal os: mark the share created by TestNetworkSymbolicLink as temporary 2023-07-25 00:57:39 +00:00
io
log log/slog: fix comment above log levels 2023-07-21 14:43:18 +00:00
maps slices, maps: add examples; doc comment fixes 2023-06-29 15:34:32 +00:00
math math: test large negative values as args for trig functions 2023-07-17 21:05:34 +00:00
mime all: fix spelling errors 2023-06-14 00:03:57 +00:00
net Revert "net/http: use Copy in ServeContent if CopyN not needed" 2023-07-24 20:40:06 +00:00
os os: remove 5ms sleep on Windows in (*Process).Wait 2023-07-26 15:13:24 +00:00
path path/filepath: avoid assuming that GOROOT/test is present 2023-06-16 19:37:46 +00:00
plugin
reflect reflect: panic on recv channel close 2023-07-21 05:39:00 +00:00
regexp all: fix typos 2023-07-18 19:55:29 +00:00
runtime runtime2: don't check fcntl errno in checkfds on AIX and Solaris 2023-07-25 23:44:31 +00:00
slices sort: add gen_sort_variants support for x/exp/slices 2023-07-25 01:33:04 +00:00
sort sort: add gen_sort_variants support for x/exp/slices 2023-07-25 01:33:04 +00:00
strconv
strings strings: add benchmark for Builder.WriteString 2023-07-20 18:00:40 +00:00
sync
syscall net: remove sysSocket fallback for Windows 7 2023-07-20 18:36:30 +00:00
testdata
testing testing: enforce -skip in example tests 2023-07-21 21:37:46 +00:00
text text/template: set variables correctly in range assignment 2023-06-15 14:28:01 +00:00
time time: document that AfterFunc Timer's C field is nil 2023-07-20 23:18:18 +00:00
unicode
unsafe
vendor all: update vendored dependencies 2023-07-12 20:38:21 +00:00
Make.dist
README.vendor src/README.vendor: s/latest/master/ 2023-07-11 21:30:51 +00:00
all.bash
all.bat
all.rc
bootstrap.bash
buildall.bash
clean.bash
clean.bat
clean.rc
cmp.bash cmp.bash: fix comment grammar 2023-07-20 18:03:31 +00:00
go.mod all: update go.mod go version to 1.22 2023-07-18 21:24:24 +00:00
go.sum all: update vendored dependencies 2023-07-12 20:38:21 +00:00
make.bash make.bash,bat,rc: use Go 1.20.6 instead of Go 1.17.13 2023-07-24 02:49:20 +00:00
make.bat make.bash,bat,rc: use Go 1.20.6 instead of Go 1.17.13 2023-07-24 02:49:20 +00:00
make.rc make.bash,bat,rc: use Go 1.20.6 instead of Go 1.17.13 2023-07-24 02:49:20 +00:00
race.bash
race.bat
run.bash
run.bat
run.rc

README.vendor

Vendoring in std and cmd
========================

The Go command maintains copies of external packages needed by the
standard library in the src/vendor and src/cmd/vendor directories.

There are two modules, std and cmd, defined in src/go.mod and
src/cmd/go.mod. When a package outside std or cmd is imported
by a package inside std or cmd, the import path is interpreted
as if it had a "vendor/" prefix. For example, within "crypto/tls",
an import of "golang.org/x/crypto/cryptobyte" resolves to
"vendor/golang.org/x/crypto/cryptobyte". When a package with the
same path is imported from a package outside std or cmd, it will
be resolved normally. Consequently, a binary may be built with two
copies of a package at different versions if the package is
imported normally and vendored by the standard library.

Vendored packages are internally renamed with a "vendor/" prefix
to preserve the invariant that all packages have distinct paths.
This is necessary to avoid compiler and linker conflicts. Adding
a "vendor/" prefix also maintains the invariant that standard
library packages begin with a dotless path element.

The module requirements of std and cmd do not influence version
selection in other modules. They are only considered when running
module commands like 'go get' and 'go mod vendor' from a directory
in GOROOT/src.

Maintaining vendor directories
==============================

Before updating vendor directories, ensure that module mode is enabled.
Make sure that GO111MODULE is not set in the environment, or that it is
set to 'on' or 'auto'.

Requirements may be added, updated, and removed with 'go get'.
The vendor directory may be updated with 'go mod vendor'.
A typical sequence might be:

    cd src
    go get golang.org/x/net@master
    go mod tidy
    go mod vendor

Use caution when passing '-u' to 'go get'. The '-u' flag updates
modules providing all transitively imported packages, not only
the module providing the target package.

Note that 'go mod vendor' only copies packages that are transitively
imported by packages in the current module. If a new package is needed,
it should be imported before running 'go mod vendor'.