go/src
Keith Randall 3a03ddf735 [release-branch.go1.17] cmd/compile: ensure constant shift amounts are in range for arm
Ensure constant shift amounts are in the range [0-31]. When shift amounts
are out of range, bad things happen. Shift amounts out of range occur
when lowering 64-bit shifts (we take an in-range shift s in [0-63] and
calculate s-32 and 32-s, both of which might be out of [0-31]).

The constant shift operations themselves still work, but their shift
amounts get copied unmolested to operations like ORshiftLL which use only
the low 5 bits. That changes an operation like <<100 which unconditionally
produces 0, to <<4, which doesn't.

Fixes #48479

Change-Id: I87363ef2b4ceaf3b2e316426064626efdfbb8ee3
Reviewed-on: https://go-review.googlesource.com/c/go/+/350969
Trust: Keith Randall <khr@golang.org>
Run-TryBot: Keith Randall <khr@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Cherry Mui <cherryyz@google.com>
(cherry picked from commit eff27e858b)
Reviewed-on: https://go-review.googlesource.com/c/go/+/351069
Reviewed-by: Austin Clements <austin@google.com>
2021-10-27 21:13:34 +00:00
..
archive [release-branch.go1.17] archive/zip: prevent preallocation check from overflowing 2021-09-01 16:41:15 +00:00
bufio
builtin
bytes
cmd [release-branch.go1.17] cmd/compile: ensure constant shift amounts are in range for arm 2021-10-27 21:13:34 +00:00
compress
container
context
crypto [release-branch.go1.17] crypto/rand, internal/syscall/unix: don't use getentropy on iOS 2021-09-01 17:08:11 +00:00
database/sql database/sql: fix deadlock test in prepare statement 2021-06-21 17:37:23 +00:00
debug debug/elf: don't apply DWARF relocations for ET_EXEC binaries 2021-06-14 22:13:47 +00:00
embed [release-branch.go1.17] cmd/compile: allow embed into any byte slice type 2021-09-01 16:49:05 +00:00
encoding
errors
expvar
flag
fmt
go [release-branch.go1.17] go/types: don't override x.mode before using it 2021-09-01 22:32:32 +00:00
hash
html
image image/gif: fix typo in the comment (io.ReadByte -> io.ByteReader) 2021-06-30 17:58:50 +00:00
index/suffixarray
internal [release-branch.go1.17] crypto/rand, internal/syscall/unix: don't use getentropy on iOS 2021-09-01 17:08:11 +00:00
io io/fs: don't use absolute path in DirEntry.Name doc 2021-08-02 17:18:57 +00:00
log
math math/big: fix typo of comment (`BytesScanner` to `ByteScanner`) 2021-06-29 16:57:13 +00:00
mime
net [release-branch.go1.17] all: update golang.org/x/net to pull in CL 346890 2021-09-01 22:54:04 +00:00
os [release-branch.go1.17] syscall: do not use handle lists on windows when NoInheritHandles is true 2021-10-25 21:16:46 +00:00
path path/filepath: deflake TestEvalSymlinksAboveRoot on darwin 2021-06-30 20:03:34 +00:00
plugin
reflect reflect: add missing copyright header 2021-07-21 20:29:18 +00:00
regexp
runtime [release-branch.go1.17] runtime: in adjustTimers back up as far as necessary 2021-09-15 23:28:10 +00:00
sort
strconv strconv: document parsing of leading +/- 2021-06-09 18:16:27 +00:00
strings
sync [release-branch.go1.17] sync/atomic: fix documentation for CompareAndSwap 2021-08-15 22:50:19 +00:00
syscall [release-branch.go1.17] syscall: do not use handle lists on windows when NoInheritHandles is true 2021-10-25 21:16:46 +00:00
testdata
testing testing: clarify T.Name returns a distinct name of the running test 2021-07-27 05:07:46 +00:00
text [release-branch.go1.17] text/template: initialize template before locking it 2021-09-23 21:18:37 +00:00
time [release-branch.go1.17] runtime: in adjustTimers back up as far as necessary 2021-09-15 23:28:10 +00:00
unicode
unsafe spec, unsafe: clarify unsafe.Slice docs 2021-07-02 19:26:52 +00:00
vendor [release-branch.go1.17] all: update golang.org/x/net to pull in CL 346890 2021-09-01 22:54:04 +00:00
Make.dist
README.vendor
all.bash
all.bat
all.rc
bootstrap.bash
buildall.bash
clean.bash
clean.bat
clean.rc
cmp.bash
go.mod [release-branch.go1.17] cmd/go: write go.mod requirements more consistently for go 1.17+ 2021-09-28 20:30:45 +00:00
go.sum [release-branch.go1.17] all: update golang.org/x/net to pull in CL 346890 2021-09-01 22:54:04 +00:00
make.bash src/make.*: make --no-clean flag a no-op that prints a warning 2021-08-11 22:07:50 +00:00
make.bat src/make.*: make --no-clean flag a no-op that prints a warning 2021-08-11 22:07:50 +00:00
make.rc src/make.*: make --no-clean flag a no-op that prints a warning 2021-08-11 22:07:50 +00:00
race.bash
race.bat
run.bash
run.bat
run.rc

README.vendor

Vendoring in std and cmd
========================

The Go command maintains copies of external packages needed by the
standard library in the src/vendor and src/cmd/vendor directories.

In GOPATH mode, imports of vendored packages are resolved to these
directories following normal vendor directory logic
(see golang.org/s/go15vendor).

In module mode, std and cmd are modules (defined in src/go.mod and
src/cmd/go.mod). When a package outside std or cmd is imported
by a package inside std or cmd, the import path is interpreted
as if it had a "vendor/" prefix. For example, within "crypto/tls",
an import of "golang.org/x/crypto/cryptobyte" resolves to
"vendor/golang.org/x/crypto/cryptobyte". When a package with the
same path is imported from a package outside std or cmd, it will
be resolved normally. Consequently, a binary may be built with two
copies of a package at different versions if the package is
imported normally and vendored by the standard library.

Vendored packages are internally renamed with a "vendor/" prefix
to preserve the invariant that all packages have distinct paths.
This is necessary to avoid compiler and linker conflicts. Adding
a "vendor/" prefix also maintains the invariant that standard
library packages begin with a dotless path element.

The module requirements of std and cmd do not influence version
selection in other modules. They are only considered when running
module commands like 'go get' and 'go mod vendor' from a directory
in GOROOT/src.

Maintaining vendor directories
==============================

Before updating vendor directories, ensure that module mode is enabled.
Make sure GO111MODULE=off is not set ('on' or 'auto' should work).

Requirements may be added, updated, and removed with 'go get'.
The vendor directory may be updated with 'go mod vendor'.
A typical sequence might be:

    cd src
    go get -d golang.org/x/net@latest
    go mod tidy
    go mod vendor

Use caution when passing '-u' to 'go get'. The '-u' flag updates
modules providing all transitively imported packages, not only
the module providing the target package.

Note that 'go mod vendor' only copies packages that are transitively
imported by packages in the current module. If a new package is needed,
it should be imported before running 'go mod vendor'.