go/misc/cgo
Bryan C. Mills 3922c006ad misc/cgo/testcshared: avoid writing to GOROOT in tests
The tests in this package invoked 'go install -i -buildmode=c-shared'
in order to generate an archive as well as multiple C header files.

Unfortunately, the behavior of the '-i' flag is inappropriately broad
for this use-case: it not only generates the library and header files
(as desired), but also attempts to install a number of (unnecessary)
archive files for transitive dependencies to
GOROOT/pkg/$GOOS_$GOARCH_testcshared_shared, which may not be writable
— for example, if GOROOT is owned by the root user but the test is
being run by a non-root user.

Instead, for now we generate the header files for transitive dependencies
separately by running 'go tool cgo -exportheader'.

In the future, we should consider how to improve the ergonomics for
generating transitive header files without coupling that to
unnecessary library installation.

Updates #28387
Updates #30316
Updates #35715

Change-Id: I622426a860828020d98f7040636f374e5c766d28
Reviewed-on: https://go-review.googlesource.com/c/go/+/208119
Run-TryBot: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
2019-11-22 15:34:14 +00:00
..
errors cmd/cgo: do not rewrite call if there are more args than parameters 2019-07-12 17:31:29 +00:00
fortran misc/cgo/fortran: avoid writing to $PWD 2019-11-20 22:37:23 +00:00
gmp all: make copyright headers consistent with one space after period 2016-05-02 13:43:18 +00:00
life misc: ensure that test overlay directories are writable 2019-11-11 17:59:46 +00:00
nocgo
stdio misc: ensure that test overlay directories are writable 2019-11-11 17:59:46 +00:00
test misc: ensure that test overlay directories are writable 2019-11-11 17:59:46 +00:00
testasan
testcarchive misc/cgo/testcarchive: avoid writing to GOROOT in tests 2019-11-22 15:32:23 +00:00
testcshared misc/cgo/testcshared: avoid writing to GOROOT in tests 2019-11-22 15:34:14 +00:00
testgodefs misc/cgo/testgodefs: convert test from bash to Go 2019-11-13 20:53:39 +00:00
testplugin misc/cgo/testplugin: avoid writing to GOROOT 2019-11-20 22:38:34 +00:00
testsanitizers runtime: save/restore callee saved registers in arm64's sigtramp 2019-06-03 19:02:11 +00:00
testshared misc: ensure that test overlay directories are writable 2019-11-11 17:59:46 +00:00
testsigfwd misc/cgo/testsigfwd: add missing return statement 2016-08-30 21:44:14 +00:00
testso misc: ensure that test overlay directories are writable 2019-11-11 17:59:46 +00:00
testsovar misc: ensure that test overlay directories are writable 2019-11-11 17:59:46 +00:00
testtls all: make copyright headers consistent with one space after period 2016-05-02 13:43:18 +00:00