mirror of https://github.com/golang/go.git
07bc1bf47f
In my testing, the gopls degraded memory mode (currently set via "memoryMode": "DegradeClosed") did not save as much memory as expected due to still type checking all packages in the workspace (even if in ParseExported mode). It is also annoying to get incomplete results from references and renaming. I think we can (and should) fix both problems: don't even consider packages that aren't 'reachable' via open files, but fully type check the reverse transitive closure of the packages you're working on. This CL does exactly that, by swapping out the concept of 'workspace packages' with 'active packages'. In testing, this decreased my memory footprint while working on std by 3-4x when compared to normal mode, and 2x when compared to the previous implementation of DegradeClosed. It still needs more testing before we move this option out of experimental. For golang/go#46902 Change-Id: I1e319d0b1607d344d27e797ce32de057d7a583f9 Reviewed-on: https://go-review.googlesource.com/c/tools/+/336410 Trust: Robert Findley <rfindley@google.com> Run-TryBot: Robert Findley <rfindley@google.com> gopls-CI: kokoro <noreply+kokoro@google.com> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org> |
||
|---|---|---|
| .. | ||
| analysisinternal | ||
| apidiff | ||
| event | ||
| fakenet | ||
| fastwalk | ||
| gocommand | ||
| gopathwalk | ||
| imports | ||
| jsonrpc2 | ||
| jsonrpc2_v2 | ||
| lsp | ||
| memoize | ||
| mod | ||
| packagesinternal | ||
| proxydir | ||
| span | ||
| stack | ||
| testenv | ||
| tool | ||
| typeparams | ||
| typesinternal | ||
| xcontext | ||