mirror
/
go
mirror of https://github.com/golang/go.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
go/internal/lsp
History
Rebecca Stambler 37a045f3b9 internal/lsp: move undeclaredname suggested fix out of analysis 
This CL is a follow-up from CL 241983. I didn't realize that the
undeclaredname analysis was also using the go/printer.Fprint trick,
which we decided was both incorrect and inefficient. This CL does
approximately the same things as CL 241983, with a few changes to make
the approach more general.

source.Analyzer now has a field to indicate if its suggested fix needs
to be computed separately, and that is used to determine which
code actions get commands. We also make helper functions to map
analyses to their commands.

I figured out a neater way to test suggested fixes in this CL, so I
reversed the move to source_test back to lsp_test (which was the right
place all along).

Change-Id: I505bf4790481d887edda8b82897e541ec73fb427
Reviewed-on: https://go-review.googlesource.com/c/tools/+/242366
Run-TryBot: Rebecca Stambler <rstambler@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Heschi Kreinick <heschi@google.com>
 		2020-07-23 23:54:27 +00:00
..
analysis internal/lsp: move undeclaredname suggested fix out of analysis 2020-07-23 23:54:27 +00:00
browser
…
cache internal/lsp: treat the module root as the workspace root, if available 2020-07-23 21:33:49 +00:00
cmd internal/lsp: move undeclaredname suggested fix out of analysis 2020-07-23 23:54:27 +00:00
debug internal/lsp/lsprpc: improvements to daemon logging 2020-07-16 19:33:22 +00:00
diff internal/testenv: check that external 'diff' tool is the GNU version 2020-05-08 20:46:49 +00:00
fake internal/lsp/regtest: add run options to support stress testing 2020-07-23 23:37:37 +00:00
fuzzy internal/lsp: fix errors found by staticcheck 2020-03-19 19:20:54 +00:00
helper internal/lsp: change to helper.go to output a formatted file 2020-01-31 20:35:38 +00:00
lsprpc internal/lsp/fake: move to a struct for configuring the sandbox 2020-07-23 23:36:26 +00:00
mod internal/lsp: show errors in indirect dependencies as diagnostics 2020-07-23 21:53:52 +00:00
protocol internal/lsp: change the way that we pass arguments to command 2020-07-21 16:30:27 +00:00
regtest internal/lsp/regtest: fix WithoutWorkspaceFolders option 2020-07-23 23:38:05 +00:00
snippet all: fix broken links to LSP specification 2019-10-02 18:32:53 +00:00
source internal/lsp: move undeclaredname suggested fix out of analysis 2020-07-23 23:54:27 +00:00
testdata internal/lsp: separate test and benchmark codelens 2020-07-22 18:17:40 +00:00
tests internal/lsp: support extract function 2020-07-20 18:55:41 +00:00
code_action.go internal/lsp: move undeclaredname suggested fix out of analysis 2020-07-23 23:54:27 +00:00
code_lens.go internal/lsp: change the way that we pass arguments to command 2020-07-21 16:30:27 +00:00
command.go internal/lsp: move undeclaredname suggested fix out of analysis 2020-07-23 23:54:27 +00:00
completion.go internal/lsp: remove VS Code-specific completion hack 2020-06-30 15:48:51 +00:00
completion_test.go internal/lsp/source: offer smart "append()" completions 2020-05-20 22:05:37 +00:00
definition.go internal/lsp: read files eagerly 2020-06-11 22:11:59 +00:00
diagnostics.go internal/lsp: treat the module root as the workspace root, if available 2020-07-23 21:33:49 +00:00
folding_range.go internal/lsp: read files eagerly 2020-06-11 22:11:59 +00:00
format.go internal/lsp: read files eagerly 2020-06-11 22:11:59 +00:00
general.go internal/lsp: treat the module root as the workspace root, if available 2020-07-23 21:33:49 +00:00
highlight.go internal/lsp: read files eagerly 2020-06-11 22:11:59 +00:00
hover.go internal/lsp: read files eagerly 2020-06-11 22:11:59 +00:00
implementation.go internal/lsp: read files eagerly 2020-06-11 22:11:59 +00:00
link.go internal/lsp: add an importShortcut configuration 2020-07-15 23:00:36 +00:00
lsp_test.go internal/lsp: move undeclaredname suggested fix out of analysis 2020-07-23 23:54:27 +00:00
progress.go internal/lsp: change the way that we pass arguments to command 2020-07-21 16:30:27 +00:00
references.go internal/lsp: read files eagerly 2020-06-11 22:11:59 +00:00
rename.go internal/lsp: read files eagerly 2020-06-11 22:11:59 +00:00
reset_golden.sh internal/lsp: fix regeneration of golden files 2019-09-25 13:16:59 +00:00
server.go internal/lsp: change the way that we pass arguments to command 2020-07-21 16:30:27 +00:00
server_gen.go x/tools/gopls: add support for $/progress functionality 2020-03-16 21:25:24 +00:00
signature_help.go internal/lsp: read files eagerly 2020-06-11 22:11:59 +00:00
symbols.go internal/lsp: read files eagerly 2020-06-11 22:11:59 +00:00
text_synchronization.go internal/lsp: don't keep track of closed overlays 2020-07-16 17:49:00 +00:00
workspace.go gopls, internal/lsp: support an extra formatting hook for gofumpt 2020-07-13 21:42:47 +00:00
workspace_symbol.go internal/lsp/source: add a new symbolStyle configuration option 2020-06-26 17:13:37 +00:00