go/src
hopehook 370cadd0e4 cmd/compile: add a test case and some comments for deadlock on syntax error
After CL 398014 fixed a compiler deadlock on syntax errors,
this CL adds a test case and more details for that.

How it was fixed:

CL 57751 introduced a channel "sem" to limit the number of
simultaneously open files.

Unfortunately, when the number of syntax processing goroutines
exceeds this limit, will easily trigger deadlock.

In the original implementation, "sem" only limited the number
of open files, not the number of concurrent goroutines, which
will cause extra goroutines to block on "sem". When the p.err
of the following iteration happens to be held by the blocking
goroutine, it will fall into a circular wait, which is a deadlock.

CL 398014 fixed the above deadlock, also see issue #52127.

First, move "sem <- struct{}{}" to the outside of the syntax
processing goroutine, so that the number of concurrent goroutines
does not exceed the number of open files, to ensure that all
goroutines in execution can eventually write to p.err.

Second, move the entire syntax processing logic into a separate
goroutine to avoid blocking on the producer side.

Change-Id: I1bb89bfee3d2703784f0c0d4ded82baab2ae867a
Reviewed-on: https://go-review.googlesource.com/c/go/+/399054
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
Auto-Submit: Matthew Dempsky <mdempsky@google.com>
Reviewed-by: Ian Lance Taylor <iant@google.com>
2022-04-12 01:18:27 +00:00
..
archive all: gofmt main repo 2022-04-11 16:34:30 +00:00
bufio all: remove trailing blank doc comment lines 2022-04-01 18:18:07 +00:00
builtin all: gofmt main repo 2022-04-11 16:34:30 +00:00
bytes all: gofmt main repo 2022-04-11 16:34:30 +00:00
cmd cmd/compile: add a test case and some comments for deadlock on syntax error 2022-04-12 01:18:27 +00:00
compress all: gofmt main repo 2022-04-11 16:34:30 +00:00
container all: gofmt main repo 2022-04-11 16:34:30 +00:00
context all: gofmt main repo 2022-04-11 16:34:30 +00:00
crypto all: gofmt main repo 2022-04-11 16:34:30 +00:00
database/sql all: gofmt main repo 2022-04-11 16:34:30 +00:00
debug all: gofmt main repo 2022-04-11 16:34:30 +00:00
embed all: gofmt main repo 2022-04-11 16:34:30 +00:00
encoding all: gofmt main repo 2022-04-11 16:34:30 +00:00
errors
expvar all: gofmt main repo 2022-04-11 16:34:30 +00:00
flag all: gofmt main repo 2022-04-11 16:34:30 +00:00
fmt all: gofmt main repo 2022-04-11 16:34:30 +00:00
go go/ast, go/printer: recognize export and extern line directives 2022-04-11 22:03:44 +00:00
hash all: gofmt main repo 2022-04-11 16:34:30 +00:00
html all: gofmt main repo 2022-04-11 16:34:30 +00:00
image all: gofmt main repo 2022-04-11 16:34:30 +00:00
index/suffixarray all: gofmt main repo 2022-04-11 16:34:30 +00:00
internal all: gofmt main repo 2022-04-11 16:34:30 +00:00
io all: remove trailing blank doc comment lines 2022-04-01 18:18:07 +00:00
log all: gofmt main repo 2022-04-11 16:34:30 +00:00
math all: gofmt main repo 2022-04-11 16:34:30 +00:00
mime all: gofmt main repo 2022-04-11 16:34:30 +00:00
net net/http/httptest: allow multiple fields be present in one Trailer field 2022-04-11 23:17:38 +00:00
os all: gofmt main repo 2022-04-11 16:34:30 +00:00
path all: gofmt main repo 2022-04-11 16:34:30 +00:00
plugin all: separate doc comment from //go: directives 2022-04-05 17:54:15 +00:00
reflect all: gofmt main repo 2022-04-11 16:34:30 +00:00
regexp all: gofmt main repo 2022-04-11 16:34:30 +00:00
runtime runtime: fix name of type parameter 2022-04-12 00:32:29 +00:00
sort sort: add Find function 2022-04-07 14:42:13 +00:00
strconv all: gofmt main repo 2022-04-11 16:34:30 +00:00
strings all: gofmt main repo 2022-04-11 16:34:30 +00:00
sync all: gofmt main repo 2022-04-11 16:34:30 +00:00
syscall all: gofmt main repo 2022-04-11 16:34:30 +00:00
testdata
testing all: gofmt main repo 2022-04-11 16:34:30 +00:00
text all: gofmt main repo 2022-04-11 16:34:30 +00:00
time all: gofmt main repo 2022-04-11 16:34:30 +00:00
unicode all: gofmt main repo 2022-04-11 16:34:30 +00:00
unsafe all: gofmt main repo 2022-04-11 16:34:30 +00:00
vendor all: update vendored x dependencies for Go 1.19 development cycle 2022-03-17 20:32:25 +00:00
Make.dist
README.vendor
all.bash
all.bat
all.rc
bootstrap.bash
buildall.bash
clean.bash
clean.bat
clean.rc
cmp.bash
go.mod all: update vendored x dependencies for Go 1.19 development cycle 2022-03-17 20:32:25 +00:00
go.sum all: update vendored x dependencies for Go 1.19 development cycle 2022-03-17 20:32:25 +00:00
make.bash cmd/dist: move more environment logic into cmd/dist from make and run scripts 2022-04-05 21:45:19 +00:00
make.bat cmd/dist: move more environment logic into cmd/dist from make and run scripts 2022-04-05 21:45:19 +00:00
make.rc cmd/dist: move more environment logic into cmd/dist from make and run scripts 2022-04-05 21:45:19 +00:00
race.bash
race.bat
run.bash cmd/dist: move more environment logic into cmd/dist from make and run scripts 2022-04-05 21:45:19 +00:00
run.bat cmd/dist: move more environment logic into cmd/dist from make and run scripts 2022-04-05 21:45:19 +00:00
run.rc cmd/dist: move more environment logic into cmd/dist from make and run scripts 2022-04-05 21:45:19 +00:00

README.vendor

Vendoring in std and cmd
========================

The Go command maintains copies of external packages needed by the
standard library in the src/vendor and src/cmd/vendor directories.

In GOPATH mode, imports of vendored packages are resolved to these
directories following normal vendor directory logic
(see golang.org/s/go15vendor).

In module mode, std and cmd are modules (defined in src/go.mod and
src/cmd/go.mod). When a package outside std or cmd is imported
by a package inside std or cmd, the import path is interpreted
as if it had a "vendor/" prefix. For example, within "crypto/tls",
an import of "golang.org/x/crypto/cryptobyte" resolves to
"vendor/golang.org/x/crypto/cryptobyte". When a package with the
same path is imported from a package outside std or cmd, it will
be resolved normally. Consequently, a binary may be built with two
copies of a package at different versions if the package is
imported normally and vendored by the standard library.

Vendored packages are internally renamed with a "vendor/" prefix
to preserve the invariant that all packages have distinct paths.
This is necessary to avoid compiler and linker conflicts. Adding
a "vendor/" prefix also maintains the invariant that standard
library packages begin with a dotless path element.

The module requirements of std and cmd do not influence version
selection in other modules. They are only considered when running
module commands like 'go get' and 'go mod vendor' from a directory
in GOROOT/src.

Maintaining vendor directories
==============================

Before updating vendor directories, ensure that module mode is enabled.
Make sure GO111MODULE=off is not set ('on' or 'auto' should work).

Requirements may be added, updated, and removed with 'go get'.
The vendor directory may be updated with 'go mod vendor'.
A typical sequence might be:

    cd src
    go get -d golang.org/x/net@latest
    go mod tidy
    go mod vendor

Use caution when passing '-u' to 'go get'. The '-u' flag updates
modules providing all transitively imported packages, not only
the module providing the target package.

Note that 'go mod vendor' only copies packages that are transitively
imported by packages in the current module. If a new package is needed,
it should be imported before running 'go mod vendor'.