Robert Findley 4ccc73cbb5 internal/lsp/tests: simplify comparison of markdown at go1.18 ... In several places throughout the x/tools codebase, the internal/lsp/diff package is used to provide clearer test output when comparing large, multi-line strings. In some places, this is implemented via the tests.Diff helper function, but in others it is not (presumably due to import cycles). Factor out this pattern into a diff.Pretty function, and add commentary. Also remove the *testing.T argument, as diffs should never fail; opt to panic instead. Also add a test. Using this function, simplify the logic to comparing our 1.18 markdown output with 1.19 golden content, by normalizing differences between the two. This is necessary as markdown content will change as a result of moving internal/lsp to gopls/internal/lsp. For golang/go#54509 Change-Id: Ie1fea1091bbbeb49e00c4efa7e02707cafa415cc Reviewed-on: https://go-review.googlesource.com/c/tools/+/426776 TryBot-Result: Gopher Robot <gobot@golang.org> Run-TryBot: Robert Findley <rfindley@google.com> gopls-CI: kokoro <noreply+kokoro@google.com> Reviewed-by: Alan Donovan <adonovan@google.com>		2022-08-31 21:08:24 +00:00
..
testdata/vulndb	internal/lsp/mod/code_lens: add "run govulncheck" codelens	2022-08-04 20:03:56 +00:00
call_hierarchy_test.go	internal/lsp/source: check for nil objects in call hierarchy	2021-10-27 16:11:50 +00:00
configuration_test.go	internal/lsp: re-send diagnostics on file events	2022-08-02 18:52:36 +00:00
debugserver_test.go	internal/lsp/debug: add a facility to track known bugs	2021-05-10 23:21:19 +00:00
definition_test.go	internal/lsp/tests: simplify comparison of markdown at go1.18	2022-08-31 21:08:24 +00:00
embed_test.go	internal/lsp/cache: parse files with ParseFull mode to check if metadata reload is required	2021-08-06 19:38:52 +00:00
failures_test.go	gopls/internal/regtest: fix TestFailingDiagnosticClearingOnEdit	2022-08-09 15:36:31 +00:00
fix_test.go	internal/lsp/tests: simplify comparison of markdown at go1.18	2022-08-31 21:08:24 +00:00
formatting_test.go	internal/lsp/tests: simplify comparison of markdown at go1.18	2022-08-31 21:08:24 +00:00
generate_test.go	internal/lsp/progress: actually close over Context in WorkDoneWriter	2022-07-12 22:14:18 +00:00
highlight_test.go	internal/lsp: move gopls/internal/regtest -> internal/lsp/regtest	2021-04-23 16:19:37 +00:00
hover_test.go	internal/lsp: render package documentation when hovering over a package import	2022-04-25 17:29:41 +00:00
import_test.go	internal/lsp/tests: simplify comparison of markdown at go1.18	2022-08-31 21:08:24 +00:00
imports_test.go	internal/lsp/regtest: simplify, consolidate, and document settings	2022-07-12 16:56:46 +00:00
link_test.go	internal/lsp/source: remove utm_source from pkgsite links	2022-08-15 16:22:50 +00:00
misc_test.go	internal/lsp/cache: invalidate metadata when parsing issues resolve	2022-05-23 18:14:40 +00:00
multiple_adhoc_test.go	internal/lsp: allow for multiple ad-hoc packages in the workspace	2021-08-12 18:45:58 +00:00
references_test.go	internal/lsp: find references to package	2022-06-21 19:39:47 +00:00
rename_test.go	internal/lsp: rename all the package names in the renamed package	2022-08-01 17:28:00 +00:00
semantictokens_test.go	internal/lsp/regtest: allow sharing memoized results across regtests	2022-07-26 21:20:42 +00:00
settings_test.go	internal/lsp/regtest: simplify, consolidate, and document settings	2022-07-12 16:56:46 +00:00
shared_test.go	gopls/internal/regtest/misc: simplify shared edit tests	2022-08-04 19:57:25 +00:00
staticcheck_test.go	internal/lsp/regtest: simplify, consolidate, and document settings	2022-07-12 16:56:46 +00:00
vendor_test.go	internal/lsp/regtest: allow sharing memoized results across regtests	2022-07-26 21:20:42 +00:00
vuln_test.go	internal/lsp: polish vulncheck progress messages	2022-08-04 20:05:03 +00:00
workspace_symbol_test.go	internal/lsp/regtest: simplify, consolidate, and document settings	2022-07-12 16:56:46 +00:00