mirror
/
go
mirror of https://github.com/golang/go.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
go/test
History
Matthew Dempsky 93453233bd cmd/compile: fix unsafe.Add with small-size offsets operands 
Like other builtin functions, unsafe.Add's len operand is allowed to
be variable sized. However, unlike other builtins, it doesn't get
lowered to a runtime function call, so we never end up coercing it to
a specific type. As a result, we could end up constructing an OpAddPtr
value but with a less-than-ptr-sized addend operand.

This CL fixes this by always coercing the second operand to uintptr
during SSA construction.

Theoretically, we could do this during walk instead, but the frontend
doesn't allow converting negative constants to uintptr.

Fixes #48536.

Change-Id: Ib0619ea79df58b256b250fec967a6d3c8afea631
Reviewed-on: https://go-review.googlesource.com/c/go/+/351592
Trust: Matthew Dempsky <mdempsky@google.com>
Run-TryBot: Matthew Dempsky <mdempsky@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Cuong Manh Le <cuong.manhle.vn@gmail.com>
 		2021-09-23 00:14:22 +00:00
..
abi cmd/compile: restore tail call for method wrappers 2021-09-17 22:59:44 +00:00
alias3.dir
…
bench test/bench/go1: fix size for RegexpMatchMedium_32 2021-07-18 21:03:43 +00:00
chan [dev.typeparams] cmd/compile/internal/types2: implement close(ch) where ch is of type parameter type 2021-07-14 23:33:46 +00:00
closure3.dir cmd/compile: don't emit inltree for closure within body of inlined func 2021-05-18 20:04:57 +00:00
closure5.dir
…
codegen cmd/compile: use BMI1 instructions for GOAMD64=v3 and higher 2021-09-22 00:15:27 +00:00
ddd2.dir
…
dwarf
…
fixedbugs cmd/compile: fix unsafe.Add with small-size offsets operands 2021-09-23 00:14:22 +00:00
import2.dir
…
import4.dir
…
interface
…
intrinsic.dir
…
ken
…
linkname.dir
…
method4.dir
…
oldescape_linkname.dir
…
retjmp.dir
…
runtime
…
stress all: update references to symbols moved from io/ioutil to io 2021-04-05 17:51:15 +00:00
syntax test/syntax: remove interface.go 2021-04-06 18:55:39 +00:00
typeparam cmd/compile, go/types: allow `any` anywhere (as a type) 2021-09-22 19:19:49 +00:00
uintptrescapes.dir
…
64bit.go
…
235.go
…
README.md
…
alg.go
…
alias.go
…
alias1.go
…
alias2.go
…
alias3.go
…
align.go
…
append.go
…
append1.go
…
args.go
…
armimm.go
…
assign.go
…
assign1.go
…
atomicload.go
…
bigalg.go
…
bigmap.go
…
blank.go
…
blank1.go
…
bom.go
…
bombad.go
…
bounds.go
…
cannotassign.go
…
chancap.go
…
chanlinear.go
…
char_lit.go
…
char_lit1.go
…
checkbce.go
…
clearfat.go
…
closedchan.go
…
closure.go
…
closure1.go
…
closure2.go
…
closure3.go
…
closure4.go
…
closure5.go
…
closure6.go
…
closure7.go
…
cmp.go
…
cmp6.go
…
cmplx.go
…
cmplxdivide.c
…
cmplxdivide.go
…
cmplxdivide1.go
…
complit.go
…
complit1.go test: fix error check messages for 2 types2 tests 2021-06-02 05:14:45 +00:00
compos.go
…
const.go
…
const1.go
…
const2.go
…
const3.go
…
const4.go
…
const5.go
…
const6.go
…
const7.go
…
convT2X.go
…
convert.go
…
convert1.go
…
convert2.go cmd/compile: allow conversion from slice to array ptr 2021-04-21 00:53:48 +00:00
convert3.go
…
convert4.go cmd/compile: allow conversion from slice to array ptr 2021-04-21 00:53:48 +00:00
convlit.go
…
convlit1.go
…
copy.go
…
copy1.go
…
crlf.go
…
ddd.go
…
ddd1.go test: fix error check messages for 2 types2 tests 2021-06-02 05:14:45 +00:00
ddd2.go
…
decl.go
…
declbad.go cmd/compile: rewrite a, b = f() to use temporaries when type not identical 2021-06-14 07:12:37 +00:00
defer.go
…
defererrcheck.go
…
deferfin.go
…
defernil.go
…
deferprint.go
…
deferprint.out
…
devirt.go [dev.typeparams] cmd/compile: simplify interface conversions 2021-08-09 16:10:20 +00:00
directive.go
…
divide.go
…
divmod.go
…
embedfunc.go
…
embedvers.go
…
empty.go
…
env.go
…
eof.go
…
eof1.go
…
escape.go
…
escape2.go [dev.typeparams] cmd/compile: move call logic from order.go to escape 2021-06-23 16:48:12 +00:00
escape2n.go [dev.typeparams] cmd/compile: move call logic from order.go to escape 2021-06-23 16:48:12 +00:00
escape3.go
…
escape4.go
…
escape5.go [dev.typeparams] test: rename blank functions 2021-07-28 21:41:07 +00:00
escape_array.go [dev.typeparams] cmd/compile: simplify ~r/~b naming 2021-05-26 23:50:32 +00:00
escape_calls.go [dev.typeparams] cmd/compile: simplify ~r/~b naming 2021-05-26 23:50:32 +00:00
escape_closure.go [dev.typeparams] cmd/compile: simplify ~r/~b naming 2021-05-26 23:50:32 +00:00
escape_field.go
…
escape_goto.go [dev.typeparams] test: rename blank functions 2021-07-28 21:41:07 +00:00
escape_hash_maphash.go
…
escape_iface.go
…
escape_indir.go
…
escape_level.go
…
escape_map.go
…
escape_param.go [dev.typeparams] cmd/compile: simplify ~r/~b naming 2021-05-26 23:50:32 +00:00
escape_runtime_atomic.go [dev.typeparams] cmd/compile: simplify ~r/~b naming 2021-05-26 23:50:32 +00:00
escape_selfassign.go
…
escape_slice.go [dev.typeparams] cmd/compile: simplify ~r/~b naming 2021-05-26 23:50:32 +00:00
escape_struct_param1.go
…
escape_struct_param2.go
…
escape_struct_return.go [dev.typeparams] cmd/compile: simplify ~r/~b naming 2021-05-26 23:50:32 +00:00
escape_sync_atomic.go
…
escape_unsafe.go [dev.typeparams] cmd/compile: simplify ~r/~b naming 2021-05-26 23:50:32 +00:00
fibo.go
…
finprofiled.go
…
float_lit.go
…
float_lit2.go
…
float_lit3.go
…
floatcmp.go
…
for.go
…
func.go
…
func1.go
…
func2.go
…
func3.go
…
func4.go
…
func5.go
…
func6.go
…
func7.go
…
func8.go
…
funcdup.go
…
funcdup2.go
…
fuse.go test: do not run fuse test in noopt mode 2021-04-28 15:55:10 +00:00
gc.go
…
gc1.go
…
gc2.go
…
gcgort.go
…
gcstring.go
…
goprint.go
…
goprint.out
…
goto.go
…
heapsampling.go
…
helloworld.go
…
helloworld.out
…
if.go
…
import.go
…
import1.go
…
import2.go
…
import4.go
…
import5.go
…
import6.go
…
index.go
…
index0.go
…
index1.go
…
index2.go
…
indirect.go
…
indirect1.go
…
init.go
…
init1.go
…
initcomma.go
…
initempty.go
…
initexp.go
…
initialize.go
…
initializerr.go
…
initloop.go
…
inline.go [dev.typeparams] test: rename blank functions 2021-07-28 21:41:07 +00:00
inline_big.go [dev.typeparams] cmd/compile/internal/inline: refactor mkinlcall 2021-05-27 23:40:56 +00:00
inline_caller.go
…
inline_callers.go
…
inline_literal.go
…
inline_math_bits_rotate.go
…
inline_sync.go
…
inline_variadic.go [dev.typeparams] cmd/compile: simplify inlining variadic calls 2021-05-26 23:50:45 +00:00
int_lit.go
…
intcvt.go
…
intrinsic.go
…
intrinsic_atomic.go
…
iota.go
…
label.go
…
label1.go
…
linkmain.go
…
linkmain_run.go
…
linkname.go
…
linkname2.go
…
linkobj.go
…
linkx.go
…
linkx_run.go
…
literal.go
…
literal2.go
…
live.go [dev.typeparams] cmd/compile: simplify interface conversions 2021-08-09 16:10:20 +00:00
live1.go
…
live2.go
…
live_regabi.go test: enable regabi test on arm64 2021-08-20 19:58:13 +00:00
live_syscall.go
…
locklinear.go
…
loopbce.go
…
mainsig.go
…
makechan.go cmd/compile/internal/types2: add unsafe.Add and unsafe.Slice 2021-04-23 00:41:01 +00:00
makemap.go cmd/compile/internal/types2: add unsafe.Add and unsafe.Slice 2021-04-23 00:41:01 +00:00
makenew.go
…
makeslice.go
…
mallocfin.go
…
map.go
…
map1.go
…
mapclear.go
…
maplinear.go
…
mergemul.go
…
method.go
…
method1.go
…
method2.go
…
method3.go
…
method4.go
…
method5.go
…
method6.go
…
method7.go
…
named.go
…
named1.go
…
nil.go
…
nilcheck.go
…
nilptr.go
…
nilptr2.go
…
nilptr3.go
…
nilptr4.go
…
nilptr5.go
…
nilptr5_aix.go
…
nilptr5_wasm.go
…
nilptr_aix.go
…
nosplit.go
…
notinheap.go
…
notinheap2.go
…
notinheap3.go
…
nowritebarrier.go
…
nul1.go
…
opt_branchlikely.go
…
parentype.go
…
peano.go
…
phiopt.go cmd/compile/internal/ssa: strengthen phiopt pass 2021-03-29 05:50:11 +00:00
print.go
…
print.out
…
printbig.go
…
printbig.out
…
prove.go
…
range.go
…
recover.go
…
recover1.go
…
recover2.go
…
recover3.go
…
recover4.go
…
recover5.go
…
reflectmethod1.go
…
reflectmethod2.go
…
reflectmethod3.go
…
reflectmethod4.go
…
reflectmethod5.go
…
reflectmethod6.go
…
reflectmethod7.go
…
reflectmethod8.go [dev.typeparams] cmd/compile: fix missing condition in usemethod 2021-07-22 17:48:41 +00:00
rename.go
…
rename1.go
…
reorder.go
…
reorder2.go
…
retjmp.go
…
return.go
…
rotate.go
…
rotate0.go
…
rotate1.go
…
rotate2.go
…
rotate3.go
…
run.go cmd/compile: fixing writebarrier.go for -G=3 2021-09-16 21:10:17 +00:00
rune.go
…
runtime.go
…
shift1.go
…
shift2.go
…
sieve.go
…
sigchld.go
…
sigchld.out
…
simassign.go
…
sinit.go
…
sinit_run.go
…
sizeof.go
…
slice3.go
…
slice3err.go
…
slicecap.go
…
sliceopt.go
…
solitaire.go
…
stack.go
…
stackobj.go
…
stackobj2.go
…
stackobj3.go
…
strcopy.go
…
strength.go
…
string_lit.go
…
stringrange.go
…
struct0.go
…
switch.go
…
switch2.go
…
switch3.go
…
switch4.go
…
switch5.go
…
switch6.go
…
switch7.go
…
tinyfin.go
…
torture.go
…
turing.go
…
typecheck.go
…
typecheckloop.go
…
typeswitch.go
…
typeswitch1.go
…
typeswitch2.go
…
typeswitch2b.go
…
typeswitch3.go
…
uintptrescapes.go
…
uintptrescapes2.go [dev.typeparams] cmd/compile: skip escape analysis diagnostics for wrappers 2021-06-24 18:24:24 +00:00
uintptrescapes3.go
…
undef.go
…
unsafebuiltins.go cmd/compile,runtime: change unsafe.Slice((*T)(nil), 0) to return []T(nil) 2021-06-28 23:31:13 +00:00
used.go
…
utf.go
…
varerr.go
…
varinit.go
…
winbatch.go
…
writebarrier.go cmd/compile: don't emit write barriers for offsets of global addresses 2021-08-23 19:46:36 +00:00
zerodivide.go
…

README.md

The test directory contains tests of the Go tool chain and runtime. It includes black box tests, regression tests, and error output tests. They are run as part of all.bash.

To run just these tests, execute:

../bin/go run run.go

To run just tests from specified files in this directory, execute:

../bin/go run run.go -- file1.go file2.go ...

Standard library tests should be written as regular Go tests in the appropriate package.

The tool chain and runtime also have regular Go tests in their packages. The main reasons to add a new test to this directory are:

  • it is most naturally expressed using the test runner; or
  • it is also applicable to gccgo and other Go tool chains.