go/internal/lsp/template
Alan Donovan 93852cb65b internal/lsp: fix source.CompareDiagnostic asymmetry
In passing I noticed that this three-way comparison
is not (anti)symmetric. Such comparisons should consist
of a list of pairs of tests of this form:

  if x.key1 < y.key1 { return -1 }
  if x.key1 > y.key1 { return +1 }
  ...key2, etc...
  return 0

Also in passing:
- simplify panic-proof debug string function.
- augment doc comment of (*Server).beginFileRequest

Change-Id: Idcd0844ea4e96fc2dee5bbc270f5a200b5c27aa0
Reviewed-on: https://go-review.googlesource.com/c/tools/+/405480
Reviewed-by: Robert Findley <rfindley@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Robert Findley <rfindley@google.com>
2022-05-11 17:43:03 +00:00
..
completion.go internal/lsp/template: remove the skipTemplate guard 2022-01-13 20:55:59 +00:00
completion_test.go templates: fix panic, and stop complaining about empty files 2022-01-05 19:26:31 +00:00
highlight.go internal/lsp/template: remove the skipTemplate guard 2022-01-13 20:55:59 +00:00
implementations.go all: fix spelling 2022-04-04 19:50:34 +00:00
parse.go internal/lsp: fix source.CompareDiagnostic asymmetry 2022-05-11 17:43:03 +00:00
parse_test.go templates: fix panic, and stop complaining about empty files 2022-01-05 19:26:31 +00:00
symbols.go tools: fix some typos 2022-03-24 22:24:35 +00:00