go/go
smasher164 c1934b75d0 go/analysis: improve error message for string(int) warning
To an experienced Go user, the previous error message doesn't describe
the error--it merely states a fact. The new error message asks if the
user meant fmt.Sprint(x). If they used the conversion correctly, the
suggested fix to replace string(int) with string(rune(int)) is
understandable and valid. On the other hand, if they used it to print
a digit representation, asking that in the error message further
emphasizes the mistake.

Updates golang/go#39151.

Change-Id: Iab9cdcaf53e9ca134285246fad0546d6f24c3983
Reviewed-on: https://go-review.googlesource.com/c/tools/+/235797
Run-TryBot: Akhil Indurti <aindurti@gmail.com>
Reviewed-by: Bryan C. Mills <bcmills@google.com>
Reviewed-by: Jay Conrod <jayconrod@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
2020-06-16 13:34:36 +00:00
..
analysis go/analysis: improve error message for string(int) warning 2020-06-16 13:34:36 +00:00
ast go/ast/inspector: impose maximum capacity 2020-04-10 18:16:43 +00:00
buildutil all: fix more typos 2019-09-11 15:13:14 +00:00
callgraph all: add a space before +build in build tag comments 2019-09-08 12:23:18 +00:00
cfg all: fix some staticcheck errors 2020-01-29 04:53:41 +00:00
expect go/packages/packagestest: do not overwrite existing go.mod file 2020-02-06 15:23:23 +00:00
gccgoexportdata go/gccgoexportdata: correctly handle archive files containing string tables 2016-11-09 21:28:38 +00:00
gcexportdata Revert "go/internal/gcimporter: remove support for binary export data" 2020-05-26 20:26:39 +00:00
internal all: replace build tags in tests with testenv helper 2020-05-27 18:32:53 +00:00
loader go/loader: remove check on ioutil.TestTempFile in TestStdlib 2020-04-13 16:19:37 +00:00
packages go/packages: move TypecheckCgo to packagesinternal 2020-06-10 22:20:39 +00:00
pointer all: fix some staticcheck errors 2020-01-29 04:53:41 +00:00
ssa go/ssa/interp: avoid vet warning about string(int) conversion 2020-05-13 01:50:45 +00:00
types go/types/objectpath: cache result of call to scope.Names 2020-05-05 02:31:15 +00:00
vcs go/vcs: ignore "mod" VCS type 2019-05-06 14:53:03 +00:00