Rebecca Stambler ed30b9180d internal/lsp: don't show list errors unless necessary ... The go/packages workaround to hide errors for overlay packages doesn't seem to work well. It's easier to just hide list errors in gopls diagnostics unless the package genuinely failed to type-check. Check if the package has missing dependencies as an approximation of if it is well-typed. This required some additional special casing for the import cycle error detection, which now causes them to have duplicate diagnostics. It's a rare enough case that this doesn't concern me, but we should clean this up at some point. Fixes golang/go#36754. Change-Id: If12c92fb9a0e0b69b711ae9a509ecb1b2a32255c Reviewed-on: https://go-review.googlesource.com/c/tools/+/216310 Run-TryBot: Rebecca Stambler <rstambler@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Heschi Kreinick <heschi@google.com>		2020-01-27 19:59:09 +00:00
..
comment.go	internal/lsp: convert comments to markdown before sending to client	2019-10-04 18:35:38 +00:00
comment_test.go	internal/lsp: convert comments to markdown before sending to client	2019-10-04 18:35:38 +00:00
completion.go	internal/lsp: fix active parameter for incomplete parentheses	2020-01-27 19:24:44 +00:00
completion_builtin.go	internal/lsp: fix active parameter for incomplete parentheses	2020-01-27 19:24:44 +00:00
completion_format.go	internal/lsp: return context cancellation from LookupBuiltin	2020-01-27 18:55:29 +00:00
completion_keywords.go	internal/lsp: sort by label after score	2019-12-30 21:11:21 +00:00
completion_labels.go	internal/lsp: sort by label after score	2019-12-30 21:11:21 +00:00
completion_literal.go	internal/lsp/source: rename "typeInference" to "candidateInference"	2020-01-21 20:43:48 +00:00
completion_snippet.go	internal/lsp: merge completion options into source.Options	2020-01-13 20:09:44 +00:00
deep_completion.go	internal/lsp: merge completion options into source.Options	2020-01-13 20:09:44 +00:00
diagnostics.go	internal/lsp: don't show list errors unless necessary	2020-01-27 19:59:09 +00:00
errors.go	internal/lsp: remove the checkErrors command in internal/lsp/source	2020-01-24 21:19:55 +00:00
folding_range.go	internal/lsp: eliminate source.File type and move GetFile to snapshot	2019-12-19 20:51:25 +00:00
format.go	internal/lsp/source: trim file very carefully	2020-01-17 20:34:13 +00:00
format_test.go	internal/lsp/source: trim file very carefully	2020-01-17 20:34:13 +00:00
highlight.go	internal/lsp: add highlighting for import statement	2020-01-17 17:07:20 +00:00
hover.go	internal/lsp: show comments for grouped variable declarations	2019-12-18 20:39:36 +00:00
identifier.go	internal/lsp: refactor find-references and rename	2020-01-16 06:24:15 +00:00
implementation.go	internal/lsp: refactor find-references and rename	2020-01-16 06:24:15 +00:00
options.go	internal/lsp/source: add more go/analysis/passes analyzers to LSP's suite	2020-01-27 19:05:40 +00:00
references.go	internal/lsp/source: return obj decl first in find-references	2020-01-16 16:57:51 +00:00
rename.go	internal/lsp: permit renaming symbols declared in other packages	2020-01-27 18:56:10 +00:00
rename_check.go	internal/lsp: improve literal func completion candidates	2019-11-07 21:18:00 +00:00
signature_help.go	internal/lsp: fix active parameter for incomplete parentheses	2020-01-27 19:24:44 +00:00
source_test.go	internal/lsp: fix active parameter for incomplete parentheses	2020-01-27 19:24:44 +00:00
symbols.go	internal/lsp/source: always look up mapper when building ranges	2020-01-16 01:10:02 +00:00
util.go	internal/lsp: don't show list errors unless necessary	2020-01-27 19:59:09 +00:00
view.go	internal/lsp: push more build-specific logic into the view	2020-01-24 21:10:25 +00:00