Rebecca Stambler ed30b9180d internal/lsp: don't show list errors unless necessary ... The go/packages workaround to hide errors for overlay packages doesn't seem to work well. It's easier to just hide list errors in gopls diagnostics unless the package genuinely failed to type-check. Check if the package has missing dependencies as an approximation of if it is well-typed. This required some additional special casing for the import cycle error detection, which now causes them to have duplicate diagnostics. It's a rare enough case that this doesn't concern me, but we should clean this up at some point. Fixes golang/go#36754. Change-Id: If12c92fb9a0e0b69b711ae9a509ecb1b2a32255c Reviewed-on: https://go-review.googlesource.com/c/tools/+/216310 Run-TryBot: Rebecca Stambler <rstambler@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Heschi Kreinick <heschi@google.com>		2020-01-27 19:59:09 +00:00
..
analysis.go	internal/lsp: finish renaming CheckPackageHandle to PackageHandle	2020-01-14 23:56:10 +00:00
cache.go	internal/lsp: remove the Context argument from NewSession	2020-01-21 23:07:03 +00:00
check.go	internal/lsp/cache: fix GOPATH vendoring	2020-01-24 00:03:48 +00:00
debug.go	internal/lsp: don't clear file contents on save	2019-12-19 23:08:27 +00:00
error_test.go	internal/lsp: refactor error handling code in type-checking	2019-10-21 18:57:46 +00:00
errors.go	internal/lsp: don't show list errors unless necessary	2020-01-27 19:59:09 +00:00
external.go	internal/lsp: check that a file handle is unmodified before read	2020-01-23 20:52:07 +00:00
load.go	internal/lsp: push more build-specific logic into the view	2020-01-24 21:10:25 +00:00
mod_tidy.go	internal/lsp/cache: move mod-related functions and file	2020-01-24 14:45:41 +00:00
overlay.go	internal/lsp: support multiple URIs in (*view).invalidateContent	2020-01-23 20:19:14 +00:00
parse.go	internal/lsp: don't invalidate workspace when a mod file is opened	2020-01-10 21:20:43 +00:00
pkg.go	internal/lsp: push more build-specific logic into the view	2020-01-24 21:10:25 +00:00
session.go	internal/lsp: push more build-specific logic into the view	2020-01-24 21:10:25 +00:00
snapshot.go	internal/lsp: handle metadata reloads for ad-hoc packages	2020-01-27 19:36:31 +00:00
view.go	internal/lsp: return context cancellation from LookupBuiltin	2020-01-27 18:55:29 +00:00