go/src/cmd/internal
Bryan C. Mills 1b86bdbdc3 cmd/test2json: do not emit a final Action if the result is not known
If we are parsing a test output, and the test does not end in the
usual PASS or FAIL line (say, because it panicked), then we need the
exit status of the test binary in order to determine whether the test
passed or failed. If we don't have that status available, we shouldn't
guess arbitrarily — instead, we should omit the final "pass" or "fail"
action entirely.

(In practice, we nearly always DO have the final status, such as when
running 'go test' or 'go tool test2json some.exe'.)

Fixes #40132

Change-Id: Iae482577361a6033395fe4a05d746b980e18c3de
Reviewed-on: https://go-review.googlesource.com/c/go/+/248624
Run-TryBot: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Jay Conrod <jayconrod@google.com>
2020-08-17 19:43:21 +00:00
..
archive [dev.link] cmd/pack: use cmd/internal/archive package 2020-08-11 23:11:29 +00:00
bio [dev.link] cmd/internal/objfile: read Go object file using goobj2 package 2020-08-11 17:15:15 +00:00
browser
buildid all: base64-encode binaries that will cause Apple notarization to fail 2019-11-21 14:55:12 +00:00
diff cmd/fix, cmd/go, cmd/gofmt: refactor common code into new internal diff package 2019-10-28 23:59:10 +00:00
dwarf [dev.link] cmd: delete old object support 2020-05-04 17:00:27 +00:00
edit
gcprog
goobj [dev.link] cmd: remove "2", another round 2020-08-11 18:32:23 +00:00
moddeps cmd/internal/moddeps: don't skip directories if there are unusual files 2020-06-08 15:44:05 +00:00
obj Revert "cmd/internal/obj: fix inline marker issue on s390x" 2020-08-17 14:44:28 +00:00
objabi [dev.link] move FuncID creation into the compiler/assembler 2020-08-03 17:56:50 +00:00
objfile [dev.link] cmd/pack: use cmd/internal/archive package 2020-08-11 23:11:29 +00:00
src [dev.link] use per package filenames to build pclntab 2020-08-10 16:55:06 +00:00
sys all: remove scattered remnants of darwin/386 2020-04-08 18:37:38 +00:00
test2json cmd/test2json: do not emit a final Action if the result is not known 2020-08-17 19:43:21 +00:00
traceviewer cmd/trace: move viewer data structs into cmd/internal/traceviewer 2020-08-12 18:34:48 +00:00