mirror of https://github.com/golang/go.git
e8ec68edfa
For most tests, the test's deadline itself is more appropriate than an arbitrary timeout layered atop of it (especially once #48157 is implemented), and testenv.Command already adds cleaner timeout behavior when a command would run too close to the test's deadline. That makes RunWithTimeout something of an attractive nuisance. For now, migrate the two existing uses of it to testenv.CommandContext, with a shorter timeout implemented using context.WithTimeout. As a followup, we may want to drop the extra timeouts from these invocations entirely. Updates #50436. Updates #37405. Change-Id: I16840fd36c0137b6da87ec54012b3e44661f0d08 Reviewed-on: https://go-review.googlesource.com/c/go/+/445597 Reviewed-by: Ian Lance Taylor <iant@google.com> Run-TryBot: Bryan Mills <bcmills@google.com> Auto-Submit: Bryan Mills <bcmills@google.com> Reviewed-by: Austin Clements <austin@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> |
||
|---|---|---|
| .. | ||
| abi | ||
| buildcfg | ||
| buildinternal | ||
| bytealg | ||
| cfg | ||
| coverage | ||
| cpu | ||
| dag | ||
| diff | ||
| fmtsort | ||
| fuzz | ||
| goarch | ||
| godebug | ||
| goexperiment | ||
| goos | ||
| goroot | ||
| goversion | ||
| intern | ||
| itoa | ||
| lazyregexp | ||
| lazytemplate | ||
| nettrace | ||
| obscuretestdata | ||
| oserror | ||
| pkgbits | ||
| platform | ||
| poll | ||
| profile | ||
| race | ||
| reflectlite | ||
| saferio | ||
| singleflight | ||
| syscall | ||
| sysinfo | ||
| testenv | ||
| testlog | ||
| trace | ||
| txtar | ||
| types | ||
| unsafeheader | ||
| xcoff | ||