mirror
/
go
mirror of https://github.com/golang/go.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
go/internal/lsp/cmd
History
Heschi Kreinick 144d5ced6b internal/lsp: run type error analyzers as part of diagnostics 
Type error analyzers can be viewed as enhancing type errors, rather
than analyzers in their own right. Create a source.DiagnosePackage
function that combines the list/parse/typecheck diagnostics with type
error analyzers. This allows us to remove some special cases from the
analysis path, and is a first step in removing all the special
handling for analysis quick fixes.

Along the way:
Pass pointers to source.Analyzer after I spent half an hour chasing a
loop capture bug. Spend a further 2-3 hours chasing slowdown in the
command tests as a result.

Move Unnecessary tag generation into diagnostic creation rather than
as a mutating post-processing step that required cloning diagnostics.

Change-Id: Id246667a9dcf484dc79516f92d5524261c435794
Reviewed-on: https://go-review.googlesource.com/c/tools/+/297879
Trust: Heschi Kreinick <heschi@google.com>
Trust: Rebecca Stambler <rstambler@golang.org>
Run-TryBot: Heschi Kreinick <heschi@google.com>
gopls-CI: kokoro <noreply+kokoro@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Rebecca Stambler <rstambler@golang.org>
 		2021-03-03 21:51:40 +00:00
..
test all: replace all usages of os/exec with golang.org/x/sys/execabs 2021-01-19 22:25:03 +00:00
call_hierarchy.go internal/lsp/cmd: improve help output of gopls subcommands 2021-01-25 18:56:18 +00:00
capabilities_test.go internal/lsp: update to latest version of LSP protocol 2021-02-02 11:32:59 +00:00
check.go internal/lsp/cmd: improve help output of gopls subcommands 2021-01-25 18:56:18 +00:00
cmd.go internal/lsp: run type error analyzers as part of diagnostics 2021-03-03 21:51:40 +00:00
cmd_test.go internal/lsp/cmd: delete TestDefinitionHelpExample test 2020-11-03 23:54:15 +00:00
definition.go internal/lsp/cmd: fix the command line query for definition 2020-04-27 20:15:23 +00:00
export_test.go
…
folding_range.go internal/span,lsp: disambiguate URIs, DocumentURIs, and paths 2020-02-14 22:51:03 +00:00
format.go internal/lsp: address staticcheck warnings 2019-10-04 02:16:23 +00:00
highlight.go internal/lsp/cmd: improve help output of gopls subcommands 2021-01-25 18:56:18 +00:00
implementation.go internal/lsp/cmd: improve help output of gopls subcommands 2021-01-25 18:56:18 +00:00
imports.go internal/lsp: check for file URIs on LSP requests 2020-02-14 22:51:26 +00:00
info.go internal/lsp/cmd: add licenses command 2021-01-08 19:50:35 +00:00
inspect.go internal/lsp/cmd: use JSON output for the inspect subcommand 2020-05-11 18:25:40 +00:00
links.go internal/span,lsp: disambiguate URIs, DocumentURIs, and paths 2020-02-14 22:51:03 +00:00
prepare_rename.go internal/lsp/cmd: improve help output of gopls subcommands 2021-01-25 18:56:18 +00:00
references.go internal/lsp: check for file URIs on LSP requests 2020-02-14 22:51:26 +00:00
rename.go internal/lsp/cmd: include new name in rename help message 2020-12-28 17:52:27 +00:00
semantictokens.go internal/lsp: update to latest version of LSP protocol 2021-02-02 11:32:59 +00:00
serve.go internal/lsp: fix builds and tests for go1.12+ 2020-08-27 14:30:46 +00:00
serve_test.go internal/lsp/lsprpc: automatically resolve and start the remote gopls 2020-02-24 22:51:55 +00:00
signature.go internal/lsp/cmd: improve help output of gopls subcommands 2021-01-25 18:56:18 +00:00
suggested_fix.go internal/lsp: move undeclaredname suggested fix out of analysis 2020-07-23 23:54:27 +00:00
symbols.go internal/lsp/cmd: fix not displaying symbols result 2020-05-11 23:26:04 +00:00
workspace.go internal/lsp: switch to the new command API 2021-02-09 22:09:28 +00:00
workspace_symbol.go internal/lsp: add config option for SymbolMatch 2020-05-11 19:58:58 +00:00