1d3daebc5f
If we don't have exact unification, we must consider interface unification whether one of the types is a defined (named) interface or not. Otherwise, if one of them is named, and the other one isn't, the code selects interface-vs-non-interface unification and possibly uses the wrong method set as the "required" method set, leading to (incorrect) unification failure as was the case in #60564. We can also not simply rely on getting this right in the subsequent switch, through the handling of *Named types. This CL fixes this simple logic error. If there's inexact unification, now all (non-type parameter) interface cases are handled in one place, before the switch. After handling interfaces, we are guaranteed that we have either no interfaces, or we have exact unification where both types must be of the same structure. As a consequence, we don't need special handling for named interfaces in the *Named case of the switch anymore. Also, move the (unbound) type parameter swap from before interface handling to after interface handling, just before the switch which is the code that relies on a type parameter being in x, if any. Fixes #60564. Change-Id: Ibf7328bece25808b8dbdb714867048b93689f219 Reviewed-on: https://go-review.googlesource.com/c/go/+/500195 Reviewed-by: Robert Griesemer <gri@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> Run-TryBot: Robert Griesemer <gri@google.com> Auto-Submit: Robert Griesemer <gri@google.com> Reviewed-by: Robert Findley <rfindley@google.com> |
||
|---|---|---|
| .github | ||
| api | ||
| doc | ||
| lib/time | ||
| misc | ||
| src | ||
| test | ||
| .gitattributes | ||
| .gitignore | ||
| CONTRIBUTING.md | ||
| LICENSE | ||
| PATENTS | ||
| README.md | ||
| SECURITY.md | ||
| codereview.cfg | ||
| go.env | ||
README.md
The Go Programming Language
Go is an open source programming language that makes it easy to build simple, reliable, and efficient software.
Gopher image by Renee French, licensed under Creative Commons 4.0 Attributions license.
Our canonical Git repository is located at https://go.googlesource.com/go. There is a mirror of the repository at https://github.com/golang/go.
Unless otherwise noted, the Go source files are distributed under the BSD-style license found in the LICENSE file.
Download and Install
Binary Distributions
Official binary distributions are available at https://go.dev/dl/.
After downloading a binary release, visit https://go.dev/doc/install for installation instructions.
Install From Source
If a binary distribution is not available for your combination of operating system and architecture, visit https://go.dev/doc/install/source for source installation instructions.
Contributing
Go is the work of thousands of contributors. We appreciate your help!
To contribute, please read the contribution guidelines at https://go.dev/doc/contribute.
Note that the Go project uses the issue tracker for bug reports and proposals only. See https://go.dev/wiki/Questions for a list of places to ask questions about the Go language.