1a193b43a2
Before this change, when go tool wass used to start a tool defined in a go.mod tool directive, it used the environment the go command was running in. The issue with doing that is that the go command sets various environment variables from the computed environment when invoking a subcommand. That is used to standardise the environment for the various tools invoked by the go command, but it is not the expectatation of tools invoked by the go command, especially since those environment variables may change the behavior of the tool run. Instead use the same environment we use in go run to start the executable: the original environment (with minor modifications) saved before we start explicitly setting the envornment, with GOROOT/bin added to the path so that sub commands that run the go tool use the proper go tool binary. Fixes #70544 Change-Id: Ifbf0040a2543113638eec7232323eb9de1d61529 Reviewed-on: https://go-review.googlesource.com/c/go/+/631836 Reviewed-by: Conrad Irwin <conrad.irwin@gmail.com> Reviewed-by: Sean Liao <sean@liao.dev> Reviewed-by: Sam Thanawalla <samthanawalla@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> |
||
|---|---|---|
| .github | ||
| api | ||
| doc | ||
| lib | ||
| misc | ||
| src | ||
| test | ||
| .gitattributes | ||
| .gitignore | ||
| CONTRIBUTING.md | ||
| LICENSE | ||
| PATENTS | ||
| README.md | ||
| SECURITY.md | ||
| codereview.cfg | ||
| go.env | ||
README.md
The Go Programming Language
Go is an open source programming language that makes it easy to build simple, reliable, and efficient software.
Gopher image by Renee French, licensed under Creative Commons 4.0 Attribution license.
Our canonical Git repository is located at https://go.googlesource.com/go. There is a mirror of the repository at https://github.com/golang/go.
Unless otherwise noted, the Go source files are distributed under the BSD-style license found in the LICENSE file.
Download and Install
Binary Distributions
Official binary distributions are available at https://go.dev/dl/.
After downloading a binary release, visit https://go.dev/doc/install for installation instructions.
Install From Source
If a binary distribution is not available for your combination of operating system and architecture, visit https://go.dev/doc/install/source for source installation instructions.
Contributing
Go is the work of thousands of contributors. We appreciate your help!
To contribute, please read the contribution guidelines at https://go.dev/doc/contribute.
Note that the Go project uses the issue tracker for bug reports and proposals only. See https://go.dev/wiki/Questions for a list of places to ask questions about the Go language.