go/src
Matthew Dempsky 34416d7f6f cmd/compile: fix escape analysis of string min/max
When I was plumbing min/max support through the compiler, I was
thinking mostly about numeric argument types. As a result, I forgot
that escape analysis would need to be aware that min/max can operate
on string values, which contain pointers.

Fixes #64565.

Change-Id: I36127ce5a2da942401910fa0f9de922726c9f94d
Reviewed-on: https://go-review.googlesource.com/c/go/+/547715
Reviewed-by: Keith Randall <khr@google.com>
Reviewed-by: Mauri de Souza Meneguzzo <mauri870@gmail.com>
Auto-Submit: Matthew Dempsky <mdempsky@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
2023-12-05 22:06:07 +00:00
..
archive archive: add available godoc link 2023-10-13 18:36:46 +00:00
arena
bufio bufio: allow terminating Scanner early cleanly without a final token or an error 2023-10-23 09:06:30 +00:00
builtin
bytes bytes: add a boundary test for Count of 1 byte 2023-11-30 20:05:58 +00:00
cmd cmd/compile: fix escape analysis of string min/max 2023-12-05 22:06:07 +00:00
cmp
compress compress: some minor corrections or adjustments for godoc link 2023-10-13 23:20:03 +00:00
container
context
crypto cmd/asm: fix the KMCTR instruction encoding and argument passing 2023-11-22 03:55:32 +00:00
database/sql all: fix field names 2023-11-27 15:48:25 +00:00
debug debug/elf: return error in DynValue for invalid dynamic section size 2023-11-30 13:03:03 +00:00
embed embed: fix variable name in example 2023-11-17 16:35:13 +00:00
encoding encoding/json: use reflect.Value.IsZero 2023-10-18 20:00:40 +00:00
errors errors: clarify references to Unwrap in doc 2023-11-21 22:04:29 +00:00
expvar all: make more use of the new atomic integer types 2023-11-17 16:39:52 +00:00
flag flag: add available godoc link 2023-10-18 19:36:19 +00:00
fmt
go math/rand/v2: add ChaCha8 2023-12-05 20:32:54 +00:00
hash math/rand, math/rand/v2: use ChaCha8 for global rand 2023-12-05 20:34:30 +00:00
html html/template: track brace depth for each nested expression 2023-10-16 03:29:27 +00:00
image image: add available godoc link 2023-10-19 12:02:45 +00:00
index/suffixarray index/suffixarray: add available godoc link 2023-10-13 19:15:06 +00:00
internal math/rand, math/rand/v2: use ChaCha8 for global rand 2023-12-05 20:34:30 +00:00
io io/fs, os: unify PathError.Path for dirFS.{ReadFile, ReadDir} 2023-11-27 16:25:41 +00:00
log log/slog: correct doc examples for Handler.WithGroup 2023-12-05 18:18:13 +00:00
maps maps: fix aliasing problems with Clone 2023-12-05 17:05:56 +00:00
math math/rand, math/rand/v2: use ChaCha8 for global rand 2023-12-05 20:34:30 +00:00
mime
net math/rand, math/rand/v2: use ChaCha8 for global rand 2023-12-05 20:34:30 +00:00
os math/rand, math/rand/v2: use ChaCha8 for global rand 2023-12-05 20:34:30 +00:00
path path: add available godoc link 2023-11-23 17:33:57 +00:00
plugin plugin: add available godoc link 2023-11-06 19:46:10 +00:00
reflect internal/abi, runtime, reflect, cmd: merge maxZero const into internal/abi 2023-11-22 03:56:03 +00:00
regexp
runtime math/rand, math/rand/v2: use ChaCha8 for global rand 2023-12-05 20:34:30 +00:00
slices slices: improve Insert panic message for index out of range 2023-11-19 17:06:47 +00:00
sort sort: add available godoc link 2023-11-28 16:40:32 +00:00
strconv all: drop old +build lines 2023-10-19 23:33:27 +00:00
strings src: a/an grammar fixes 2023-11-20 15:56:08 +00:00
sync math/rand, math/rand/v2: use ChaCha8 for global rand 2023-12-05 20:34:30 +00:00
syscall syscall: remove ptrace1 on darwin 2023-11-27 21:34:30 +00:00
testdata
testing testing: add regression tests for reentrant calls to T.Run 2023-12-01 21:27:08 +00:00
text text/template: more godoc links 2023-11-27 18:01:48 +00:00
time all: fix function names 2023-10-14 22:30:23 +00:00
unicode unicode: add available godoc link 2023-11-06 20:02:46 +00:00
unsafe
vendor all: update vendored dependencies 2023-11-29 21:28:33 +00:00
Make.dist
README.vendor
all.bash
all.bat
all.rc
bootstrap.bash
buildall.bash
clean.bash
clean.bat
clean.rc
cmp.bash
go.mod all: update vendored dependencies 2023-11-29 21:28:33 +00:00
go.sum all: update vendored dependencies 2023-11-29 21:28:33 +00:00
make.bash
make.bat
make.rc
race.bash
race.bat
run.bash
run.bat
run.rc

README.vendor

Vendoring in std and cmd
========================

The Go command maintains copies of external packages needed by the
standard library in the src/vendor and src/cmd/vendor directories.

There are two modules, std and cmd, defined in src/go.mod and
src/cmd/go.mod. When a package outside std or cmd is imported
by a package inside std or cmd, the import path is interpreted
as if it had a "vendor/" prefix. For example, within "crypto/tls",
an import of "golang.org/x/crypto/cryptobyte" resolves to
"vendor/golang.org/x/crypto/cryptobyte". When a package with the
same path is imported from a package outside std or cmd, it will
be resolved normally. Consequently, a binary may be built with two
copies of a package at different versions if the package is
imported normally and vendored by the standard library.

Vendored packages are internally renamed with a "vendor/" prefix
to preserve the invariant that all packages have distinct paths.
This is necessary to avoid compiler and linker conflicts. Adding
a "vendor/" prefix also maintains the invariant that standard
library packages begin with a dotless path element.

The module requirements of std and cmd do not influence version
selection in other modules. They are only considered when running
module commands like 'go get' and 'go mod vendor' from a directory
in GOROOT/src.

Maintaining vendor directories
==============================

Before updating vendor directories, ensure that module mode is enabled.
Make sure that GO111MODULE is not set in the environment, or that it is
set to 'on' or 'auto'.

Requirements may be added, updated, and removed with 'go get'.
The vendor directory may be updated with 'go mod vendor'.
A typical sequence might be:

    cd src
    go get golang.org/x/net@master
    go mod tidy
    go mod vendor

Use caution when passing '-u' to 'go get'. The '-u' flag updates
modules providing all transitively imported packages, not only
the module providing the target package.

Note that 'go mod vendor' only copies packages that are transitively
imported by packages in the current module. If a new package is needed,
it should be imported before running 'go mod vendor'.