Matthew Dempsky 27691fa467 cmd/compile: recognize !typedbool is typed ... Adding the evconst(n) call for OANDAND and OOROR in golang.org/cl/18262 was originally just to parallel the above iscmp branch, but upon further inspection it seemed odd that removing it caused test/fixedbugs/issue6671.go's var b mybool // ... b = bool(true) && true // ERROR "cannot use" to start failing (i.e., by not emitting the expected "cannot use" error). The problem is that evconst(n)'s settrue and setfalse paths always reset n.Type to idealbool, even for logical operators where n.Type should preserve the operand type. Adding the evconst(n) call for OANDAND/OOROR inadvertantly worked around this by turning the later evconst(n) call at line 2167 into a noop, so the "n.Type = t" assignment at line 739 would preserve the operand type. However, that means evconst(n) was still clobbering n.Type for ONOT, so declarations like: const _ bool = !mybool(true) were erroneously accepted. Update #13821. Change-Id: I18e37287f05398fdaeecc0f0d23984e244f025da Reviewed-on: https://go-review.googlesource.com/18362 Run-TryBot: Matthew Dempsky <mdempsky@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Russ Cox <rsc@golang.org>		2016-01-07 21:43:47 +00:00
..
bench	test/bench/shootout: delete	2016-01-06 17:58:27 +00:00
bugs	test: migrate remaining tests to run.go	2014-12-22 22:41:34 +00:00
chan	Fix several out of date references to 4g/5g/6g/8g/9g.	2015-06-26 03:38:21 +00:00
ddd2.dir	…
dwarf	…
fixedbugs	cmd/compile: recognize !typedbool is typed	2016-01-07 21:43:47 +00:00
import2.dir	…
import4.dir	test: adjust gccgo expected import errors	2015-10-07 14:37:44 +00:00
interface	cmd/internal/gc: improve "type *X has no field or method M" message	2015-05-07 16:21:57 +00:00
ken	…
method4.dir	…
safe	…
stress	build: adjustments for move from src/pkg to src	2014-09-08 00:06:45 -04:00
syntax	cmd/compile: better syntax error recovery	2015-11-20 19:56:27 +00:00
64bit.go	…
235.go	…
alias.go	…
alias1.go	…
append.go	…
args.go	…
assign.go	cmd/gc: prohibit short variable declarations containing duplicate symbols	2014-10-06 17:16:39 -04:00
assign1.go	…
bigalg.go	…
bigmap.go	…
blank.go	…
blank1.go	cmd/compile: don't allow blank method declarations on builtins	2015-12-02 18:26:38 +00:00
bom.go	…
bombad.go	…
bounds.go	…
chancap.go	…
chanlinear.go	runtime: test for linear enqueue/dequeue behavior	2014-12-08 22:18:17 +00:00
char_lit.go	…
char_lit1.go	…
clearfat.go	[dev.power64] 9g: fix under-zeroing in clearfat	2014-10-31 11:08:27 -04:00
closedchan.go	…
closure.go	…
closure1.go	cmd/gc: capture variables by value	2015-01-29 13:07:30 +00:00
closure2.go	cmd/gc: fix capturing by value for range statements	2015-02-03 15:48:48 +00:00
cmp.go	Fix several out of date references to 4g/5g/6g/8g/9g.	2015-06-26 03:38:21 +00:00
cmp6.go	…
cmplx.go	…
cmplxdivide.c	test: comment the behavior and use of cmplxdivide*	2015-01-15 00:00:06 +00:00
cmplxdivide.go	test: comment the behavior and use of cmplxdivide*	2015-01-15 00:00:06 +00:00
cmplxdivide1.go	…
complit.go	…
complit1.go	cmd/internal/gc: accept map literals with omitted key type	2015-06-04 02:31:38 +00:00
compos.go	…
const.go	cmd/compile: allow huge rsh in constants arithmetic	2015-08-21 20:27:22 +00:00
const1.go	…
const2.go	…
const3.go	…
const4.go	all: link to https instead of http	2015-07-11 14:36:33 +00:00
const5.go	all: link to https instead of http	2015-07-11 14:36:33 +00:00
const6.go	…
convT2X.go	…
convert.go	…
convert1.go	…
convert3.go	…
convlit.go	cmd/internal/gc: unsafe.Pointer constants may only be converted to uintptr	2015-05-07 23:54:28 +00:00
convlit1.go	…
copy.go	…
crlf.go	…
ddd.go	…
ddd1.go	…
ddd2.go	…
decl.go	…
declbad.go	…
defer.go	…
deferfin.go	…
deferprint.go	…
deferprint.out	…
divide.go	…
divmod.go	…
empty.go	…
env.go	…
eof.go	…
eof1.go	…
errchk	Fix several out of date references to 4g/5g/6g/8g/9g.	2015-06-26 03:38:21 +00:00
escape.go	…
escape2.go	cmd/compile: escape analysis, don't always escape variadic args	2015-10-04 20:45:35 +00:00
escape2n.go	cmd/compile: escape analysis, don't always escape variadic args	2015-10-04 20:45:35 +00:00
escape3.go	…
escape4.go	cmd/internal/gc: transitive inlining	2015-02-26 17:36:00 +00:00
escape5.go	cmd/internal/gc: move check for large-hence-heap-allocated types into escape analysis	2015-05-22 02:13:54 +00:00
escape_array.go	cmd/internal/gc: move check for large-hence-heap-allocated types into escape analysis	2015-05-22 02:13:54 +00:00
escape_calls.go	cmd/internal/gc: make indirect calls properly escape-y	2015-05-22 01:36:11 +00:00
escape_closure.go	cmd/internal/gc: improve flow of input params to output params	2015-05-01 13:47:20 +00:00
escape_field.go	cmd/internal/gc: improve flow of input params to output params	2015-05-01 13:47:20 +00:00
escape_iface.go	cmd/compile: add case for ODOTTYPE to escwalk	2015-07-30 17:39:44 +00:00
escape_indir.go	cmd/internal/gc: improve flow of input params to output params	2015-05-01 13:47:20 +00:00
escape_level.go	cmd/internal/gc: improve flow of input params to output params	2015-05-01 13:47:20 +00:00
escape_map.go	test: add tests for escape analysis of interface conversions	2015-03-28 16:15:27 +00:00
escape_param.go	cmd/internal/gc: improve flow of input params to output params	2015-05-01 13:47:20 +00:00
escape_slice.go	cmd/internal/gc: extend escape analysis to pointers in slices	2015-05-18 15:34:39 +00:00
escape_struct_param1.go	cmd/internal/gc: improve flow of input params to output params	2015-05-01 13:47:20 +00:00
escape_struct_param2.go	cmd/internal/gc: improve flow of input params to output params	2015-05-01 13:47:20 +00:00
escape_struct_return.go	cmd/internal/gc: improve flow of input params to output params	2015-05-01 13:47:20 +00:00
fibo.go	Fix whitespace (use blanks consistently).	2014-12-08 22:22:58 +00:00
finprofiled.go	runtime: fix finalization and profiling of tiny allocations	2015-11-03 18:57:18 +00:00
float_lit.go	…
float_lit2.go	…
float_lit3.go	…
floatcmp.go	…
for.go	…
func.go	…
func1.go	…
func2.go	…
func3.go	…
func4.go	…
func5.go	…
func6.go	Fix several out of date references to 4g/5g/6g/8g/9g.	2015-06-26 03:38:21 +00:00
func7.go	Fix several out of date references to 4g/5g/6g/8g/9g.	2015-06-26 03:38:21 +00:00
func8.go	test: use go:noinline consistently	2015-11-03 02:01:34 +00:00
funcdup.go	…
funcdup2.go	…
gc.go	…
gc1.go	…
gc2.go	test: check for build constraints only upto the first blank line	2015-02-06 05:36:26 +00:00
gcstring.go	…
goprint.go	…
goprint.out	…
goto.go	Revert "cmd/internal/gc: ignore declarations of types for goto validation"	2015-05-15 16:35:49 +00:00
heapsampling.go	test: really force heap profile update in heapsampling.go	2015-11-12 18:32:13 +00:00
helloworld.go	…
helloworld.out	…
if.go	…
import.go	…
import1.go	…
import2.go	…
import4.go	…
import5.go	…
index.go	Fix several out of date references to 4g/5g/6g/8g/9g.	2015-06-26 03:38:21 +00:00
index0.go	…
index1.go	…
index2.go	…
indirect.go	…
indirect1.go	…
init.go	…
init1.go	test: deflake init1.go test, tighten its bounds	2015-02-13 22:13:56 +00:00
initcomma.go	…
initialize.go	…
initializerr.go	…
initloop.go	cmd/compile: use []*Node instead of NodeList in sinit	2015-09-05 02:25:01 +00:00
inline.go	cmd/compile: add support for a go:noinline directive	2015-10-29 23:16:27 +00:00
int_lit.go	…
intcvt.go	…
iota.go	…
label.go	…
label1.go	…
linkmain.go	cmd/link: reject non-package main toplevel.a file, remove dead code	2015-12-17 20:59:51 +00:00
linkmain_run.go	test: fix linkmain test	2015-12-17 23:36:13 +00:00
linkx.go	cmd/link: detect -X setting non-string variable	2015-06-29 20:28:36 +00:00
linkx_run.go	cmd/link: detect -X setting non-string variable	2015-06-29 20:28:36 +00:00
literal.go	…
live.go	test: add -update_errors flag to run script	2015-04-10 11:33:42 +00:00
live1.go	…
live2.go	cmd/gc: allocate non-escaping maps on stack	2015-02-12 09:53:52 +00:00
mallocfin.go	…
map.go	test/mapnan.go: add regression test for non-empty interfaces.	2014-08-06 17:02:55 -04:00
map1.go	…
maplinear.go	test: make maplinear more robust	2014-10-27 18:59:02 -04:00
method.go	…
method1.go	…
method2.go	…
method3.go	…
method4.go	…
method5.go	…
named.go	…
named1.go	cmd/gc: comma-ok assignments produce untyped bool as 2nd result	2014-08-11 16:11:55 -07:00
nil.go	…
nilcheck.go	cmd/gc: optimize existence-only map lookups	2015-01-07 22:36:06 +00:00
nilptr.go	…
nilptr2.go	…
nilptr3.go	test: fix nosplit.go, fixedbugs/issue11656.go and skip two tests for mips64{,le}	2015-11-12 04:52:31 +00:00
nilptr4.go	…
nosplit.go	cmd/internal/obj, cmd/link, runtime: increase stack limit to accommodate larger frames on ppc64x	2015-11-12 22:32:16 +00:00
nul1.go	…
parentype.go	…
peano.go	…
print.go	…
print.out	…
printbig.go	…
printbig.out	…
range.go	…
recover.go	test: add more cases to recover.go	2014-10-22 08:06:15 -07:00
recover1.go	…
recover2.go	…
recover3.go	…
recover4.go	test: move allocation before munmap in recover4	2015-09-16 08:51:48 +00:00
rename.go	…
rename1.go	…
reorder.go	…
reorder2.go	test: use go:noinline consistently	2015-11-03 02:01:34 +00:00
return.go	…
rotate.go	…
rotate0.go	test: re-enable rotate tests	2015-05-28 19:40:58 +00:00
rotate1.go	test: re-enable rotate tests	2015-05-28 19:40:58 +00:00
rotate2.go	test: re-enable rotate tests	2015-05-28 19:40:58 +00:00
rotate3.go	test: re-enable rotate tests	2015-05-28 19:40:58 +00:00
run.go	misc/cgo/stdio: reenable tests	2015-12-05 21:24:30 +00:00
rune.go	…
runtime.go	…
shift1.go	…
shift2.go	…
sieve.go	…
sigchld.go	…
sigchld.out	…
simassign.go	…
sinit.go	cmd/compile: allow static init for unsafe.Pointer(&x) where x is global	2015-07-07 21:51:57 +00:00
sinit_run.go	all: retire architecture letter in file names, public API	2015-05-21 17:32:17 +00:00
sizeof.go	…
slice3.go	cmd/gc, runtime: treat slices and strings like pointers in garbage collection	2014-08-25 14:38:19 -04:00
slice3err.go	…
slicecap.go	cmd/gc, runtime: treat slices and strings like pointers in garbage collection	2014-08-25 14:38:19 -04:00
sliceopt.go	cmd/internal/gc: optimize slice + write barrier	2015-05-13 19:20:39 +00:00
solitaire.go	…
stack.go	…
string_lit.go	…
stringrange.go	…
struct0.go	…
switch.go	…
switch2.go	cmd/compile: address several more 1.6 TODOs in parser	2015-11-21 07:21:23 +00:00
switch3.go	…
switch4.go	…
tinyfin.go	runtime: fix finalization and profiling of tiny allocations	2015-11-03 18:57:18 +00:00
torture.go	…
turing.go	…
typecheck.go	…
typecheckloop.go	cmd/compile: convert typecheck_stack to []*Node	2015-09-06 23:50:51 +00:00
typeswitch.go	…
typeswitch1.go	…
typeswitch2.go	…
typeswitch3.go	…
undef.go	…
utf.go	…
varerr.go	…
varinit.go	…
writebarrier.go	cmd/internal/gc: add missing write barrier in append(x, BigStructWithPointers)	2015-05-19 15:28:29 +00:00
zerodivide.go	…