go/internal
Muir Manders 1428e83b47 lsp/completion: fix bogus generic func conversion
For example:

    func foo[A int | float64](a A) A { return a }

    var _ int = fo<>

Previously at <> we would complete to "int(foo[A int|float64](a A))".
We added the int() type conversion because the returned type param A
was convertible to the expected "int" (i.e. both "int" and "float64"
can be converted). This is a premature suggestion, though, so fix by
suppressing such type conversions for type parameters.

Fixes golang/go#51780.

Change-Id: I63e3bd401a4d9927b9261659812c521c02e33d94
Reviewed-on: https://go-review.googlesource.com/c/tools/+/394016
Run-TryBot: Muir Manders <muir@mnd.rs>
gopls-CI: kokoro <noreply+kokoro@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Robert Findley <rfindley@google.com>
Trust: Hyang-Ah Hana Kim <hyangah@gmail.com>
2022-03-22 17:37:31 +00:00
..
analysisinternal go/analysis/passes/tests: Check malformed fuzz target. 2022-02-16 18:26:19 +00:00
apidiff all: add copyright notices to files that are missing them 2021-01-06 17:23:47 +00:00
event internal/lsp/debug: add a facility to track known bugs 2021-05-10 23:21:19 +00:00
fakenet internal/fakenet: add a fake network connection 2020-05-27 14:27:59 +00:00
fastwalk x/tools/internal/fastwalk: fixes "interrupted system call" error 2021-02-24 01:32:32 +00:00
gocommand internal/imports: update to permit multiple main modules 2022-02-22 17:36:43 +00:00
gopathwalk internal/imports: fix crash when adding stdlib imports 2020-08-13 17:47:04 +00:00
imports internal/imports: update stdlib index for 1.18 2022-03-16 21:19:09 +00:00
jsonrpc2 internal/jsonrpc2: make Serve wait for all connections to close 2021-11-08 20:32:21 +00:00
jsonrpc2_v2 internal/jsonrpc2_v2: fix a racy map assignment in readIncoming 2022-03-01 21:32:50 +00:00
lsp lsp/completion: fix bogus generic func conversion 2022-03-22 17:37:31 +00:00
memoize internal/memoize: do not allow (*Generation).Acquire to fail 2021-12-02 03:25:35 +00:00
packagesinternal internal/lsp/cache: disable network for mod tidy diagnostics 2021-02-05 19:41:14 +00:00
proxydir all: remove version-specific test files 2020-05-28 17:13:50 +00:00
span internal/span: fix a comment about windows drive letters 2021-08-03 19:59:22 +00:00
stack internal/stack: add the leak test 2020-05-27 14:25:42 +00:00
testenv gopls/internal/regtest/codelens: use the test's deadline instead of a hard-coded timeout 2022-01-24 16:28:24 +00:00
tool gopls: cleanup the main help pages 2022-02-02 14:57:28 +00:00
typeparams internal/typeparams: add a generic form of types.AssignableTo 2022-02-08 16:50:25 +00:00
typesinternal internal/typesinternal: update typesinternal for 1.18 2022-02-22 16:42:18 +00:00
xcontext internal/lsp: stop making background contexts everywhere 2019-07-11 16:38:52 +00:00