go/test at 106db71f3779b0ae3e6dc83b22df0cf04bc36629 - go

History

Josh Bleecher Snyder 8607b2e825 cmd/compile: optimize A->B->C Moves that include VarDefs We have an existing optimization that recognizes memory moves of the form A -> B -> C and converts them into A -> C, in the hopes that the store to B will be end up being dead and thus eliminated. However, when A, B, and C are large types, the front end sometimes emits VarDef ops for the moves. This change adds an optimization to match that pattern. This required changing an old compiler test. The test assumed that a temporary was required to deal with a large return value. With this optimization in place, that temporary ended up being eliminated. Triggers 649 times during 'go build -a std cmd'. Cuts 16k off cmd/go. name old object-bytes new object-bytes delta Template 507kB ± 0% 507kB ± 0% -0.15% (p=0.008 n=5+5) Unicode 225kB ± 0% 225kB ± 0% ~ (all equal) GoTypes 1.85MB ± 0% 1.85MB ± 0% ~ (all equal) Flate 328kB ± 0% 328kB ± 0% ~ (all equal) GoParser 402kB ± 0% 402kB ± 0% -0.00% (p=0.008 n=5+5) Reflect 1.41MB ± 0% 1.41MB ± 0% -0.20% (p=0.008 n=5+5) Tar 458kB ± 0% 458kB ± 0% ~ (all equal) XML 601kB ± 0% 599kB ± 0% -0.21% (p=0.008 n=5+5) Change-Id: I9b5f25c8663a0b772ad1ee51fa61f74b74d26dd3 Reviewed-on: https://go-review.googlesource.com/c/143479 Run-TryBot: Josh Bleecher Snyder <josharian@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Michael Munday <mike.munday@ibm.com>		2018-11-11 14:18:33 +00:00
..
alias3.dir	…
bench	test/bench/garbage: update Benchmarks Game URL to new page	2018-09-24 17:11:42 +00:00
chan	…
closure3.dir	cmd/compile: encourage inlining of functions with single-call bodies	2018-11-08 17:29:23 +00:00
codegen	cmd/compile: use ANDCC, ORCC, XORCC to avoid CMP on ppc64x	2018-11-09 19:40:52 +00:00
ddd2.dir	…
dwarf	…
fixedbugs	cmd/compile: optimize A->B->C Moves that include VarDefs	2018-11-11 14:18:33 +00:00
import2.dir	…
import4.dir	…
interface	…
intrinsic.dir	…
ken	test: remove rundircmpout and cmpout actions	2018-05-31 17:36:45 +00:00
linkname.dir	…
method4.dir	…
retjmp.dir	…
stress	…
syntax	…
uintptrescapes.dir	…
64bit.go	…
235.go	…
README.md	…
alg.go	…
alias.go	…
alias1.go	…
alias2.go	cmd/compile: cleanup method symbol creation	2018-04-05 22:01:17 +00:00
alias3.go	…
align.go	test: check that unaligned load-add opcodes work.	2018-04-09 18:57:37 +00:00
append.go	cmd/compile: optimize append(x, make([]T, y)...) slice extension	2018-05-06 04:28:23 +00:00
append1.go	cmd/compile: optimize append(x, make([]T, y)...) slice extension	2018-05-06 04:28:23 +00:00
args.go	…
armimm.go	…
assign.go	…
assign1.go	…
atomicload.go	…
bigalg.go	…
bigmap.go	…
blank.go	…
blank1.go	…
bom.go	…
bombad.go	…
bounds.go	test: gofmt bounds.go	2018-05-29 02:39:16 +00:00
chancap.go	…
chanlinear.go	…
char_lit.go	…
char_lit1.go	…
checkbce.go	test: restore binary.BigEndian use in checkbce	2018-09-24 21:20:51 +00:00
clearfat.go	…
closedchan.go	…
closure.go	…
closure1.go	…
closure2.go	…
closure3.go	all: fix a bunch of misspellings	2018-10-06 15:40:03 +00:00
closure4.go	cmd/compile/internal/gc: add nil check for closure call on wasm	2018-08-14 09:19:38 +00:00
cmp.go	…
cmp6.go	…
cmplx.go	…
cmplxdivide.c	…
cmplxdivide.go	…
cmplxdivide1.go	…
complit.go	…
complit1.go	…
compos.go	…
const.go	…
const1.go	cmd/compile: fix constant pointer comparison failure	2018-04-09 23:19:45 +00:00
const2.go	…
const3.go	…
const4.go	…
const5.go	…
const6.go	…
convT2X.go	…
convert.go	…
convert1.go	…
convert2.go	…
convert3.go	…
convlit.go	…
convlit1.go	…
copy.go	…
copy1.go	…
crlf.go	…
ddd.go	…
ddd1.go	…
ddd2.go	…
decl.go	…
declbad.go	…
defer.go	…
deferfin.go	…
deferprint.go	test: remove rundircmpout and cmpout actions	2018-05-31 17:36:45 +00:00
deferprint.out	…
devirt.go	…
divide.go	…
divmod.go	…
empty.go	…
env.go	…
eof.go	…
eof1.go	…
escape.go	…
escape2.go	cmd/compile/internal/gc: unify self-assignment checks in esc.go	2018-09-20 09:46:11 +00:00
escape2n.go	cmd/compile/internal/gc: unify self-assignment checks in esc.go	2018-09-20 09:46:11 +00:00
escape3.go	…
escape4.go	cmd/compile: fix panic-okay-to-inline change; adjust tests	2018-06-06 20:35:23 +00:00
escape5.go	cmd/compile: in escape analysis, use element type for OIND of slice	2018-04-18 02:59:37 +00:00
escape_array.go	…
escape_because.go	test: remove go:noinline from escape_because.go	2018-09-05 10:45:58 +00:00
escape_calls.go	…
escape_closure.go	…
escape_field.go	…
escape_iface.go	…
escape_indir.go	…
escape_level.go	…
escape_map.go	…
escape_param.go	cmd/compile/internal/gc: fix mayAffectMemory in esc.go	2018-09-05 14:16:25 +00:00
escape_slice.go	…
escape_struct_param1.go	…
escape_struct_param2.go	…
escape_struct_return.go	…
fibo.go	…
finprofiled.go	…
float_lit.go	…
float_lit2.go	…
float_lit3.go	…
floatcmp.go	…
for.go	…
func.go	…
func1.go	…
func2.go	…
func3.go	…
func4.go	…
func5.go	…
func6.go	…
func7.go	…
func8.go	…
funcdup.go	…
funcdup2.go	…
gc.go	…
gc1.go	…
gc2.go	all: skip unsupported tests for js/wasm	2018-04-30 19:39:18 +00:00
gcgort.go	test: fast GC+concurrency+types verification	2018-05-08 21:15:48 +00:00
gcstring.go	…
goprint.go	test: remove rundircmpout and cmpout actions	2018-05-31 17:36:45 +00:00
goprint.out	…
goto.go	…
heapsampling.go	…
helloworld.go	test: remove rundircmpout and cmpout actions	2018-05-31 17:36:45 +00:00
helloworld.out	…
if.go	…
import.go	…
import1.go	…
import2.go	…
import4.go	…
import5.go	…
import6.go	…
index.go	…
index0.go	…
index1.go	…
index2.go	…
indirect.go	…
indirect1.go	…
init.go	…
init1.go	…
initcomma.go	…
initialize.go	…
initializerr.go	…
initloop.go	…
inline.go	cmd/compile: encourage inlining of functions with single-call bodies	2018-11-08 17:29:23 +00:00
inline_big.go	cmd/compile: set stricter inlining threshold in large functions	2018-07-24 16:11:08 +00:00
inline_caller.go	…
inline_callers.go	…
inline_literal.go	…
inline_math_bits_rotate.go	cmd/compile: make math/bits.RotateLeft* an intrinsic on amd64	2018-08-30 22:48:28 +00:00
inline_variadic.go	…
int_lit.go	…
intcvt.go	…
intrinsic.go	…
intrinsic_atomic.go	…
iota.go	…
label.go	…
label1.go	…
linkmain.go	…
linkmain_run.go	all: skip unsupported tests for js/wasm	2018-04-30 19:39:18 +00:00
linkname.go	…
linkobj.go	all: skip unsupported tests for js/wasm	2018-04-30 19:39:18 +00:00
linkx.go	…
linkx_run.go	all: skip unsupported tests for js/wasm	2018-04-30 19:39:18 +00:00
literal.go	…
live.go	cmd/compile: provide types for all order-allocated temporaries	2018-10-15 16:07:52 +00:00
live1.go	…
live2.go	cmd/compile,runtime: remove ambiguously live logic	2018-10-03 19:54:16 +00:00
live_syscall.go	cmd/compile: encourage inlining of functions with single-call bodies	2018-11-08 17:29:23 +00:00
locklinear.go	test: skip locklinear's lockmany test for now	2018-04-05 10:53:40 +00:00
loopbce.go	cmd/compile: ensure that loop condition is detected correctly	2018-07-09 18:23:39 +00:00
makechan.go	…
makemap.go	…
makenew.go	…
mallocfin.go	…
map.go	…
map1.go	…
mapclear.go	cmd/compile: optimize map-clearing range idiom	2018-05-08 21:15:16 +00:00
maplinear.go	…
mergemul.go	…
method.go	…
method1.go	…
method2.go	…
method3.go	…
method4.go	…
method5.go	…
method6.go	…
method7.go	cmd/compile: fix method expressions with anonymous receivers	2018-04-06 15:39:11 +00:00
named.go	…
named1.go	…
nil.go	…
nilcheck.go	…
nilptr.go	…
nilptr2.go	…
nilptr3.go	cmd/compile: remove unnecessary nil-check	2018-09-04 17:44:14 +00:00
nilptr3_wasm.go	test: fix nilptr3 check for wasm	2018-09-05 09:57:32 +00:00
nilptr4.go	…
nosplit.go	all: skip unsupported tests on AIX	2018-11-02 16:12:08 +00:00
notinheap.go	cmd/compile: disallow converting string to notinheap slice	2018-11-02 19:53:59 +00:00
notinheap2.go	…
notinheap3.go	…
nowritebarrier.go	…
nul1.go	…
opt_branchlikely.go	…
parentype.go	…
peano.go	all: skip unsupported tests for js/wasm	2018-04-30 19:39:18 +00:00
phiopt.go	…
print.go	test: remove rundircmpout and cmpout actions	2018-05-31 17:36:45 +00:00
print.out	…
printbig.go	test: remove rundircmpout and cmpout actions	2018-05-31 17:36:45 +00:00
printbig.out	…
prove.go	cmd/compile: in prove, fix fence-post implications for unsigned domain	2018-08-31 08:54:38 +00:00
range.go	…
recover.go	…
recover1.go	…
recover2.go	…
recover3.go	…
recover4.go	…
recover5.go	…
reflectmethod1.go	…
reflectmethod2.go	…
reflectmethod3.go	…
reflectmethod4.go	…
rename.go	…
rename1.go	…
reorder.go	…
reorder2.go	…
retjmp.go	…
return.go	…
rotate.go	…
rotate0.go	…
rotate1.go	…
rotate2.go	…
rotate3.go	…
run.go	test: limit runoutput concurrency with -v	2018-10-17 16:42:42 +00:00
rune.go	…
runtime.go	…
shift1.go	…
shift2.go	…
sieve.go	…
sigchld.go	test: remove rundircmpout and cmpout actions	2018-05-31 17:36:45 +00:00
sigchld.out	…
simassign.go	…
sinit.go	…
sinit_run.go	all: skip unsupported tests for js/wasm	2018-04-30 19:39:18 +00:00
sizeof.go	…
slice3.go	…
slice3err.go	…
slicecap.go	…
sliceopt.go	…
solitaire.go	…
stack.go	…
stackobj.go	cmd/compile,runtime: remove ambiguously live logic	2018-10-03 19:54:16 +00:00
stackobj2.go	test: stress test for stack objects	2018-10-03 19:54:29 +00:00
stackobj3.go	cmd/compile,runtime: remove ambiguously live logic	2018-10-03 19:54:16 +00:00
strcopy.go	test: add test to verify that string copies don't get optimized away	2018-06-12 19:10:34 +00:00
strength.go	…
string_lit.go	…
stringrange.go	…
struct0.go	…
switch.go	…
switch2.go	…
switch3.go	…
switch4.go	…
switch5.go	Revert "fmt: fix incorrect format of whole-number floats when using %#v"	2018-10-16 21:54:35 +00:00
switch6.go	…
switch7.go	…
tinyfin.go	…
torture.go	…
turing.go	…
typecheck.go	…
typecheckloop.go	…
typeswitch.go	…
typeswitch1.go	…
typeswitch2.go	test: fix spelling of `caught be the compiler` to `caught by the compiler`	2018-10-04 00:49:49 +00:00
typeswitch3.go	test: fix spelling of `caught be the compiler` to `caught by the compiler`	2018-10-04 00:49:49 +00:00
uintptrescapes.go	…
uintptrescapes2.go	cmd/compile: reuse temporaries in order pass	2018-10-14 05:21:00 +00:00
undef.go	…
utf.go	…
varerr.go	…
varinit.go	…
writebarrier.go	…
zerodivide.go	…

README.md

The test directory contains tests of the Go tool chain and runtime. It includes black box tests, regression tests, and error output tests. They are run as part of all.bash.

To run just these tests, execute:

../bin/go run run.go

Standard library tests should be written as regular Go tests in the appropriate package.

The tool chain and runtime also have regular Go tests in their packages. The main reasons to add a new test to this directory are:

it is most naturally expressed using the test runner; or
it is also applicable to gccgo and other Go tool chains.