go/internal/lsp/testdata
Muir Manders 0bc66720f3 internal/lsp/source: limit to 5 unimported package name candidates
Currently we show up to ~100 unimported package names matching the
completion prefix. This isn't useful since, assuming the user even
wants an unimported package, they will just type more to narrow it
down rather than scroll through 100 options. Having so many candidates
also slows things down due to per-candidate overhead in gopls and in
the LSP client. Now we instead limit to 5 unimported package names.

Unimported package members, on the other hand, make sense to list
many. The user may want to scroll through because they don't remember
the name of what they are looking for. I left the max value at 100.

Change-Id: I00e11fa0420758f8db6c7049f80fa156773a5ee6
Reviewed-on: https://go-review.googlesource.com/c/tools/+/218879
Run-TryBot: Muir Manders <muir@mnd.rs>
Reviewed-by: Heschi Kreinick <heschi@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
2020-02-11 00:32:09 +00:00
..
indirect internal/lsp: add quickfixes for missing dependencies in go.mod 2020-02-07 00:16:14 +00:00
lsp internal/lsp/source: limit to 5 unimported package name candidates 2020-02-11 00:32:09 +00:00
missingdep internal/lsp: add quickfixes for missing dependencies in go.mod 2020-02-07 00:16:14 +00:00
missingtwodep internal/lsp: add quickfixes for missing dependencies in go.mod 2020-02-07 00:16:14 +00:00
unused internal/lsp: add quickfixes for missing dependencies in go.mod 2020-02-07 00:16:14 +00:00