mirror of https://github.com/golang/go.git
090b14e850
In JSON output, the Go command was only setting the Error field for one package involved in an import cycle. As a result, TestResolveImportCycle was dependent on the chosen package, causing flakes when the chosen package is not deterministic. Arguably this behavior should be fixed, both in the go command and in gopls, but for now make the test resilient to choice by asserting on any of the possible errors. Add a new AnyOf expectation to support this type of assertion and tweak the test output formatting. Also update the test to eagerly fail once the didOpen notification has been fully processed, so that we don't have to wait for the assertion timeout. Updates golang/go#52904 Change-Id: Ic209d8fdcb7308c041b287a8f122c47e96d29a96 Reviewed-on: https://go-review.googlesource.com/c/tools/+/406274 Reviewed-by: Michael Matloob <matloob@golang.org> Run-TryBot: Robert Findley <rfindley@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> gopls-CI: kokoro <noreply+kokoro@google.com> |
||
|---|---|---|
| .. | ||
| analysisinternal | ||
| apidiff | ||
| event | ||
| fakenet | ||
| fastwalk | ||
| gocommand | ||
| gopathwalk | ||
| imports | ||
| jsonrpc2 | ||
| jsonrpc2_v2 | ||
| lsp | ||
| memoize | ||
| packagesinternal | ||
| proxydir | ||
| span | ||
| stack | ||
| testenv | ||
| tool | ||
| typeparams | ||
| typesinternal | ||
| xcontext | ||