Ben Shi cd65bbc01b cmd/compile/internal/ssa: optimize 386's subtraction ... The SUBL instruction can take a memory operand, and this CL implements this optimization. The go1 benchmark shows a little improvement. name old time/op new time/op delta BinaryTree17-4 3.27s ± 2% 3.29s ± 3% ~ (p=0.322 n=37+40) Fannkuch11-4 3.49s ± 0% 3.53s ± 1% +1.21% (p=0.000 n=31+40) FmtFprintfEmpty-4 46.2ns ± 3% 46.3ns ± 2% ~ (p=0.351 n=40+28) FmtFprintfString-4 82.0ns ± 3% 81.5ns ± 2% -0.69% (p=0.002 n=40+30) FmtFprintfInt-4 94.6ns ± 3% 94.6ns ± 6% ~ (p=0.913 n=39+37) FmtFprintfIntInt-4 147ns ± 3% 150ns ± 2% +1.72% (p=0.000 n=40+25) FmtFprintfPrefixedInt-4 186ns ± 3% 186ns ± 0% -0.33% (p=0.006 n=40+25) FmtFprintfFloat-4 388ns ± 4% 388ns ± 4% ~ (p=0.162 n=40+40) FmtManyArgs-4 612ns ± 3% 616ns ± 4% ~ (p=0.223 n=40+40) GobDecode-4 7.35ms ± 5% 7.42ms ± 5% ~ (p=0.095 n=40+40) GobEncode-4 7.21ms ± 8% 7.23ms ± 4% ~ (p=0.294 n=40+40) Gzip-4 360ms ± 4% 359ms ± 4% ~ (p=0.097 n=40+40) Gunzip-4 46.1ms ± 3% 45.6ms ± 3% -1.20% (p=0.000 n=40+40) HTTPClientServer-4 64.0µs ± 2% 64.1µs ± 2% ~ (p=0.648 n=39+40) JSONEncode-4 21.9ms ± 4% 22.1ms ± 5% ~ (p=0.086 n=40+40) JSONDecode-4 67.9ms ± 4% 66.7ms ± 4% -1.63% (p=0.000 n=40+40) Mandelbrot200-4 5.19ms ± 3% 5.17ms ± 3% ~ (p=0.881 n=40+40) GoParse-4 3.34ms ± 3% 3.28ms ± 2% -1.78% (p=0.000 n=40+40) RegexpMatchEasy0_32-4 101ns ± 5% 99ns ± 3% -2.40% (p=0.000 n=40+40) RegexpMatchEasy0_1K-4 851ns ± 1% 848ns ± 3% -0.36% (p=0.004 n=33+40) RegexpMatchEasy1_32-4 109ns ± 5% 105ns ± 3% -3.53% (p=0.000 n=39+40) RegexpMatchEasy1_1K-4 1.03µs ± 4% 1.03µs ± 3% ~ (p=0.638 n=40+38) RegexpMatchMedium_32-4 131ns ± 5% 127ns ± 4% -3.36% (p=0.000 n=38+40) RegexpMatchMedium_1K-4 43.4µs ± 4% 43.2µs ± 3% -0.46% (p=0.008 n=40+40) RegexpMatchHard_32-4 2.21µs ± 4% 2.23µs ± 1% +0.77% (p=0.014 n=40+28) RegexpMatchHard_1K-4 67.6µs ± 4% 67.7µs ± 3% +0.11% (p=0.016 n=40+40) Revcomp-4 1.86s ± 3% 1.77s ± 2% -4.81% (p=0.000 n=40+40) Template-4 71.7ms ± 3% 71.6ms ± 4% ~ (p=0.200 n=40+40) TimeParse-4 436ns ± 4% 433ns ± 3% ~ (p=0.358 n=40+40) TimeFormat-4 413ns ± 4% 412ns ± 3% ~ (p=0.415 n=40+40) [Geo mean] 63.9µs 63.6µs -0.49% name old speed new speed delta GobDecode-4 105MB/s ± 5% 104MB/s ± 5% ~ (p=0.096 n=40+40) GobEncode-4 106MB/s ± 7% 106MB/s ± 3% ~ (p=0.385 n=39+40) Gzip-4 54.0MB/s ± 4% 54.0MB/s ± 4% ~ (p=0.100 n=40+40) Gunzip-4 421MB/s ± 3% 426MB/s ± 3% +1.21% (p=0.000 n=40+40) JSONEncode-4 88.5MB/s ± 5% 88.0MB/s ± 5% ~ (p=0.083 n=40+40) JSONDecode-4 28.6MB/s ± 4% 29.1MB/s ± 4% +1.65% (p=0.000 n=40+40) GoParse-4 17.3MB/s ± 3% 17.7MB/s ± 2% +1.82% (p=0.000 n=40+40) RegexpMatchEasy0_32-4 316MB/s ± 5% 323MB/s ± 4% +2.44% (p=0.000 n=40+40) RegexpMatchEasy0_1K-4 1.20GB/s ± 1% 1.21GB/s ± 3% +0.40% (p=0.004 n=33+40) RegexpMatchEasy1_32-4 291MB/s ± 7% 302MB/s ± 4% +3.82% (p=0.000 n=40+40) RegexpMatchEasy1_1K-4 993MB/s ± 4% 990MB/s ± 3% ~ (p=0.623 n=40+38) RegexpMatchMedium_32-4 7.61MB/s ± 5% 7.87MB/s ± 4% +3.36% (p=0.000 n=38+40) RegexpMatchMedium_1K-4 23.6MB/s ± 4% 23.7MB/s ± 4% +0.46% (p=0.007 n=40+40) RegexpMatchHard_32-4 14.5MB/s ± 4% 14.3MB/s ± 1% -0.79% (p=0.017 n=40+28) RegexpMatchHard_1K-4 15.1MB/s ± 4% 15.1MB/s ± 3% -0.11% (p=0.015 n=40+40) Revcomp-4 137MB/s ± 3% 144MB/s ± 3% +5.06% (p=0.000 n=40+40) Template-4 27.1MB/s ± 3% 27.1MB/s ± 4% ~ (p=0.211 n=40+40) [Geo mean] 78.9MB/s 79.7MB/s +1.01% Change-Id: I638fa4fef85833e8605919d693f9570cc3cf7334 Reviewed-on: https://go-review.googlesource.com/107275 Run-TryBot: Keith Randall <khr@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Keith Randall <khr@golang.org>		2018-04-16 04:41:20 +00:00
..
archive	go/printer, gofmt: tuned table alignment for better results	2018-04-04 13:39:34 -07:00
bufio	bufio: document ReadFrom/WriteTo calls to underlying methods	2018-03-28 22:21:52 +00:00
builtin	…
bytes	internal/bytealg: move short string Index implementations into bytealg	2018-03-04 19:49:44 +00:00
cmd	cmd/compile/internal/ssa: optimize 386's subtraction	2018-04-16 04:41:20 +00:00
compress	compress/gzip: do not count header bytes written in Write	2018-04-02 20:18:14 +00:00
container	container/heap: fix comments style	2018-04-11 20:11:09 +00:00
context	context: avoid defer in the cancelCtx.Err method	2018-04-15 21:35:53 +00:00
crypto	crypto/x509: don't return nil, nil from SystemCertPool	2018-04-13 00:52:47 +00:00
database/sql	database/sql: remove a couple redundancies	2018-04-12 19:23:46 +00:00
debug	debug/gosym: intern LineTable strings	2018-04-13 19:52:07 +00:00
encoding	encoding/xml: remove unnecessary if conditions	2018-04-15 16:40:39 +00:00
errors	…
expvar	all: use strings.Builder instead of bytes.Buffer where appropriate	2018-03-26 23:05:53 +00:00
flag	flag: correct zero values when printing defaults	2018-04-01 20:17:22 +00:00
fmt	fmt: document the behaviour of %p on slices	2018-03-30 00:19:36 +00:00
go	go/printer, gofmt: handle raw string literals containing newlines better	2018-04-11 22:03:18 +00:00
hash	crypto: remove hand encoded amd64 instructions	2018-03-01 19:20:53 +00:00
html	text/template: copy Decl field when copying PipeNode	2018-04-10 14:26:58 +00:00
image	all: fix non-standard "DO NOT EDIT" comments for generated files	2018-03-10 17:50:11 +00:00
index/suffixarray	…
internal	net: implement (*syscall.RawConn).Read/Write on Windows	2018-04-14 05:36:36 +00:00
io	io/ioutil: change TempFile prefix to a pattern	2018-04-12 20:00:25 +00:00
log	…
math	all: use new softfloat on GOARM=5	2018-04-13 16:39:39 +00:00
mime	mime: add wasm architecture	2018-04-13 20:20:12 +00:00
net	net/http: remove some stderr log spam	2018-04-16 00:14:39 +00:00
os	os/user: fix build with "osusergo" build tag	2018-04-13 16:51:18 +00:00
path	path/filepath: change example to print the correct path on failure	2018-03-26 17:40:01 +00:00
plugin	…
reflect	reflect: sort exported methods first	2018-03-15 21:56:08 +00:00
regexp	regexp: use sync.Pool to cache regexp.machine objects	2018-04-03 16:03:19 +00:00
runtime	runtime: use internal/cpu.X86.HasAVX2 instead of support_avx2	2018-04-15 20:33:59 +00:00
sort	sort: fix typo, was a mixup between identifiers 'unsorted' and 'data'	2018-03-19 13:09:29 +00:00
strconv	strconv: make code formatting more consistent in doc.go	2018-03-19 12:53:16 +00:00
strings	strings: fix flaky TestBuilderGrow test	2018-04-03 00:11:46 +00:00
sync	cmd/internal/obj/arm: add DMB instruction	2018-03-27 19:54:44 +00:00
syscall	syscall: remove WSAEMSGSIZE	2018-04-14 03:52:37 +00:00
testing	testing: fix testing flags link	2018-03-30 23:34:47 +00:00
text	text/tabwriter: reduce allocations from tracking cells	2018-04-14 14:41:50 +00:00
time	time: add wasm architecture	2018-04-13 21:12:31 +00:00
unicode	…
unsafe	unsafe: fix reference to string header	2018-02-26 18:35:46 +00:00
vendor/golang_org/x	net/http: replace SOCKS client implementation	2018-04-06 23:03:17 +00:00
Make.dist	…
all.bash	…
all.bat	…
all.rc	…
androidtest.bash	androidtest.bash: don't require GOARCH set	2018-03-07 14:01:43 +00:00
bootstrap.bash	…
buildall.bash	…
clean.bash	…
clean.bat	…
clean.rc	…
cmp.bash	…
iostest.bash	iostest.bash: don't build std library twice	2018-03-06 16:08:20 +00:00
make.bash	…
make.bat	build: small cleanup in error message in make.bat	2018-02-26 10:27:14 +00:00
make.rc	…
naclmake.bash	nacl*.bash: pass flags to make.bash	2018-02-14 17:09:31 +00:00
nacltest.bash	nacl*.bash: pass flags to make.bash	2018-02-14 17:09:31 +00:00
race.bash	…
race.bat	…
run.bash	src/run.bash: remove some trailing whitespace	2018-04-01 16:12:47 +00:00
run.bat	…
run.rc	…