07295caad0
The type checker emits a TypeAndValue entry for (among other things) every constant in a Go file. Normally, that cost is moderate. However, in the case of a large slice literal, it can get out of control very quickly. Imagine a code generator that creates a 2KB byte slice literal; that's 2K TypeAndValue entries, each of which is considerably larger than the 1-3 bytes for the source text. Unfortunately, there are a number of such code generators. Notably, there are such slice literals in proto code, e.g. https://github.com/grpc/grpc-go/blob/master/examples/route_guide/routeguide/route_guide.pb.go#L360 This CL changes the type checking code to remove the TypeAndValue entries for slice literals of basic types after the checker returns. In the extreme case of https://github.com/googleapis/go-genproto, which is nothing but protos, I see a ~40% drop in heap usage. I believe this change is generally safe, but there's no way to guarantee it. I don't think any editor features need to know the type or value of an arbitrary slice element, but it is just barely possible that an analyzer does. Change-Id: Iee1af2369f994597a42fd1dcbf8af20faa43410e Reviewed-on: https://go-review.googlesource.com/c/tools/+/308730 Trust: Heschi Kreinick <heschi@google.com> Run-TryBot: Heschi Kreinick <heschi@google.com> gopls-CI: kokoro <noreply+kokoro@google.com> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Robert Findley <rfindley@google.com> |
||
|---|---|---|
| benchmark/parse | ||
| blog | ||
| cmd | ||
| container/intsets | ||
| copyright | ||
| cover | ||
| go | ||
| godoc | ||
| gopls | ||
| imports | ||
| internal | ||
| playground | ||
| present | ||
| refactor | ||
| txtar | ||
| .gitattributes | ||
| .gitignore | ||
| .prettierrc | ||
| AUTHORS | ||
| CONTRIBUTING.md | ||
| CONTRIBUTORS | ||
| LICENSE | ||
| PATENTS | ||
| README.md | ||
| codereview.cfg | ||
| go.mod | ||
| go.sum | ||
README.md
Go Tools
This subrepository holds the source for various packages and tools that support the Go programming language.
Some of the tools, godoc and vet for example, are included in binary Go
distributions.
Others, including the Go guru and the test coverage tool, can be fetched with
go get.
Packages include a type-checker for Go and an implementation of the Static Single Assignment form (SSA) representation for Go programs.
Download/Install
The easiest way to install is to run go get -u golang.org/x/tools/.... You can
also manually git clone the repository to $GOPATH/src/golang.org/x/tools.
JS/CSS Formatting
This repository uses prettier to format JS and CSS files.
The version of prettier used is 1.18.2.
It is encouraged that all JS and CSS code be run through this before submitting a change. However, it is not a strict requirement enforced by CI.
Report Issues / Send Patches
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.
The main issue tracker for the tools repository is located at https://github.com/golang/go/issues. Prefix your issue with "x/tools/(your subdir):" in the subject line, so it is easy to find.