go/src
thepudds 04a9b16f3d cmd/compile/internal/escape: avoid reading ir.Node during inner loop of walkOne
Broadly speaking, escape analysis has two main phases. First, it
traverses the AST while building a data-flow graph of locations and
edges. Second, during "solve", it repeatedly walks the data-flow graph
while carefully propagating information about each location, including
whether a location's address reaches the heap.

Once escape analysis is in the solve phase and repeatedly walking the
data-flow graph, almost all the information it needs is within the
location graph, with a notable exception being the ir.Class of an
ir.Name, which currently must be checked by following a pointer from
the location to its ir.Node.

For typical graphs, that does not matter much, but if the graph becomes
large enough, cache misses in the inner solve loop start to matter more,
and the class is checked many times in the inner loop.

We therefore store the class information on the location in the graph
to reduce how much memory we need to load in the inner loop.

The package github.com/microsoft/typescript-go/internal/checker
has many locations, and compilation currently spends most of its time
in escape analysis.

This CL gives roughly a 30% speedup for wall clock compilation time
for the checker package:

  go1.24.0:      91.79s
  this CL:       64.98s

Linux perf shows a healthy reduction for example in l2_request.miss and
dTLB-load-misses on an amd64 test VM.

We could tweak things a bit more, though initial review feedback
has suggested it would be good to get this in as it stands.

Subsequent CLs in this stack give larger improvements.

Updates #72815

Change-Id: I3117430dff684c99e6da1e0d7763869873379238
Reviewed-on: https://go-review.googlesource.com/c/go/+/657295
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Keith Randall <khr@google.com>
Reviewed-by: Jake Bailey <jacob.b.bailey@gmail.com>
Reviewed-by: David Chase <drchase@google.com>
2025-04-21 15:44:05 -07:00
..
archive
arena
bufio
builtin
bytes
cmd cmd/compile/internal/escape: avoid reading ir.Node during inner loop of walkOne 2025-04-21 15:44:05 -07:00
cmp
compress
container
context context: don't return a nil Cause for a canceled custom context 2025-04-08 14:04:56 -07:00
crypto crypto/sha512: remove unnecessary move op, replace with direct add 2025-04-20 21:03:00 -07:00
database/sql database/sql: wake cleaner if maxIdleTime set to less than maxLifetime 2025-04-16 22:57:52 -07:00
debug all: use strings.ReplaceAll where applicable 2025-04-16 12:26:29 -07:00
embed
encoding encoding/json: add json/v2 with GOEXPERIMENT=jsonv2 guard 2025-04-18 08:24:07 -07:00
errors errors: optimize errors.Join for single unwrappable errors 2025-04-14 06:49:08 -07:00
expvar
flag
fmt
go math/big: new mini-compiler for arith assembly 2025-04-19 08:19:14 -07:00
hash
html
image
index/suffixarray
internal internal/runtime/maps: move tombstone test to swiss file 2025-04-18 08:30:30 -07:00
io fs: clarify documentation for ReadDir method 2025-04-19 16:07:50 -07:00
iter iter: reduce memory footprint of iter.Pull functions 2025-04-14 15:10:49 -07:00
log log/slog: make examples playable 2025-04-07 09:34:01 -07:00
maps
math math/big: use clearer loop bounds check elimination 2025-04-19 08:19:27 -07:00
mime
net net: simplify readProtocols via sync.OnceFunc 2025-04-19 16:11:06 -07:00
os os: handle trailing slashes in os.RemoveDir on Windows 2025-04-15 11:17:39 -07:00
path path: add Join benchmark 2025-04-14 08:06:30 -07:00
plugin
reflect
regexp regexp/syntax: recognize category aliases like \p{Letter} 2025-04-18 14:13:38 -07:00
runtime internal,runtime: use the builtin clear 2025-04-18 04:21:17 -07:00
slices
sort
strconv strconv: use switch for '+'/'-' prefix handling 2025-04-07 13:36:46 -07:00
strings strings: duplicate alignment test from bytes package 2025-04-15 19:24:07 -07:00
structs
sync sync: add WaitGroup.Go 2025-04-04 08:19:32 -07:00
syscall syscall: remove unused windows function 2025-04-08 17:13:04 -07:00
testdata
testing
text
time encoding/json: add json/v2 with GOEXPERIMENT=jsonv2 guard 2025-04-18 08:24:07 -07:00
unicode unicode: add CategoryAliases, Cn, LC 2025-04-18 14:13:31 -07:00
unique
unsafe
vendor
weak
Make.dist
README.vendor
all.bash
all.bat
all.rc
bootstrap.bash
buildall.bash
clean.bash
clean.bat
clean.rc
cmp.bash
go.mod
go.sum
make.bash
make.bat
make.rc
race.bash
race.bat
run.bash
run.bat
run.rc

README.vendor

Vendoring in std and cmd
========================

The Go command maintains copies of external packages needed by the
standard library in the src/vendor and src/cmd/vendor directories.

There are two modules, std and cmd, defined in src/go.mod and
src/cmd/go.mod. When a package outside std or cmd is imported
by a package inside std or cmd, the import path is interpreted
as if it had a "vendor/" prefix. For example, within "crypto/tls",
an import of "golang.org/x/crypto/cryptobyte" resolves to
"vendor/golang.org/x/crypto/cryptobyte". When a package with the
same path is imported from a package outside std or cmd, it will
be resolved normally. Consequently, a binary may be built with two
copies of a package at different versions if the package is
imported normally and vendored by the standard library.

Vendored packages are internally renamed with a "vendor/" prefix
to preserve the invariant that all packages have distinct paths.
This is necessary to avoid compiler and linker conflicts. Adding
a "vendor/" prefix also maintains the invariant that standard
library packages begin with a dotless path element.

The module requirements of std and cmd do not influence version
selection in other modules. They are only considered when running
module commands like 'go get' and 'go mod vendor' from a directory
in GOROOT/src.

Maintaining vendor directories
==============================

Before updating vendor directories, ensure that module mode is enabled.
Make sure that GO111MODULE is not set in the environment, or that it is
set to 'on' or 'auto', and if you use a go.work file, set GOWORK=off.

Also, ensure that 'go env GOROOT' shows the root of this Go source
tree. Otherwise, the results are undefined. It's recommended to build
Go from source and use that 'go' binary to update its source tree.

Requirements may be added, updated, and removed with 'go get'.
The vendor directory may be updated with 'go mod vendor'.
A typical sequence might be:

    cd src  # or src/cmd
    go get golang.org/x/net@master
    go mod tidy
    go mod vendor

Use caution when passing '-u' to 'go get'. The '-u' flag updates
modules providing all transitively imported packages, not only
the module providing the target package.

Note that 'go mod vendor' only copies packages that are transitively
imported by packages in the current module. If a new package is needed,
it should be imported before running 'go mod vendor'.