mirror of https://github.com/golang/go.git
03e951c4ab
We've recently noted that hashing the packages.Config into the cache key for the type checked package is probably unnecessary, given that all the other critical inputs into the typechecker are already included (packageID, parsed files, and deps). Furthermore, when using a gopls daemon this causes unnecessary cache misses, because the packages.Config includes things like working directory that no longer matter once other inputs to type checking have been computed. Add an experiment flag that removes the packages.Config from the cache key. An experiment is used to stage this change as comprehensively testing the cache is ~impossible. Change-Id: I7ba73daaa71a80ec996decaa9817ec515b5eeb6e Reviewed-on: https://go-review.googlesource.com/c/tools/+/260737 Run-TryBot: Robert Findley <rfindley@google.com> gopls-CI: kokoro <noreply+kokoro@google.com> TryBot-Result: Go Bot <gobot@golang.org> Trust: Robert Findley <rfindley@google.com> Reviewed-by: Rebecca Stambler <rstambler@golang.org> |
||
|---|---|---|
| .. | ||
| analysisinternal | ||
| apidiff | ||
| event | ||
| fakenet | ||
| fastwalk | ||
| gocommand | ||
| gopathwalk | ||
| imports | ||
| jsonrpc2 | ||
| lsp | ||
| memoize | ||
| packagesinternal | ||
| proxydir | ||
| span | ||
| stack | ||
| testenv | ||
| tool | ||
| typesinternal | ||
| xcontext | ||