mirror
/
go
mirror of https://github.com/golang/go.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
go/test
History
Michael Matloob 7afe17bbdb [release-branch.go1.23] go/types, types2: use max(fileVersion, go1.21) if fileVersion present 
Change the rules for how //go:build "file versions" are applied: instead
of considering whether a file version is an upgrade or downgrade from
the -lang version, always use max(fileVersion, go1.21). This prevents
file versions from downgrading the version below go1.21.  Before Go 1.21
the //go:build version did not have the meaning of setting the file's
langage version.

This fixes an issue that was appearing in GOPATH builds: Go 1.23.0
started providing -lang versions to the compiler in GOPATH mode (among
other places) which it wasn't doing before, and it set -lang to the
toolchain version (1.23). Because the -lang version was greater than
go1.21, language version used to compile the file would be set to the
//go:build file version. //go:build file versions below 1.21 could cause
files that could previously build to stop building.

For example, take a Go file with a //go:build line specifying go1.10.
If that file used a 1.18 feature, that use would compile fine with a Go
1.22 toolchain. But it would produce an error when compiling with the
1.23.0 toolchain because it set the language version to 1.10 and
disallowed the 1.18 feature. This breaks backwards compatibility: when
the build tag was added, it did not have the meaning of restricting the
language version.

For #68658
Fixes #69094

Change-Id: I6cedda81a55bcccffaa3501eef9e2be6541b6ece
Reviewed-on: https://go-review.googlesource.com/c/go/+/607955
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Robert Griesemer <gri@google.com>
(cherry picked from commit aeac0b6cbf)
Reviewed-on: https://go-review.googlesource.com/c/go/+/608935
 		2024-08-28 15:43:17 +00:00
..
abi test: migrate remaining files to go:build syntax 2023-10-19 23:33:25 +00:00
alias3.dir
…
arenas reflect: fix ArenaNew to match documentation 2023-06-16 17:08:43 +00:00
asmhdr.dir
…
chan
…
closure3.dir cmd/compile/internal/noder: remove inlined closure naming hack 2023-08-17 19:36:29 +00:00
closure5.dir
…
codegen cmd/compile/ssa: fix (MOVWZreg (RLWINM)) folding on PPC64 2024-06-07 19:02:52 +00:00
ddd2.dir
…
dwarf
…
fixedbugs [release-branch.go1.23] go/types, types2: use max(fileVersion, go1.21) if fileVersion present 2024-08-28 15:43:17 +00:00
import2.dir
…
import4.dir
…
interface
…
intrinsic.dir
…
ken
…
linkname.dir
…
linknameasm.dir cmd/compile: generate args_stackmap for ABI0 assembly func regardless of linkname 2024-06-07 15:22:22 +00:00
method4.dir
…
retjmp.dir
…
runtime
…
stress test/stress: fix typo in comment 2024-03-25 19:21:35 +00:00
syntax
…
typeparam cmd/compile: export/import materialized aliases 2024-04-05 16:29:58 +00:00
uintptrescapes.dir
…
64bit.go
…
235.go
…
README.md internal/testdir: move to cmd/internal/testdir 2023-05-12 17:18:08 +00:00
alg.go
…
alias.go
…
alias1.go
…
alias2.go cmd/compile/internal/noder: enable type aliases in type checker 2024-05-15 15:09:14 +00:00
alias3.go
…
align.go
…
append.go
…
append1.go
…
args.go
…
armimm.go
…
asmhdr.go
…
assign.go
…
assign1.go
…
atomicload.go
…
bigalg.go
…
bigmap.go
…
blank.go
…
blank1.go
…
bom.go
…
bombad.go
…
bounds.go
…
cannotassign.go
…
chancap.go
…
chanlinear.go test: migrate remaining files to go:build syntax 2023-10-19 23:33:25 +00:00
char_lit.go
…
char_lit1.go
…
checkbce.go test: migrate remaining files to go:build syntax 2023-10-19 23:33:25 +00:00
clear.go
…
clearfat.go
…
closedchan.go
…
closure.go
…
closure1.go
…
closure2.go
…
closure3.go test: migrate remaining files to go:build syntax 2023-10-19 23:33:25 +00:00
closure4.go
…
closure5.go
…
closure6.go
…
closure7.go
…
cmp.go
…
cmp6.go
…
cmplx.go
…
cmplxdivide.c
…
cmplxdivide.go
…
cmplxdivide1.go
…
complit.go
…
complit1.go
…
compos.go
…
const.go
…
const1.go
…
const2.go
…
const3.go
…
const4.go
…
const5.go
…
const6.go
…
const7.go
…
const8.go
…
convT2X.go
…
convert.go
…
convert1.go
…
convert2.go
…
convert3.go
…
convert4.go
…
convinline.go
…
convlit.go
…
convlit1.go
…
copy.go
…
copy1.go
…
crlf.go
…
ddd.go
…
ddd1.go
…
ddd2.go
…
decl.go
…
declbad.go
…
defer.go
…
defererrcheck.go
…
deferfin.go
…
defernil.go
…
deferprint.go
…
deferprint.out
…
devirt.go
…
directive.go
…
directive2.go
…
divide.go
…
divmod.go
…
embedfunc.go
…
embedvers.go
…
empty.go
…
env.go test,internal/testdir: don't set GOOS/GOARCH 2023-05-12 12:34:59 +00:00
eof.go
…
eof1.go
…
escape.go
…
escape2.go all: remove newline characters after return statements 2023-12-14 17:22:18 +00:00
escape2n.go all: remove newline characters after return statements 2023-12-14 17:22:18 +00:00
escape3.go
…
escape4.go cmd/compile/internal/inl: inline based on scoring when GOEXPERIMENT=newinliner 2023-09-14 19:43:26 +00:00
escape5.go cmd/compile/internal/noder: stop preserving original const strings 2023-09-08 18:50:24 +00:00
escape_array.go
…
escape_calls.go cmd/compile: fix escape analysis of string min/max 2023-12-05 22:06:07 +00:00
escape_closure.go cmd/compile/internal/escape: optimize indirect closure calls 2023-08-17 16:36:09 +00:00
escape_field.go
…
escape_goto.go
…
escape_hash_maphash.go
…
escape_iface.go test: remove *_unified.go variants 2023-05-23 17:16:35 +00:00
escape_indir.go
…
escape_level.go
…
escape_map.go
…
escape_mutations.go cmd/compile: restore zero-copy string->[]byte optimization 2023-08-18 11:58:37 +00:00
escape_param.go
…
escape_reflect.go cmd/compile/internal/noder: stop preserving original const strings 2023-09-08 18:50:24 +00:00
escape_runtime_atomic.go runtime: migrate internal/atomic to internal/runtime 2024-03-25 19:53:03 +00:00
escape_selfassign.go
…
escape_slice.go cmd/compile/internal/noder: stop preserving original const strings 2023-09-08 18:50:24 +00:00
escape_struct_param1.go
…
escape_struct_param2.go
…
escape_struct_return.go
…
escape_sync_atomic.go
…
escape_unsafe.go
…
fibo.go
…
finprofiled.go test: ignore MemProfileRecords with no live objects in finprofiled.go 2023-11-16 05:48:00 +00:00
float_lit.go
…
float_lit2.go
…
float_lit3.go
…
floatcmp.go
…
for.go test: add test cases for index value with range array clear 2023-07-10 16:36:41 +00:00
func.go
…
func1.go
…
func2.go
…
func3.go
…
func4.go
…
func5.go
…
func6.go
…
func7.go
…
func8.go
…
funcdup.go
…
funcdup2.go
…
fuse.go cmd/compile: improve integer comparisons with numeric bounds 2024-01-23 00:02:36 +00:00
gc.go
…
gc1.go
…
gc2.go test: migrate remaining files to go:build syntax 2023-10-19 23:33:25 +00:00
gcgort.go
…
gcstring.go
…
goprint.go
…
goprint.out
…
goto.go
…
heapsampling.go
…
helloworld.go
…
helloworld.out
…
if.go
…
import.go
…
import1.go
…
import2.go
…
import4.go
…
import5.go
…
import6.go
…
index.go
…
index0.go
…
index1.go
…
index2.go
…
indirect.go
…
indirect1.go
…
init.go
…
init1.go
…
initcomma.go
…
initexp.go
…
initialize.go
…
initializerr.go
…
initloop.go
…
inline.go test: migrate remaining files to go:build syntax 2023-10-19 23:33:25 +00:00
inline_big.go cmd/compile: restore zero-copy string->[]byte optimization 2023-08-18 11:58:37 +00:00
inline_caller.go
…
inline_callers.go
…
inline_endian.go
…
inline_literal.go
…
inline_math_bits_rotate.go test: migrate remaining files to go:build syntax 2023-10-19 23:33:25 +00:00
inline_sync.go sync: use atomic.Uint32 in Once 2023-10-06 21:01:50 +00:00
inline_variadic.go
…
int_lit.go
…
intcvt.go
…
intrinsic.go test: migrate remaining files to go:build syntax 2023-10-19 23:33:25 +00:00
intrinsic_atomic.go test: migrate remaining files to go:build syntax 2023-10-19 23:33:25 +00:00
iota.go
…
label.go
…
label1.go
…
linkmain.go test: migrate remaining files to go:build syntax 2023-10-19 23:33:25 +00:00
linkmain_run.go test: migrate remaining files to go:build syntax 2023-10-19 23:33:25 +00:00
linkname.go
…
linkname3.go cmd/compile: disallow linkname referring to instantiations 2024-05-15 19:27:25 +00:00
linknameasm.go cmd/compile: generate args_stackmap for ABI0 assembly func regardless of linkname 2024-06-07 15:22:22 +00:00
linkobj.go test: migrate remaining files to go:build syntax 2023-10-19 23:33:25 +00:00
linkx.go
…
linkx_run.go test: migrate remaining files to go:build syntax 2023-10-19 23:33:25 +00:00
literal.go
…
literal2.go
…
live.go math/rand, math/rand/v2: use ChaCha8 for global rand 2023-12-05 20:34:30 +00:00
live1.go
…
live2.go cmd/compile/internal/reflectdata: share hmap and hiter types 2023-08-21 23:29:33 +00:00
live_regabi.go math/rand, math/rand/v2: use ChaCha8 for global rand 2023-12-05 20:34:30 +00:00
live_uintptrkeepalive.go test: migrate remaining files to go:build syntax 2023-10-19 23:33:25 +00:00
loopbce.go test: migrate remaining files to go:build syntax 2023-10-19 23:33:25 +00:00
mainsig.go
…
makechan.go all: fix some comments 2024-04-04 14:29:45 +00:00
makemap.go
…
makenew.go
…
makeslice.go
…
mallocfin.go
…
map.go
…
map1.go
…
mapclear.go
…
maplinear.go test: migrate remaining files to go:build syntax 2023-10-19 23:33:25 +00:00
maymorestack.go
…
mergemul.go
…
method.go
…
method1.go
…
method2.go
…
method3.go
…
method4.go
…
method5.go
…
method6.go
…
method7.go
…
named.go
…
named1.go
…
newinline.go cmd/compile/internal/inline: refactor AnalyzeFunc 2023-11-16 20:15:25 +00:00
nil.go
…
nilcheck.go
…
nilptr.go test: migrate remaining files to go:build syntax 2023-10-19 23:33:25 +00:00
nilptr2.go
…
nilptr3.go test: migrate remaining files to go:build syntax 2023-10-19 23:33:25 +00:00
nilptr4.go
…
nilptr5.go test: migrate remaining files to go:build syntax 2023-10-19 23:33:25 +00:00
nilptr5_aix.go test: migrate remaining files to go:build syntax 2023-10-19 23:33:25 +00:00
nilptr5_wasm.go test: migrate remaining files to go:build syntax 2023-10-19 23:33:25 +00:00
nilptr_aix.go test: migrate remaining files to go:build syntax 2023-10-19 23:33:25 +00:00
noinit.go
…
nosplit.go test: migrate remaining files to go:build syntax 2023-10-19 23:33:25 +00:00
nowritebarrier.go cmd/compile: redo IsRuntimePkg/IsReflectPkg predicate 2023-08-22 19:18:21 +00:00
nul1.go
…
opt_branchlikely.go test: migrate remaining files to go:build syntax 2023-10-19 23:33:25 +00:00
parentype.go
…
peano.go
…
phiopt.go test: migrate remaining files to go:build syntax 2023-10-19 23:33:25 +00:00
print.go
…
print.out
…
printbig.go
…
printbig.out
…
prove.go cmd/compile: improve integer comparisons with numeric bounds 2024-01-23 00:02:36 +00:00
prove_constant_folding.go test: migrate remaining files to go:build syntax 2023-10-19 23:33:25 +00:00
prove_invert_loop_with_unused_iterators.go test: migrate remaining files to go:build syntax 2023-10-19 23:33:25 +00:00
range.go
…
range2.go all: rename GOEXPERIMENT=range to rangefunc 2023-11-08 15:32:14 +00:00
range3.go cmd/compile: fix typecheck range over rune literal 2023-12-01 17:20:08 +00:00
range4.go cmd/compile: handle defined iter func type correctly 2024-01-08 16:00:53 +00:00
rangegen.go test: skip rangegen.go on 32-bit platforms 2023-12-18 23:35:19 +00:00
recover.go
…
recover1.go
…
recover2.go
…
recover3.go
…
recover4.go test: migrate remaining files to go:build syntax 2023-10-19 23:33:25 +00:00
recover5.go
…
reflectmethod1.go
…
reflectmethod2.go
…
reflectmethod3.go
…
reflectmethod4.go
…
reflectmethod5.go
…
reflectmethod6.go
…
reflectmethod7.go
…
reflectmethod8.go
…
rename.go
…
rename1.go cmd/compile/internal/types2: only mark variables as used if they are 2023-04-19 14:07:00 +00:00
reorder.go
…
reorder2.go
…
retjmp.go
…
return.go
…
rotate.go
…
rotate0.go
…
rotate1.go
…
rotate2.go
…
rotate3.go
…
rune.go
…
runtime.go
…
shift1.go
…
shift2.go
…
shift3.go
…
sieve.go
…
sigchld.go test: migrate remaining files to go:build syntax 2023-10-19 23:33:25 +00:00
sigchld.out
…
simassign.go
…
sizeof.go
…
slice3.go
…
slice3err.go
…
slicecap.go
…
sliceopt.go
…
solitaire.go
…
stack.go
…
stackobj.go
…
stackobj2.go
…
stackobj3.go
…
strcopy.go
…
strength.go
…
string_lit.go
…
stringrange.go
…
struct0.go
…
switch.go
…
switch2.go
…
switch3.go
…
switch4.go
…
switch5.go
…
switch6.go
…
switch7.go
…
tighten.go cmd/compile: enhance tighten pass for memory values 2023-05-16 01:01:38 +00:00
tinyfin.go
…
torture.go
…
turing.go
…
typecheck.go
…
typecheckloop.go
…
typeswitch.go
…
typeswitch1.go
…
typeswitch2.go
…
typeswitch2b.go
…
typeswitch3.go
…
uintptrescapes.go
…
uintptrescapes2.go
…
uintptrescapes3.go
…
uintptrkeepalive.go
…
undef.go
…
unsafe_slice_data.go
…
unsafe_string.go
…
unsafe_string_data.go
…
unsafebuiltins.go
…
used.go
…
utf.go
…
varerr.go
…
varinit.go
…
winbatch.go
…
writebarrier.go
…
zerodivide.go
…
zerosize.go cmd/link: put zero-sized data symbols at same address as runtime.zerobase 2023-04-28 18:35:43 +00:00

README.md

The test directory contains tests of the Go tool chain and runtime. It includes black box tests, regression tests, and error output tests. They are run as part of all.bash.

To run just these tests, execute:

../bin/go test cmd/internal/testdir

To run just tests from specified files in this directory, execute:

../bin/go test cmd/internal/testdir -run='Test/(file1.go|file2.go|...)'

Standard library tests should be written as regular Go tests in the appropriate package.

The tool chain and runtime also have regular Go tests in their packages. The main reasons to add a new test to this directory are:

  • it is most naturally expressed using the test runner; or
  • it is also applicable to gccgo and other Go tool chains.