History

Rob Findley 4c651fc1fc internal/lsp/source: add inferred types to generic function hover As an experiment, this CL introduces the first gopls feature that is specific to generics: enriching function hover information with inferred types. This is done with no additional gating on build constraints by using the new internal/typeparams package. The marker tests are updated to allow tests that rely on type parameters being enabled. Change-Id: Ic627d64b61a6211389196814edd0abe1484491eb Reviewed-on: https://go-review.googlesource.com/c/tools/+/317452 Trust: Robert Findley <rfindley@google.com> Run-TryBot: Robert Findley <rfindley@google.com> gopls-CI: kokoro <noreply+kokoro@google.com> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>		2021-06-22 16:07:17 +00:00
..
README.md	internal/lsp/semantic: fix some type definitions	2021-03-30 15:15:52 +00:00
normalizer.go	internal/lsp: rewrite the workspace symbol marker tests	2020-11-24 17:38:01 +00:00
tests.go	internal/lsp/source: add inferred types to generic function hover	2021-06-22 16:07:17 +00:00
util.go	internal/lsp, gopls: recover from go-diff panics	2020-12-17 16:56:54 +00:00

README.md

Testing

LSP has "marker tests" defined in internal/lsp/testdata, as well as traditional tests.

Marker tests

Marker tests have a standard input file, like internal/lsp/testdata/foo/bar.go, and some may have a corresponding golden file, like internal/lsp/testdata/foo/bar.go.golden. The former is the "input" and the latter is the expected output.

Each input file contains annotations like //@suggestedfix("}", "refactor.rewrite"). These annotations are interpreted by test runners to perform certain actions. The expected output after those actions is encoded in the golden file.

When tests are run, each annotation results in a new subtest, which is encoded in the golden file with a heading like,

-- suggestedfix_bar_11_21 --
// expected contents go here
-- suggestedfix_bar_13_20 --
// expected contents go here

The format of these headings vary: they are defined by the Golden function for each annotation. In the case above, the format is: annotation name, file name, annotation line location, annotation character location.

So, if internal/lsp/testdata/foo/bar.go has three suggestedfix annotations, the golden file should have three headers with suggestedfix_bar_xx_yy headings.

To see a list of all available annotations, see the exported "expectations" in tests.go.

To run marker tests,

cd /path/to/tools

# The marker tests are located in "internal/lsp", "internal/lsp/cmd, and
# "internal/lsp/source".
go test ./internal/lsp/...

There are quite a lot of marker tests, so to run one individually, pass the test path and heading into a -run argument:

cd /path/to/tools
go test ./internal/lsp/... -v -run TestLSP/Modules/SuggestedFix/bar_11_21

Resetting marker tests

Sometimes, a change is made to lsp that requires a change to multiple golden files. When this happens, you can run,

cd /path/to/tools
./internal/lsp/reset_golden.sh