go/internal/lsp/regtest
Rebecca Stambler 463a76b3dc internal/lsp: only reload invalid metadata when necessary
This change adds a shouldLoad field to knownMetadata so that we can be
more selective about reloading these.

If a package has invalid metadata, but its metadata hasn't changed, we
shouldn't attempt to reload it until the metadata changes.

Fixes golang/go#40312

Change-Id: Icf5a13fd179421b8f70a5eab6a74b30aaf841f49
Reviewed-on: https://go-review.googlesource.com/c/tools/+/298489
Trust: Rebecca Stambler <rstambler@golang.org>
Run-TryBot: Rebecca Stambler <rstambler@golang.org>
gopls-CI: kokoro <noreply+kokoro@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Robert Findley <rfindley@google.com>
2021-06-16 01:55:16 +00:00
..
doc.go internal/lsp: move gopls/internal/regtest -> internal/lsp/regtest 2021-04-23 16:19:37 +00:00
env.go internal/lsp/regtest: add a benchmark for didChange 2021-05-06 02:57:18 +00:00
env_test.go internal/lsp/regtest: add a benchmark for didChange 2021-05-06 02:57:18 +00:00
expectation.go internal/lsp: only reload invalid metadata when necessary 2021-06-16 01:55:16 +00:00
regtest.go internal/lsp/regtest: force GOPACKAGESDRIVER=off 2021-04-30 16:06:43 +00:00
runner.go internal/lsp/cache: don't delete metadata until it's reloaded 2021-06-16 00:19:40 +00:00
wrappers.go internal/lsp/regtest: add a benchmark for didChange 2021-05-06 02:57:18 +00:00