go/misc/cgo
Jay Conrod b27bda0365 [release-branch.go1.13] cmd/go: fix cgo test when min macOS version is set
Regression tests for #24161 use a macro to conditionally compile some
stub definitions. The macro tests that the minimum macOS version is
less than 10.12.

We get duplicate definitions when building this test with
CGO_CFLAGS=-mmacosx-version-min=10.x where 10.x < 10.12. With this
change, we use a different macro, __MAC_OS_X_VERSION_MAX_ALLOWED__,
which tests the SDK version instead of the minimum macOS version. This
checks whether these definitions are present in headers.

After this change, 'go tool dist test cgo_test' should pass with
CGO_FLAGS=-mmacosx-version-min=10.10.

Updates #36846
Updates #35459

Change-Id: I88d63601c94b0369c73c38d216a2d41ba7d4e579
Reviewed-on: https://go-review.googlesource.com/c/go/+/216243
Run-TryBot: Jay Conrod <jayconrod@google.com>
Reviewed-by: Keith Randall <khr@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
(cherry picked from commit 1f9f88b95e)
Reviewed-on: https://go-review.googlesource.com/c/go/+/217059
Run-TryBot: Carlos Amedee <carlos@golang.org>
Reviewed-by: Jay Conrod <jayconrod@google.com>
2020-02-26 17:04:41 +00:00
..
errors cmd/cgo: do not rewrite call if there are more args than parameters 2019-07-12 17:31:29 +00:00
fortran cmd/compile, misc/cgo: fix fortran tests on aix/ppc64 2019-03-22 13:52:59 +00:00
gmp
life misc/android: enable many more tests on GOOS=android 2019-03-08 23:32:03 +00:00
nocgo
stdio misc/android: enable many more tests on GOOS=android 2019-03-08 23:32:03 +00:00
test [release-branch.go1.13] cmd/go: fix cgo test when min macOS version is set 2020-02-26 17:04:41 +00:00
testasan
testcarchive misc/cgo: disable testcarchive, testplugin during -short test (including all.bash) 2019-05-16 03:25:04 +00:00
testcshared misc/cgo: disable testcarchive, testplugin during -short test (including all.bash) 2019-05-16 03:25:04 +00:00
testgodefs misc/cgo/testgodefs: move source files into testdata 2019-02-26 02:44:12 +00:00
testplugin misc/cgo: disable testcarchive, testplugin during -short test (including all.bash) 2019-05-16 03:25:04 +00:00
testsanitizers runtime: save/restore callee saved registers in arm64's sigtramp 2019-06-03 19:02:11 +00:00
testshared cmd/link: put shlib ".type" functions in internal ABI 2019-07-15 22:54:39 +00:00
testsigfwd
testso misc/cgo: enable testso and testsovar on aix/ppc64 2019-03-27 17:21:28 +00:00
testsovar misc/cgo: enable testso and testsovar on aix/ppc64 2019-03-27 17:21:28 +00:00
testtls