3 Commits

Author	SHA1	Message	Date
Roland Shoemaker	fe37c9e135	all: replace all usages of os/exec with golang.org/x/sys/execabs ... This change ensures that packages using exec.LookPath or exec.Command to find or run binaries do not accidentally run programs from the current directory when they mean to run programs from the system PATH instead. Change-Id: I5907aa630ff64012395a7eb472967a477d90f12e Reviewed-on: https://team-review.git.corp.google.com/c/golang/go-private/+/949438 Reviewed-by: Katie Hockman <katiehockman@google.com> Reviewed-by: Russ Cox <rsc@google.com> Reviewed-on: https://go-review.googlesource.com/c/tools/+/284773 Run-TryBot: Roland Shoemaker <roland@golang.org> gopls-CI: kokoro <noreply+kokoro@google.com> TryBot-Result: Go Bot <gobot@golang.org> Trust: Roland Shoemaker <roland@golang.org> Reviewed-by: Russ Cox <rsc@golang.org>	2021-01-19 22:25:03 +00:00
Agniva De Sarker	79dbfd6c86	cmd/godoc: update findGOROOT ... After godoc stopped being part of the Go distribution, the location of the godoc binary and the go binary can be different. Hence the old GOROOT finding logic does not work anymore. We shell out to "go env GOROOT" to return the new GOROOT. Fixes golang/go#23445 Change-Id: I16e4c0798e3f5cda13d9f6546cf82808a10c4a0b Reviewed-on: https://go-review.googlesource.com/c/tools/+/199279 Reviewed-by: Andrew Bonventre <andybons@golang.org> Run-TryBot: Andrew Bonventre <andybons@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>	2019-10-07 18:40:23 +00:00
Brad Fitzpatrick	8c39fb57ad	cmd/godoc: use same GOROOT discovery as Go 1.10's cmd/go ... Fixes golang/go#23445 Change-Id: I4c707107e636558b49ea9a1a8690723b06dda235 Reviewed-on: https://go-review.googlesource.com/118075 Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Ian Lance Taylor <iant@golang.org>	2018-06-12 01:24:34 +00:00