Adam Langley
bccc337084
json: allow one to unmarshal a top-level JSON array.
...
Fixies issue 114.
R=rsc
CC=golang-dev
https://golang.org/cl/154121
2009-11-13 13:00:45 -08:00
Russ Cox
e7b8f5faca
path.TestWalk: disable error case if root
...
(chmod 0 doesn't cause errors for root)
Fixes #22 .
R=gri
https://golang.org/cl/152120
2009-11-13 11:34:33 -08:00
Adam Langley
87bc9b53fd
json: fix addressing of slice indexes that are multiples of 8.
...
Fixes #147 .
R=rsc
CC=golang-dev
https://golang.org/cl/152123
2009-11-13 11:29:13 -08:00
Adam Langley
3f7a32405d
runtime: warn about SELinux based mmap failures on Linux.
...
SELinux will cause mmap to fail when we request w+x memory unless the
user has configured their policies. We have a warning in make.bash,
but it's quite likely that the policy will be reset at some point and
then all their binaries start failing.
This patch prints a warning on Linux when mmap fails with EACCES.
R=rsc
CC=golang-dev
https://golang.org/cl/152086
2009-11-13 10:08:51 -08:00
Rob Pike
845276ae68
remove dead code from test
...
R=rsc
CC=golang-dev
https://golang.org/cl/152118
2009-11-12 23:35:45 -08:00
Kai Backman
a23746ea65
fix style nit ignored in previous cl
...
R=rsc
https://golang.org/cl/152110
2009-11-12 16:12:28 -08:00
Kai Backman
6a48aab747
add support for pre arm v6 cas. set GOARM=5 to enable.
...
R=rsc
https://golang.org/cl/154101
2009-11-12 15:23:23 -08:00
Russ Cox
b0c7d68052
os.TestSeek: use a smaller but still 64-bit seek offset.
...
Might fix issue 91.
R=r
https://golang.org/cl/152108
2009-11-12 14:55:04 -08:00
Adam Langley
454c621d91
exp/draw: correct Makefile.
...
Thanks to Allister Macleod
Fixes #112 .
R=rsc
CC=golang-dev
https://golang.org/cl/152102
2009-11-12 13:55:20 -08:00
Kai Backman
6dbd142951
add cache flushing call after generating closure.
...
go/test: passes 88% (306/347)
R=rsc
https://golang.org/cl/152089
2009-11-11 23:23:11 -08:00
David Symonds
9e829c42d6
Fix capitalisation of "Git".
...
R=rsc
https://golang.org/cl/154071
2009-11-11 17:31:28 -08:00
Robert Griesemer
23843fa49e
vector: s/Element/interface{}/
...
Fixes #74 .
R=rsc
https://golang.org/cl/154073
2009-11-11 17:25:51 -08:00
Adam Langley
3b092fec36
json: support \u escaping in strings
...
Fixes #73 .
R=rsc
CC=golang-dev
https://golang.org/cl/154072
2009-11-11 17:13:14 -08:00
Russ Cox
2cda46dc82
fix TestRemoveAll again (tested as root this time).
...
Fixes #22 .
R=r
https://golang.org/cl/154069
2009-11-11 15:48:38 -08:00
Russ Cox
f07a9e43e8
os test: do not use symlink > 255 bytes.
...
Fixes #62 .
R=r
https://golang.org/cl/152080
2009-11-11 14:52:29 -08:00
Adam Langley
1941855730
Reland a112249da741, this time with missing file.
2009-11-11 13:21:37 -08:00
Russ Cox
8515a9f4e2
log test: don't assume a fixed set of letters for $GOROOT
...
Fixes #27 .
R=r
https://golang.org/cl/152075
2009-11-11 13:07:46 -08:00
Russ Cox
ed86d0e70a
roll back 3985: build is broken
...
TBR=agl1
CC=golang-dev
https://golang.org/cl/154065
2009-11-11 12:54:52 -08:00
Adam Langley
af1fa43a81
big:
...
Turn methods that don't store the result in their receiver into
functions in order to preserve the convention.
Re-jig Exp and Div by moving their guts into nat.go.
Add ProbablyPrime to perform Miller-Rabin primality tests.
crypto/rsa: reenable key generation since we now have ProbablyPrime.
R=gri
CC=go-dev
http://codereview.prom.corp.google.com/1024038
2009-11-11 12:34:46 -08:00
Russ Cox
1971e1bd21
os: do not test error case of TestRemoveAll when root
...
Fixes #22 .
R=r1, r
https://golang.org/cl/152073
2009-11-11 12:00:34 -08:00
Russ Cox
364e564e3d
use fully qualified names for hash interfaces
...
Fixes #38 .
R=r1, r
https://golang.org/cl/152072
2009-11-11 12:00:15 -08:00
Russ Cox
fe1e49241c
update old comment: things are much better now
...
R=r
https://golang.org/cl/152057
2009-11-10 19:59:22 -08:00
Russ Cox
92a9ddf0fa
net: fix error for connect to /etc/ on some systems
...
R=agl1
CC=golang-dev
https://golang.org/cl/152051
2009-11-10 18:27:26 -08:00
Russ Cox
e23f75b3c4
net: disable more ipv6 tests
...
R=agl, agl1
CC=golang-dev
https://golang.org/cl/153050
2009-11-10 18:00:27 -08:00
Russ Cox
b4a8b353c4
net: disable ipv6 test if we know kernel won't take it.
...
R=agl, agl1
CC=golang-dev
https://golang.org/cl/153048
2009-11-10 17:47:38 -08:00
Russ Cox
9dba695692
net: disable dns error test
...
some dns resolvers (opendns, for example)
are willing to make up results for any name.
R=agl, agl1
CC=golang-dev
https://golang.org/cl/152049
2009-11-10 17:39:01 -08:00
Russ Cox
484f46daea
net: fix dns bug reported on irc.
...
if suffixes don't work, check for name directly.
also fixes short names like bit.ly when ndots>1.
tested by tossing domain and search lines from /etc/resolv.conf
Fixes #2 .
R=agl, agl1
CC=golang-dev
https://golang.org/cl/152048
2009-11-10 17:09:33 -08:00
Robert Griesemer
9e0d2fa89b
better code for a copy loop
...
R=rsc
https://golang.org/cl/152046
2009-11-10 15:33:59 -08:00
Ken Thompson
c90d392ce3
spell it with an "e"
...
R=rsc
http://go/go-review/1025037
2009-11-10 15:05:15 -08:00
Robert Griesemer
b27f05f63b
minor adjustments to package comments for better synopsis.
...
R=rsc
CC=r
http://go/go-review/1026038
2009-11-10 10:55:53 -08:00
Russ Cox
b351113b50
make regexp comment not a package comment
...
R=r
http://go/go-review/1025036
2009-11-10 09:36:48 -08:00
Russ Cox
cb94b60cfb
allow user agent to mention Go.
...
R=r
http://go/go-review/1024046
2009-11-10 09:10:08 -08:00
Robert Griesemer
3d668c1b5d
- minor cleanups
...
- better debugging support
- gofmt -l src misc | wc -l is 0
R=rsc
http://go/go-review/1024042
2009-11-09 22:30:07 -08:00
Robert Griesemer
3bb0032cd6
- replaced gofmt expression formatting algorithm with
...
rsc's algorithm
- applied gofmt -w misc src
- partial CL (last chunk)
R=rsc, r
http://go/go-review/1024041
2009-11-09 21:23:52 -08:00
Robert Griesemer
baba292998
- replaced gofmt expression formatting algorithm with
...
rsc's algorithm
- applied gofmt -w misc src
- partial CL (remaining files in other CLs)
R=rsc, r
http://go/go-review/1026036
2009-11-09 21:13:17 -08:00
Robert Griesemer
1698934194
- replaced gofmt expression formatting algorithm with
...
rsc's algorithm
- applied gofmt -w misc src
- partial CL (remaining files in other CLs)
R=rsc, r
http://go/go-review/1024040
2009-11-09 21:09:34 -08:00
Robert Griesemer
40621d5c0d
remove semis after statements in one-statement statement lists
...
R=rsc, r
http://go/go-review/1025029
2009-11-09 12:07:39 -08:00
Robert Griesemer
81672e79e4
- rename Context to exprContext to remove it from public interface
...
(and to match the style of declContext)
R=rsc
http://go/go-review/1024033
2009-11-09 10:37:36 -08:00
Robert Griesemer
53f485813e
fix for nodeSize computation, used to determine if
...
a node fits on one line:
- for purposes of measuring the node size in text,
don't generate html or use a styler that could
generate html as it will lead to overly large
sizes
A consequence of this bug is that source code displayed
with godoc may show functions that fit on one line in
the source on multiple lines.
This change causes no difference to the gofmt formatting
of any files in src or misc.
R=rsc
http://go/go-review/1026034
2009-11-09 09:34:55 -08:00
Russ Cox
71983af4a1
bug212, bug213.
...
R=ken
http://go/go-review/1026032
2009-11-08 23:22:06 -08:00
Rob Pike
e02f2b51c5
delete a pointless todo in all_test.go.
...
address one in rpc/client.go
R=rsc
CC=go-dev
http://go/go-review/1026030
2009-11-08 21:57:59 -08:00
Russ Cox
ed6eb5b577
a nagging inconsistency: capitalization of
...
HTML vs Html, URL vs Url, HTTP vs Http,
current source is 6:1 in favor of the former,
so change instances of the latter.
R=r
CC=go-dev
http://go/go-review/1024026
2009-11-08 21:46:20 -08:00
Russ Cox
830813f019
assorted cleanup
...
R=r, iant
CC=go-dev
http://go/go-review/1025024
2009-11-08 21:08:27 -08:00
Rob Pike
ceb6031ecd
delete TODO now that compiler is better at %
...
adjust an inconsistency in reflect/type.go's package comment
R=rsc
http://go/go-review/1026029
2009-11-08 20:45:39 -08:00
Rob Pike
40a7db3ee9
add top-level package comments for net, reflect, malloc.
...
reflect is a little more detailed than some because it affords an opportunity
to explain how to approach the library.
R=gri, rsc
CC=go-dev
http://go/go-review/1026026
2009-11-08 15:57:25 -08:00
Robert Griesemer
56b4515740
added package documentation
...
R=r, rsc
http://go/go-review/1025023
2009-11-08 15:04:30 -08:00
Robert Griesemer
1a9805adcb
- avoid division-by-zero crash in tabwriter
...
- correct tabwidth argument for some tabwriter test cases
- catch negative tabwidth flag in gofmt w/o crashing
R=rsc
http://go/go-review/1026022
2009-11-07 23:59:24 -08:00
Vish Subramanian
379150c210
Add flags of type float to the flag package.
...
R=r, rsc
http://go/go-review/1026011
2009-11-07 15:52:27 -08:00
Robert Griesemer
3317697df4
- blank before opening { for multi-line composite literals (as preferred by r)
...
- blank padding around composite literal contents for a less dense look
(most if not all composite literals were written in that style before gofmt
ran through them)
- corresponding (internal) flag: compositeLitBlank
- don't print a semi after a one-statement statement list (as preferred by r)
- corresponding (internal flag): fewerSemis
- the number of changes in nodes.go is huge because of the removed semis;
hg mail requires that I gofmt the file before
With both flags set to false, this CL causes no gofmt formatting change. We
can turn them on if we like it (and then remove the flags). Will submit with
flags disabled.
R=rsc, r
http://go/go-review/1025015
2009-11-07 13:01:52 -08:00
David Symonds
6ea866c04b
Typo fixes.
...
R=rsc
CC=go-dev
http://go/go-review/1026014
2009-11-06 18:43:57 -08:00