2 Commits

Author	SHA1	Message	Date
Rebecca Stambler	0806396f15	internal/lsp: don't show an error for "allExperiments" in (options).set ... Missed this in CL 260002. Added to the unit tests :) Change-Id: I81607fd3cbbf021771e09ecd75952f27a622e754 Reviewed-on: https://go-review.googlesource.com/c/tools/+/260005 Trust: Rebecca Stambler <rstambler@golang.org> Run-TryBot: Rebecca Stambler <rstambler@golang.org> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Robert Findley <rfindley@google.com>	2020-10-07 03:26:33 +00:00
Rob Findley	76a79a66c3	internal/lsp/source: factor out enum options pattern ... Factor out processing of string enums when setting options results. In a couple places this will result in errors being detected for invalid values where they weren't before. Interestingly the default branch for symbolMatcher was 'caseInsensitive', when in fact the default matcher in the absence of any setting is 'fuzzy'. The command tests were implicitly relying on this bug, passing 'default' to mean 'caseInsensitive'. Fix this. Also add a test, since option processing is not trivial. Change-Id: Ib3ec4b1619add4c7315b6a689ca257e068da6027 Reviewed-on: https://go-review.googlesource.com/c/tools/+/258658 Run-TryBot: Robert Findley <rfindley@google.com> gopls-CI: kokoro <noreply+kokoro@google.com> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org> Trust: Robert Findley <rfindley@google.com>	2020-10-02 18:00:38 +00:00