3 Commits

Author	SHA1	Message	Date
Rob Findley	5272f303b6	gopls: fix various staticcheck errors ... Do a pass of unused code cleanup and other staticcheck errors. Change-Id: Iaf5d27c4f5405d4cce3e48fa06a5d46ec757de40 Reviewed-on: https://go-review.googlesource.com/c/tools/+/257965 Run-TryBot: Robert Findley <rfindley@google.com> gopls-CI: kokoro <noreply+kokoro@google.com> Reviewed-by: Rebecca Stambler <rstambler@golang.org> TryBot-Result: Go Bot <gobot@golang.org> Trust: Robert Findley <rfindley@google.com>	2020-09-29 17:30:36 +00:00
Rebecca Stambler	1fd976651f	internal/lsp: make sure that `gofmt -s` analyses don't modify AST ... The code for `gofmt -s` directly modifies the AST, since the ASTs are not long-lived. Some of this code made it into our analysis implementations, causing very strange bugs to manifest. Added a regression test for this specific case. Fixes golang/go#38267 Change-Id: I235620adcbf2bbc7027c6d83ff2c7fe74729062e Reviewed-on: https://go-review.googlesource.com/c/tools/+/227299 Run-TryBot: Rebecca Stambler <rstambler@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Heschi Kreinick <heschi@google.com>	2020-04-06 21:01:14 +00:00
Rohan Challa	e428a8eca3	internal/lsp/analysis: add simplify-composite-lit pass from "gofmt -s" ... This is one of the simplifications that "gofmt -s" applies. https://golang.org/cmd/gofmt/#hdr-The_simplify_command An array, slice, or map composite literal of the form: []T{T{}, T{}} will be simplified to: []T{{}, {}} Updates golang/go#37221 Change-Id: I2dca46501983c8af3581c9319d973da5cf690388 Reviewed-on: https://go-review.googlesource.com/c/tools/+/223660 Run-TryBot: Rohan Challa <rohan@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org> Reviewed-by: Michael Matloob <matloob@golang.org>	2020-03-26 20:50:12 +00:00