mirror/go - go - Git Fam. Sieh

Commit Graph

Author	SHA1	Message	Date
Russ Cox	fcbe51c9e3	misc/cgo/test: make issue5548 test pickier If there is doubt about passing arguments correctly (as there is in this test), there should be doubt about getting the results back intact too. Using 0 and 1 (especially 0 for success) makes it easy to get a PASS accidentally when the return value is not actually being propagated. Use less common values. LGTM=iant R=golang-codereviews, iant CC=golang-codereviews, r https://golang.org/cl/141110043	2014-09-05 14:59:09 -04:00
Ian Lance Taylor	8f7863d638	cmd/cgo: use intgo, not int, for string and slice structures Fixes #5548. R=golang-dev, minux.ma CC=golang-dev https://golang.org/cl/9643044	2013-05-23 22:51:07 -07:00

Author

SHA1

Message

Date

Russ Cox

fcbe51c9e3

misc/cgo/test: make issue5548 test pickier

If there is doubt about passing arguments correctly
(as there is in this test), there should be doubt about
getting the results back intact too. Using 0 and 1
(especially 0 for success) makes it easy to get a PASS
accidentally when the return value is not actually
being propagated. Use less common values.

LGTM=iant
R=golang-codereviews, iant
CC=golang-codereviews, r
https://golang.org/cl/141110043

2014-09-05 14:59:09 -04:00

Ian Lance Taylor

8f7863d638

cmd/cgo: use intgo, not int, for string and slice structures

Fixes #5548.

R=golang-dev, minux.ma
CC=golang-dev
https://golang.org/cl/9643044

2013-05-23 22:51:07 -07:00

2 Commits