mirror/go - go - Git Fam. Sieh

Commit Graph

Author	SHA1	Message	Date
Ian Cottrell	b378960d5b	internal/telemetry: replace event.TagList with event.TagSet This allows us to hide the implementation details of how tags are stored on a context from the normal interface, to allow us to explore more efficient mechanisms. The current storage is not intended as the most efficient choice, this cl is about isolating the API so we can experiment with benchmarks in the future. Change-Id: Ib101416bccd8ecdee269cee636b1564d51e1da8a Reviewed-on: https://go-review.googlesource.com/c/tools/+/222854 Run-TryBot: Ian Cottrell <iancottrell@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Robert Findley <rfindley@google.com>	2020-03-23 14:43:48 +00:00
Ian Cottrell	cb106d260e	internal/telemetry: allow ProcessEvent to modify the event This allows early exporters to adjust the event for later ones. This is used to lookup key values from the context if needed. Also add a Query type event which is intended to perform all event modifications but nothing else, and is used to lookup values from the context. This cleans up a weirdness where the current lookup presumes there will be an exporter with a matching mechanism. Change-Id: I835d1e0b2511553c30f94b7becfe7b7b5462c111 Reviewed-on: https://go-review.googlesource.com/c/tools/+/223657 Run-TryBot: Ian Cottrell <iancottrell@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Emmanuel Odeke <emm.odeke@gmail.com>	2020-03-18 13:22:01 +00:00
Ian Cottrell	d780ff7bdd	internal/telemetry: unify the event handling to an event package This is now the only package that is exposed to normal use, and should be the only thing to appear in libraries. Change-Id: I90ee47c6519f30db16ff5d5d2910be86e91e5df2 Reviewed-on: https://go-review.googlesource.com/c/tools/+/222557 Run-TryBot: Ian Cottrell <iancottrell@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Robert Findley <rfindley@google.com>	2020-03-12 03:58:56 +00:00

Author

SHA1

Message

Date

Ian Cottrell

b378960d5b

internal/telemetry: replace event.TagList with event.TagSet

This allows us to hide the implementation details of how tags are stored on a
context from the normal interface, to allow us to explore more efficient
mechanisms.
The current storage is not intended as the most efficient choice, this cl is
about isolating the API so we can experiment with benchmarks in the future.

Change-Id: Ib101416bccd8ecdee269cee636b1564d51e1da8a
Reviewed-on: https://go-review.googlesource.com/c/tools/+/222854
Run-TryBot: Ian Cottrell <iancottrell@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Robert Findley <rfindley@google.com>

2020-03-23 14:43:48 +00:00

Ian Cottrell

cb106d260e

internal/telemetry: allow ProcessEvent to modify the event

This allows early exporters to adjust the event for later ones.
This is used to lookup key values from the context if needed.
Also add a Query type event which is intended to perform all event
modifications but nothing else, and is used to lookup values from
the context. This cleans up a weirdness where the current lookup
presumes there will be an exporter with a matching mechanism.

Change-Id: I835d1e0b2511553c30f94b7becfe7b7b5462c111
Reviewed-on: https://go-review.googlesource.com/c/tools/+/223657
Run-TryBot: Ian Cottrell <iancottrell@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Emmanuel Odeke <emm.odeke@gmail.com>

2020-03-18 13:22:01 +00:00

Ian Cottrell

d780ff7bdd

internal/telemetry: unify the event handling to an event package

This is now the only package that is exposed to normal use, and should
be the only thing to appear in libraries.

Change-Id: I90ee47c6519f30db16ff5d5d2910be86e91e5df2
Reviewed-on: https://go-review.googlesource.com/c/tools/+/222557
Run-TryBot: Ian Cottrell <iancottrell@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Robert Findley <rfindley@google.com>

2020-03-12 03:58:56 +00:00

3 Commits