3b226f9886
codereview: consistent indent, cut dead code
...
End the charade (farce?) that we are using upload.py unaltered.
Cut all the unused stuff.
Indent using tabs to match the rest of the file.
Next: rewrite MercurialVCS to use mercurial package,
to avoid overhead of forking off a new hg command
multiple times for every file. And parallelize upload.
R=gri
CC=golang-dev
https://golang.org/cl/2009046
2010-08-26 18:24:14 -04:00
4ae2b43ef2
codereview: fix hang on standard hg commands
...
R=gri
CC=golang-dev
https://golang.org/cl/1950045
2010-08-26 17:06:36 -04:00
e3ac0b5d3f
codereview: print status when hung
...
After 30 seconds, start printing status updates,
so that we can see whether hg is making progress.
$ hg upload 1983051
Thu Aug 26 15:06:15 2010 running gofmt
Thu Aug 26 15:06:30 2010 inspecting src/pkg/big/int_test.go
Thu Aug 26 15:06:45 2010 inspecting src/pkg/cmath/conj.go
Thu Aug 26 15:07:00 2010 inspecting src/pkg/expvar/expvar.go
Thu Aug 26 15:07:15 2010 inspecting src/pkg/os/env_unix.go
Thu Aug 26 15:07:30 2010 inspecting src/pkg/os/sys_bsd.go
Thu Aug 26 15:07:45 2010 inspecting src/pkg/rand/rand_test.go
Thu Aug 26 15:08:00 2010 inspecting src/pkg/runtime/sig.go
Thu Aug 26 15:08:15 2010 inspecting src/pkg/time/time_test.go
Thu Aug 26 15:08:30 2010 inspecting src/pkg/websocket/websocket.go
Thu Aug 26 15:08:45 2010 uploading src/pkg/utf8/utf8.go
Thu Aug 26 15:09:00 2010 uploading src/pkg/unicode/letter_test.go
Thu Aug 26 15:09:15 2010 uploading src/pkg/xml/embed_test.go
Thu Aug 26 15:09:30 2010 uploading src/pkg/time/tick.go
Thu Aug 26 15:09:45 2010 uploading src/pkg/big/rat_test.go
Thu Aug 26 15:10:00 2010 uploading src/pkg/time/sleep_test.go
Thu Aug 26 15:10:15 2010 uploading src/pkg/patch/patch_test.go
Thu Aug 26 15:10:30 2010 uploading src/pkg/rand/rand.go
https://golang.org/cl/1983051
$
R=gri
CC=golang-dev
https://golang.org/cl/2020045
2010-08-26 16:27:42 -04:00
e63086548b
codereview: really disable codereview when not available
...
$ hg p
codereview disabled: cannot open /Users/rsc/g/go/src/pkg/goplan9.googlecode.com/hg/lib/codereview/codereview.cfg
$
R=dsymonds, r
CC=golang-dev
https://golang.org/cl/1998046
2010-08-25 17:52:25 -04:00
7886318ca0
codereview: do not send "Abanoned" mail if this CL has
...
not been mailed out for review.
R=r
CC=golang-dev
https://golang.org/cl/1962046
2010-08-12 14:58:38 -07:00
e8b8aeb02a
codereview.py: Fix issues with leading tabulation in the Files: section of CL description.
...
R=imkrasin, rsc
CC=golang-dev
https://golang.org/cl/1943042
2010-08-12 00:04:17 -07:00
bbf925aa56
codereview: avoid crash if no config
...
Fixes #959 .
R=r
CC=golang-dev
https://golang.org/cl/1876045
2010-07-26 17:33:50 -07:00
08e65f79c1
codereview: make 'hg submit' work with Mercurial 1.6
...
R=r
CC=golang-dev
https://golang.org/cl/1841044
2010-07-16 18:54:38 -07:00
ad665e4fde
codereview: don't run gofmt with an empty file list
...
R=gri
CC=golang-dev
https://golang.org/cl/1678054
2010-07-15 16:43:06 -07:00
e8fcf60093
codereview: Fix for Mercurial >= 1.6
...
R=rsc, adg, rsc1
CC=golang-dev
https://golang.org/cl/1804041
2010-07-14 17:17:04 -07:00
93f614ff86
codereview: allow multiple email addresses in CONTRIBUTORS
...
R=r
CC=golang-dev
https://golang.org/cl/1650041
2010-06-30 23:34:11 -07:00
3ca72458ec
codereview: avoid exception in match
...
R=rsc
CC=golang-dev
https://golang.org/cl/1585041
2010-06-09 21:37:11 -07:00
1d6eb74697
codereview: work better with mq
...
R=rsc
CC=golang-dev
https://golang.org/cl/1140043
2010-05-24 14:37:00 -07:00
ee75ffa286
codereview: Mention that deleting a CL is a use of 'hg change' in its header.
...
R=rsc
CC=golang-dev
https://golang.org/cl/903043
2010-04-10 01:53:43 -07:00
e678afa891
codereview.py: fix for compatibility with hg >=1.4.3
...
hg.parseurl now returns a two-value tuple; codereview.py expected 3.
Changed to merely take the first return value.
R=rsc, iant
CC=golang-dev
https://golang.org/cl/223087
2010-03-03 09:03:31 +11:00
4967f857d5
codereview: make sure each mail has a reviewer
...
R=r
CC=golang-dev
https://golang.org/cl/196050
2010-01-28 12:48:21 -08:00
84b044e8fb
codereview: correct handling of files created with hg cp
...
R=r
CC=golang-dev
https://golang.org/cl/194118
2010-01-27 16:14:11 -08:00
ff7343f8d0
codereview: accommodate recent change to ui.prompt
...
Fixes #525 .
R=r
CC=golang-dev
https://golang.org/cl/190044
2010-01-20 09:49:35 -08:00
84ac357c79
codereview: split name list only on commas; some user names have spaces
...
R=r
CC=golang-dev
https://golang.org/cl/184069
2010-01-13 09:09:06 -08:00
752b1702d0
codereview: do not send mail when submitting for others
...
rename original_author to copied_from so that it reads
better when used as a condition.
R=r
CC=golang-dev
https://golang.org/cl/185045
2010-01-09 09:47:14 -08:00
1594730461
codereview: repeated hg mail sends "PTAL"
...
also send out hg mail for TBR submits
R=r
CC=golang-dev
https://golang.org/cl/183137
2010-01-07 18:23:30 -08:00
8274742393
codereview: add golang-dev@googlegroups.com
...
automatically in "hg mail".
also, avoid "empty list means all modified files in client" bug
R=gri, cw
CC=golang-dev
https://golang.org/cl/174072
2009-12-15 13:36:05 -08:00
31645cc0bb
Ported godefs to Windows.
...
R=rsc
https://golang.org/cl/164049
2009-12-13 12:21:44 -08:00
9a86cc679a
codereview: do not gofmt deleted files
...
R=r
https://golang.org/cl/164083
2009-12-03 17:23:11 -08:00
69f893a127
codereview: move reviewers to cc line after submit,
...
so that the issue stops showing up on the
per-reviewer dashboard page.
R=r
https://golang.org/cl/164075
2009-12-02 09:10:59 -08:00
e9a8ab031d
lxml.etree is the wrong location for this alt package
...
on my linux machine this is the correct one. lxml.etree
exists with an ElementTree class, but does not contain
an .XML method.
R=rsc
https://golang.org/cl/163082
2009-12-02 08:18:26 -08:00
742221d20b
xml.etree can also be lxml.etree (e.g. CentOS 5.4 with Python 2.4.3)
...
R=rsc
CC=golang-dev
https://golang.org/cl/164053
2009-12-02 01:16:38 -08:00
cd9d72ba9e
Ports of lib9, libbio and libmach to Windows.
...
R=rsc
https://golang.org/cl/157159
2009-11-30 11:53:11 -08:00
be32c6aaf5
codereview: allow editing of local CL description
...
between hg clpatch and hg submit.
R=r
https://golang.org/cl/162059
2009-11-30 10:28:48 -08:00
19dae0799b
gofmt -r 'α[β:len(α)] -> α[β:]' -w test/bench
...
except chameneosredux which i know is being edited
require gofmt for test/bench
R=r
https://golang.org/cl/157110
2009-11-20 13:11:42 -08:00
caf15f855d
codereview: handle UTF-8 in message descriptions
...
what a terrible way to implement strings
R=r
https://golang.org/cl/156116
2009-11-20 11:19:16 -08:00
c614ffe946
codereview: make hg sync work with Mercurial 1.4
...
R=r
https://golang.org/cl/157102
2009-11-20 00:30:38 -08:00
7db2c799ce
codereview: more attempts at robustness in the face of unexpected exceptions
...
R=r
https://golang.org/cl/156062
2009-11-17 23:23:18 -08:00
aae0aefb70
codereview: handle spaces and other unexpected chars in nicknames
...
R=r
https://golang.org/cl/157053
2009-11-17 16:52:36 -08:00
c7ec6ef859
case insensitive matching in CONTRIBUTORS file
...
R=rsc
https://golang.org/cl/157043
2009-11-17 11:40:25 -08:00
60df923916
codereview: discard \r characters (sigh)
...
R=r
https://golang.org/cl/157041
2009-11-17 09:08:54 -08:00
1a2418f575
codereview: add clpatch --ignore_hgpatch_errors.
...
of limited utility but good for creating the metadata
for an AUTHORS/CONTRIBUTORS change even if
the patch doesn't apply cleanly.
R=r
https://golang.org/cl/154140
2009-11-17 08:47:48 -08:00
152bfa03d8
Pass ui into PostMessage to avoid nasty/confusing exception
...
R=rsc
https://golang.org/cl/155079
2009-11-17 08:32:23 -08:00
780dbdc024
codereview: clpatch tweaks
...
R=agl1
https://golang.org/cl/152114
2009-11-12 18:37:39 -08:00
44fb865a48
default to codereview.appspot.com
...
R=r
http://codereview.prom.corp.google.com/1026040
2009-11-10 15:18:40 -08:00
b1a52ce4a3
make hg mail more forgiving:
...
create CL first, even if gofmt is needed
or no reviewers listed.
R=r
http://go/go-review/1025025
2009-11-08 22:13:10 -08:00
830813f019
assorted cleanup
...
R=r, iant
CC=go-dev
http://go/go-review/1025024
2009-11-08 21:08:27 -08:00
aa2a9e4796
another attempt at utf-8 uploads.
...
the last attempt broke uploads of binary files like .png
R=r
http://go/go-review/1026025
2009-11-08 09:49:13 -08:00
e67161ee3f
fix authentication in parallel LoadAllCL
...
R=r
http://go/go-review/1024018
2009-11-07 18:56:29 -08:00
72a59cecb9
require Mercurial 1.3 again (how did that get dropped?)
...
avoid deprecation warning about os.popen3
R=r
http://go/go-review/1026018
2009-11-07 17:30:40 -08:00
f74beebb2f
codereview: print gofmt message when aborting
...
R=r
CC=vish
http://go/go-review/1026013
2009-11-06 18:40:30 -08:00
88e365ce79
make temporary google.com -> golang.org hack more sophisticated
...
R=r
http://go/go-review/1024013
2009-11-06 17:02:47 -08:00
043486eb3e
require gofmt for all $GOROOT/src/.../*.go.
...
try harder to post messages to rietveld.
R=gri, r
CC=go-dev
http://go/go-review/1024006
2009-11-06 09:45:24 -08:00
f31bc223b3
fix UTF-8 upload bug
...
TBR=r
http://go/go-review/1026001
2009-11-05 18:23:26 -08:00
790c9b59d6
codereview: new commands
...
* clpatch
* download
* submit, on behalf of clpatch
stir hgpatch to fix a few bugs
R=r
CC=go-dev
http://go/go-review/1016051
2009-11-05 14:44:57 -08:00
Russ Cox
Ivan Krasin
Evan Shaw
Paolo Giarrusso
Peter Williams
David Symonds
Andrew Gerrand
Hector Chu
Devon H. O'Dell
Rob Pike